All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Robin Gong <yibin.gong@nxp.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"matthias.schiffer@ew.tq-group.com" 
	<matthias.schiffer@ew.tq-group.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio
Date: Mon, 15 Jun 2020 15:36:22 +0100	[thread overview]
Message-ID: <20200615143622.GX4447@sirena.org.uk> (raw)
In-Reply-To: <VE1PR04MB6638793C00742D5BA72F8AC2899C0@VE1PR04MB6638.eurprd04.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Mon, Jun 15, 2020 at 02:18:54PM +0000, Robin Gong wrote:
> On 2020/06/15 21:39 Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Jun 15, 2020 at 01:35:01PM +0000, Robin Gong wrote:

> > > Then how about choosing specific error code for such dma not ready
> > > case where nothing went out on the bus neither?

> > Yes, that's what I suggested.

> Seems not easy to find a suitable error value, how about EBADR which
> sounds like no any available dma_async_tx_descriptor got by calling dmaengine_prep_slave_sg? 

> #define EBADR           53      /* Invalid request descriptor */

We could also pass in a flag that could be set separately to the error
code to indicate that nothing had happened to the hardware yet.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Robin Gong <yibin.gong@nxp.com>
Cc: "matthias.schiffer@ew.tq-group.com"
	<matthias.schiffer@ew.tq-group.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	Vinod Koul <vkoul@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio
Date: Mon, 15 Jun 2020 15:36:22 +0100	[thread overview]
Message-ID: <20200615143622.GX4447@sirena.org.uk> (raw)
In-Reply-To: <VE1PR04MB6638793C00742D5BA72F8AC2899C0@VE1PR04MB6638.eurprd04.prod.outlook.com>


[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

On Mon, Jun 15, 2020 at 02:18:54PM +0000, Robin Gong wrote:
> On 2020/06/15 21:39 Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Jun 15, 2020 at 01:35:01PM +0000, Robin Gong wrote:

> > > Then how about choosing specific error code for such dma not ready
> > > case where nothing went out on the bus neither?

> > Yes, that's what I suggested.

> Seems not easy to find a suitable error value, how about EBADR which
> sounds like no any available dma_async_tx_descriptor got by calling dmaengine_prep_slave_sg? 

> #define EBADR           53      /* Invalid request descriptor */

We could also pass in a flag that could be set separately to the error
code to indicate that nothing had happened to the hardware yet.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-15 14:36 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 12:58 [PATCH v1 RFC 0/2] introduce fallback to pio in spi core Robin Gong
2020-06-11 12:58 ` Robin Gong
2020-06-11 12:58 ` [PATCH v1 RFC 1/2] spi: introduce fallback to pio Robin Gong
2020-06-11 12:58   ` Robin Gong
2020-06-11 13:40   ` Mark Brown
2020-06-11 13:40     ` Mark Brown
2020-06-12  2:18     ` Robin Gong
2020-06-12  2:18       ` Robin Gong
2020-06-12 10:13       ` Mark Brown
2020-06-12 10:13         ` Mark Brown
2020-06-12 13:48         ` Robin Gong
2020-06-12 13:48           ` Robin Gong
2020-06-12 14:16           ` Mark Brown
2020-06-12 14:16             ` Mark Brown
2020-06-14 13:04             ` Robin Gong
2020-06-14 13:04               ` Robin Gong
2020-06-15  7:19               ` Vinod Koul
2020-06-15  7:19                 ` Vinod Koul
2020-06-15  8:59                 ` Robin Gong
2020-06-15  8:59                   ` Robin Gong
2020-06-15 11:25                   ` Vinod Koul
2020-06-15 11:25                     ` Vinod Koul
2020-06-16  3:05                     ` Robin Gong
2020-06-16  3:05                       ` Robin Gong
2020-06-15 12:35               ` Mark Brown
2020-06-15 12:35                 ` Mark Brown
2020-06-15 13:35                 ` Robin Gong
2020-06-15 13:35                   ` Robin Gong
2020-06-15 13:39                   ` Mark Brown
2020-06-15 13:39                     ` Mark Brown
2020-06-15 14:18                     ` Robin Gong
2020-06-15 14:18                       ` Robin Gong
2020-06-15 14:36                       ` Mark Brown [this message]
2020-06-15 14:36                         ` Mark Brown
2020-06-15 14:53                         ` Robin Gong
2020-06-15 14:53                           ` Robin Gong
2020-06-15 14:55                           ` Mark Brown
2020-06-15 14:55                             ` Mark Brown
2020-06-16  2:03                             ` Robin Gong
2020-06-16  2:03                               ` Robin Gong
2020-06-16  9:59                               ` Mark Brown
2020-06-16  9:59                                 ` Mark Brown
2020-06-16 10:13                                 ` Robin Gong
2020-06-16 10:13                                   ` Robin Gong
2020-06-16 10:26                                   ` Mark Brown
2020-06-16 10:26                                     ` Mark Brown
2020-06-16 12:29                                     ` Robin Gong
2020-06-16 12:29                                       ` Robin Gong
2020-06-11 12:58 ` [PATCH v1 RFC 2/2] spi: spi-imx: add fallback feature Robin Gong
2020-06-11 12:58   ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200615143622.GX4447@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=robin.murphy@arm.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.