From: Robin Gong <yibin.gong@nxp.com> To: Mark Brown <broonie@kernel.org> Cc: Vinod Koul <vkoul@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Date: Tue, 16 Jun 2020 02:03:40 +0000 [thread overview] Message-ID: <VE1PR04MB66380FD8FB7FCE79AF4B6CD4899D0@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200615145556.GY4447@sirena.org.uk> On 2020/06/15 22:56 Mark Brown <broonie@kernel.org> wrote: > On Mon, Jun 15, 2020 at 02:53:29PM +0000, Robin Gong wrote: > > Do you mean spi-imx.c checking 'ctlr->flags' before return such error code? > > Or just like below done in spi.c. > > No, I mean passing in an additional argument which can provide richer data > than trying to smash things into the return value. Okay, how about adding this additional argument in struct spi_transfer like below? diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 95291fe4..7c19099 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -943,6 +943,9 @@ struct spi_transfer { bool timestamped; struct list_head transfer_list; + +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */ + u16 flags; }; While spi core checking it as below after it set in spi-imx.c: fallback_pio: ret = ctlr->transfer_one(ctlr, msg->spi, xfer); if (ret < 0) { if (ctlr->cur_msg_mapped && (xfer->flags & SPI_TRANS_DMA_PREP_FAIL)) { __spi_unmap_msg(ctlr, msg); ctlr->fallback = true; xfer->flags &= ~SPI_TRANS_DMA_PREP_FAIL; goto fallback_pio; }
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <yibin.gong@nxp.com> To: Mark Brown <broonie@kernel.org> Cc: "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robin.murphy@arm.com" <robin.murphy@arm.com>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, Vinod Koul <vkoul@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Date: Tue, 16 Jun 2020 02:03:40 +0000 [thread overview] Message-ID: <VE1PR04MB66380FD8FB7FCE79AF4B6CD4899D0@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200615145556.GY4447@sirena.org.uk> On 2020/06/15 22:56 Mark Brown <broonie@kernel.org> wrote: > On Mon, Jun 15, 2020 at 02:53:29PM +0000, Robin Gong wrote: > > Do you mean spi-imx.c checking 'ctlr->flags' before return such error code? > > Or just like below done in spi.c. > > No, I mean passing in an additional argument which can provide richer data > than trying to smash things into the return value. Okay, how about adding this additional argument in struct spi_transfer like below? diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 95291fe4..7c19099 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -943,6 +943,9 @@ struct spi_transfer { bool timestamped; struct list_head transfer_list; + +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */ + u16 flags; }; While spi core checking it as below after it set in spi-imx.c: fallback_pio: ret = ctlr->transfer_one(ctlr, msg->spi, xfer); if (ret < 0) { if (ctlr->cur_msg_mapped && (xfer->flags & SPI_TRANS_DMA_PREP_FAIL)) { __spi_unmap_msg(ctlr, msg); ctlr->fallback = true; xfer->flags &= ~SPI_TRANS_DMA_PREP_FAIL; goto fallback_pio; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-16 2:03 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-11 12:58 [PATCH v1 RFC 0/2] introduce fallback to pio in spi core Robin Gong 2020-06-11 12:58 ` Robin Gong 2020-06-11 12:58 ` [PATCH v1 RFC 1/2] spi: introduce fallback to pio Robin Gong 2020-06-11 12:58 ` Robin Gong 2020-06-11 13:40 ` Mark Brown 2020-06-11 13:40 ` Mark Brown 2020-06-12 2:18 ` Robin Gong 2020-06-12 2:18 ` Robin Gong 2020-06-12 10:13 ` Mark Brown 2020-06-12 10:13 ` Mark Brown 2020-06-12 13:48 ` Robin Gong 2020-06-12 13:48 ` Robin Gong 2020-06-12 14:16 ` Mark Brown 2020-06-12 14:16 ` Mark Brown 2020-06-14 13:04 ` Robin Gong 2020-06-14 13:04 ` Robin Gong 2020-06-15 7:19 ` Vinod Koul 2020-06-15 7:19 ` Vinod Koul 2020-06-15 8:59 ` Robin Gong 2020-06-15 8:59 ` Robin Gong 2020-06-15 11:25 ` Vinod Koul 2020-06-15 11:25 ` Vinod Koul 2020-06-16 3:05 ` Robin Gong 2020-06-16 3:05 ` Robin Gong 2020-06-15 12:35 ` Mark Brown 2020-06-15 12:35 ` Mark Brown 2020-06-15 13:35 ` Robin Gong 2020-06-15 13:35 ` Robin Gong 2020-06-15 13:39 ` Mark Brown 2020-06-15 13:39 ` Mark Brown 2020-06-15 14:18 ` Robin Gong 2020-06-15 14:18 ` Robin Gong 2020-06-15 14:36 ` Mark Brown 2020-06-15 14:36 ` Mark Brown 2020-06-15 14:53 ` Robin Gong 2020-06-15 14:53 ` Robin Gong 2020-06-15 14:55 ` Mark Brown 2020-06-15 14:55 ` Mark Brown 2020-06-16 2:03 ` Robin Gong [this message] 2020-06-16 2:03 ` Robin Gong 2020-06-16 9:59 ` Mark Brown 2020-06-16 9:59 ` Mark Brown 2020-06-16 10:13 ` Robin Gong 2020-06-16 10:13 ` Robin Gong 2020-06-16 10:26 ` Mark Brown 2020-06-16 10:26 ` Mark Brown 2020-06-16 12:29 ` Robin Gong 2020-06-16 12:29 ` Robin Gong 2020-06-11 12:58 ` [PATCH v1 RFC 2/2] spi: spi-imx: add fallback feature Robin Gong 2020-06-11 12:58 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR04MB66380FD8FB7FCE79AF4B6CD4899D0@VE1PR04MB6638.eurprd04.prod.outlook.com \ --to=yibin.gong@nxp.com \ --cc=broonie@kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=robin.murphy@arm.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.