All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: peterz@infradead.org, jroedel@suse.de,
	Andy Lutomirski <luto@kernel.org>,
	Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
	Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	manvanth@linux.vnet.ibm.com, linux-next@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, hch@lst.de,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file
Date: Wed, 17 Jun 2020 18:12:26 -0700	[thread overview]
Message-ID: <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> (raw)
In-Reply-To: <20200609120533.25867-1-joro@8bytes.org>

On Tue,  9 Jun 2020 14:05:33 +0200 Joerg Roedel <joro@8bytes.org> wrote:

> From: Joerg Roedel <jroedel@suse.de>
> 
> The functions are only used in two source files, so there is no need
> for them to be in the global <linux/mm.h> header. Move them to the new
> <linux/pgalloc-track.h> header and include it only where needed.
> 
> ...
>
> new file mode 100644
> index 000000000000..1dcc865029a2
> --- /dev/null
> +++ b/include/linux/pgalloc-track.h
> @@ -0,0 +1,51 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _LINUX_PGALLLC_TRACK_H
> +#define _LINUX_PGALLLC_TRACK_H

hm, no #includes.  I guess this is OK, given the limited use.

But it does make one wonder whether ioremap.c should be moved from lib/
to mm/ and this file should be moved from include/linux/ to mm/.

Oh well.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Joerg Roedel <joro@8bytes.org>
Cc: linux-arch@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	jroedel@suse.de, linux-mm@kvack.org, peterz@infradead.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
	linux-next@vger.kernel.org,
	Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
	Andy Lutomirski <luto@kernel.org>,
	manvanth@linux.vnet.ibm.com, hch@lst.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file
Date: Wed, 17 Jun 2020 18:12:26 -0700	[thread overview]
Message-ID: <20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org> (raw)
In-Reply-To: <20200609120533.25867-1-joro@8bytes.org>

On Tue,  9 Jun 2020 14:05:33 +0200 Joerg Roedel <joro@8bytes.org> wrote:

> From: Joerg Roedel <jroedel@suse.de>
> 
> The functions are only used in two source files, so there is no need
> for them to be in the global <linux/mm.h> header. Move them to the new
> <linux/pgalloc-track.h> header and include it only where needed.
> 
> ...
>
> new file mode 100644
> index 000000000000..1dcc865029a2
> --- /dev/null
> +++ b/include/linux/pgalloc-track.h
> @@ -0,0 +1,51 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _LINUX_PGALLLC_TRACK_H
> +#define _LINUX_PGALLLC_TRACK_H

hm, no #includes.  I guess this is OK, given the limited use.

But it does make one wonder whether ioremap.c should be moved from lib/
to mm/ and this file should be moved from include/linux/ to mm/.

Oh well.

  parent reply	other threads:[~2020-06-18  2:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 12:05 [PATCH] mm: Move p?d_alloc_track to separate header file Joerg Roedel
2020-06-09 12:05 ` Joerg Roedel
2020-06-09 15:07 ` Mike Rapoport
2020-06-09 15:07   ` Mike Rapoport
2020-06-09 15:24 ` Christophe Leroy
2020-06-09 15:24   ` Christophe Leroy
2020-06-09 15:53   ` Stephen Rothwell
2020-06-09 15:53     ` Stephen Rothwell
2020-06-18  1:12 ` Andrew Morton [this message]
2020-06-18  1:12   ` Andrew Morton
2020-06-18  9:17   ` Mike Rapoport
2020-06-18  9:17     ` Mike Rapoport
2020-06-18  1:19 ` Stephen Rothwell
2020-06-18  1:19   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617181226.ab213ea1531b5dd6eca1b0b6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=abdhalee@linux.vnet.ibm.com \
    --cc=hch@lst.de \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luto@kernel.org \
    --cc=manvanth@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@linux.ibm.com \
    --cc=sathnaga@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.