From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Joerg Roedel <joro@8bytes.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, jroedel@suse.de, linux-mm@kvack.org,
peterz@infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
Steven Rostedt <rostedt@goodmis.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
linux-next@vger.kernel.org,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
Andy Lutomirski <luto@kernel.org>,
manvanth@linux.vnet.ibm.com, hch@lst.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file
Date: Wed, 10 Jun 2020 01:53:27 +1000 [thread overview]
Message-ID: <20200610015327.02d210ba@canb.auug.org.au> (raw)
In-Reply-To: <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Hi Christophe,
On Tue, 9 Jun 2020 17:24:14 +0200 Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
> Le 09/06/2020 à 14:05, Joerg Roedel a écrit :
> > From: Joerg Roedel <jroedel@suse.de>
> >
> > The functions are only used in two source files, so there is no need
> > for them to be in the global <linux/mm.h> header. Move them to the new
> > <linux/pgalloc-track.h> header and include it only where needed.
>
> Do you mean we will now create a new header file for any new couple on
> functions based on where they are used ?
>
> Can you explain why this change is needed or is a plus ?
Well at a minimum, it means 45 lines less to be parsed every time the
linux/mm is included (in at last count, 1996 places some of which are
include files included by other files). And, as someone who does a lot
of builds every day, I am in favour of that :-)
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-arch@vger.kernel.org, manvanth@linux.vnet.ibm.com,
jroedel@suse.de, Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Mike Rapoport <rppt@linux.ibm.com>,
linux-mm@kvack.org, linux-next@vger.kernel.org,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
hch@lst.de
Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file
Date: Wed, 10 Jun 2020 01:53:27 +1000 [thread overview]
Message-ID: <20200610015327.02d210ba@canb.auug.org.au> (raw)
In-Reply-To: <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Hi Christophe,
On Tue, 9 Jun 2020 17:24:14 +0200 Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
>
> Le 09/06/2020 à 14:05, Joerg Roedel a écrit :
> > From: Joerg Roedel <jroedel@suse.de>
> >
> > The functions are only used in two source files, so there is no need
> > for them to be in the global <linux/mm.h> header. Move them to the new
> > <linux/pgalloc-track.h> header and include it only where needed.
>
> Do you mean we will now create a new header file for any new couple on
> functions based on where they are used ?
>
> Can you explain why this change is needed or is a plus ?
Well at a minimum, it means 45 lines less to be parsed every time the
linux/mm is included (in at last count, 1996 places some of which are
include files included by other files). And, as someone who does a lot
of builds every day, I am in favour of that :-)
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-09 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 12:05 [PATCH] mm: Move p?d_alloc_track to separate header file Joerg Roedel
2020-06-09 12:05 ` Joerg Roedel
2020-06-09 15:07 ` Mike Rapoport
2020-06-09 15:07 ` Mike Rapoport
2020-06-09 15:24 ` Christophe Leroy
2020-06-09 15:24 ` Christophe Leroy
2020-06-09 15:53 ` Stephen Rothwell [this message]
2020-06-09 15:53 ` Stephen Rothwell
2020-06-18 1:12 ` Andrew Morton
2020-06-18 1:12 ` Andrew Morton
2020-06-18 9:17 ` Mike Rapoport
2020-06-18 9:17 ` Mike Rapoport
2020-06-18 1:19 ` Stephen Rothwell
2020-06-18 1:19 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610015327.02d210ba@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=hch@lst.de \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=manvanth@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@linux.ibm.com \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.