Re: [PATCH net-next v3 5/7] net: phy: enable qoriq backplane support

From: kernel test robot <lkp@intel.com>
To: Florinel Iordache <florinel.iordache@nxp.com>,
	davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
	f.fainelli@gmail.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH net-next v3 5/7] net: phy: enable qoriq backplane support
Date: Thu, 25 Jun 2020 08:35:25 +0800	[thread overview]
Message-ID: <202006250846.o4cQISE9%lkp@intel.com> (raw)
In-Reply-To: <1592832924-31733-6-git-send-email-florinel.iordache@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 2876 bytes --]

Hi Florinel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Florinel-Iordache/doc-net-add-backplane-documentation/20200622-223623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 29a720c1042f469c8fea317cb5e7f496b116e07d
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 1d4c87335d5236ea1f35937e1014980ba961ae34)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/phy/backplane/qoriq_backplane.c:150:18: warning: no previous prototype for function 'get_serdes_type' [-Wmissing-prototypes]
   enum serdes_type get_serdes_type(struct device_node *serdes_node)
                    ^
   drivers/net/phy/backplane/qoriq_backplane.c:150:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   enum serdes_type get_serdes_type(struct device_node *serdes_node)
   ^
   static 
   1 warning generated.
--
>> drivers/net/phy/backplane/qoriq_serdes_10g.c:120:13: warning: bitwise or with non-zero value always evaluates to true [-Wtautological-bitwise-compare]
           if (ln_req | LANE_RX) {
               ~~~~~~~^~~~~~~~~
   drivers/net/phy/backplane/qoriq_serdes_10g.c:115:13: warning: bitwise or with non-zero value always evaluates to true [-Wtautological-bitwise-compare]
           if (ln_req | LANE_TX) {
               ~~~~~~~^~~~~~~~~
   2 warnings generated.

vim +/get_serdes_type +150 drivers/net/phy/backplane/qoriq_backplane.c

   149	
 > 150	enum serdes_type get_serdes_type(struct device_node *serdes_node)
   151	{
   152		enum serdes_type serdes = SERDES_INVAL;
   153		const char *serdes_comp;
   154		int comp_no, i, ret;
   155	
   156		comp_no = of_property_count_strings(serdes_node, "compatible");
   157		for (i = 0; i < comp_no; i++) {
   158			ret = of_property_read_string_index(serdes_node, "compatible",
   159							    i, &serdes_comp);
   160			if (ret == 0) {
   161				if (!strcasecmp(serdes_comp, "serdes-10g")) {
   162					serdes = SERDES_10G;
   163					break;
   164				}
   165			}
   166		}
   167	
   168		return serdes;
   169	}
   170	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75316 bytes --]