From: "Javier González" <javier@javigon.com> To: linux-nvme@lists.infradead.org Cc: linux-block@vger.kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@kernel.dk, "Javier González" <javier.gonz@samsung.com>, "SelvaKumar S" <selvakuma.s1@samsung.com>, "Kanchan Joshi" <joshi.k@samsung.com>, "Nitesh Shetty" <nj.shetty@samsung.com> Subject: [PATCH 6/6] nvme: Add consistency check for zone count Date: Thu, 25 Jun 2020 14:21:52 +0200 [thread overview] Message-ID: <20200625122152.17359-7-javier@javigon.com> (raw) In-Reply-To: <20200625122152.17359-1-javier@javigon.com> From: Javier González <javier.gonz@samsung.com> Since the number of zones is calculated through the reported device capacity and the ZNS specification allows to report the total number of zones in the device, add an extra check to guarantee consistency between the device and the kernel. Signed-off-by: Javier González <javier.gonz@samsung.com> Signed-off-by: SelvaKumar S <selvakuma.s1@samsung.com> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> --- drivers/nvme/host/zns.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvme/host/zns.c b/drivers/nvme/host/zns.c index 7d8381fe7665..de806788a184 100644 --- a/drivers/nvme/host/zns.c +++ b/drivers/nvme/host/zns.c @@ -234,6 +234,13 @@ static int nvme_ns_report_zones(struct nvme_ns *ns, sector_t sector, sector += ns->zsze * nz; } + if (nr_zones < 0 && zone_idx != ns->nr_zones) { + dev_err(ns->ctrl->device, "inconsistent zone count %u/%u\n", + zone_idx, ns->nr_zones); + ret = -EINVAL; + goto out_free; + } + ret = zone_idx; out_free: kvfree(report); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Javier González" <javier@javigon.com> To: linux-nvme@lists.infradead.org Cc: axboe@kernel.dk, "SelvaKumar S" <selvakuma.s1@samsung.com>, sagi@grimberg.me, "Kanchan Joshi" <joshi.k@samsung.com>, "Nitesh Shetty" <nj.shetty@samsung.com>, linux-block@vger.kernel.org, kbusch@kernel.org, "Javier González" <javier.gonz@samsung.com>, hch@lst.de Subject: [PATCH 6/6] nvme: Add consistency check for zone count Date: Thu, 25 Jun 2020 14:21:52 +0200 [thread overview] Message-ID: <20200625122152.17359-7-javier@javigon.com> (raw) In-Reply-To: <20200625122152.17359-1-javier@javigon.com> From: Javier González <javier.gonz@samsung.com> Since the number of zones is calculated through the reported device capacity and the ZNS specification allows to report the total number of zones in the device, add an extra check to guarantee consistency between the device and the kernel. Signed-off-by: Javier González <javier.gonz@samsung.com> Signed-off-by: SelvaKumar S <selvakuma.s1@samsung.com> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com> --- drivers/nvme/host/zns.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/nvme/host/zns.c b/drivers/nvme/host/zns.c index 7d8381fe7665..de806788a184 100644 --- a/drivers/nvme/host/zns.c +++ b/drivers/nvme/host/zns.c @@ -234,6 +234,13 @@ static int nvme_ns_report_zones(struct nvme_ns *ns, sector_t sector, sector += ns->zsze * nz; } + if (nr_zones < 0 && zone_idx != ns->nr_zones) { + dev_err(ns->ctrl->device, "inconsistent zone count %u/%u\n", + zone_idx, ns->nr_zones); + ret = -EINVAL; + goto out_free; + } + ret = zone_idx; out_free: kvfree(report); -- 2.17.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-06-25 12:22 UTC|newest] Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-25 12:21 [PATCH 0/6] ZNS: Extra features for current patches Javier González 2020-06-25 12:21 ` Javier González 2020-06-25 12:21 ` [PATCH 1/6] block: introduce IOCTL for zone mgmt Javier González 2020-06-25 12:21 ` Javier González 2020-06-26 1:17 ` Damien Le Moal 2020-06-26 1:17 ` Damien Le Moal 2020-06-26 6:01 ` Javier González 2020-06-26 6:01 ` Javier González 2020-06-26 6:37 ` Damien Le Moal 2020-06-26 6:37 ` Damien Le Moal 2020-06-26 6:51 ` Javier González 2020-06-26 6:51 ` Javier González 2020-06-26 7:03 ` Damien Le Moal 2020-06-26 7:03 ` Damien Le Moal 2020-06-26 7:08 ` Javier González 2020-06-26 7:08 ` Javier González 2020-06-25 12:21 ` [PATCH 2/6] block: add support for selecting all zones Javier González 2020-06-25 12:21 ` Javier González 2020-06-26 1:27 ` Damien Le Moal 2020-06-26 1:27 ` Damien Le Moal 2020-06-26 5:58 ` Javier González 2020-06-26 5:58 ` Javier González 2020-06-26 6:35 ` Damien Le Moal 2020-06-26 6:35 ` Damien Le Moal 2020-06-26 6:52 ` Javier González 2020-06-26 6:52 ` Javier González 2020-06-26 7:06 ` Damien Le Moal 2020-06-26 7:06 ` Damien Le Moal 2020-06-25 12:21 ` [PATCH 3/6] block: add support for zone offline transition Javier González 2020-06-25 12:21 ` Javier González 2020-06-25 14:12 ` Matias Bjørling 2020-06-25 14:12 ` Matias Bjørling 2020-06-25 19:48 ` Javier González 2020-06-25 19:48 ` Javier González 2020-06-26 1:14 ` Damien Le Moal 2020-06-26 1:14 ` Damien Le Moal 2020-06-26 6:18 ` Javier González 2020-06-26 6:18 ` Javier González 2020-06-26 9:11 ` hch 2020-06-26 9:11 ` hch 2020-06-26 9:15 ` Damien Le Moal 2020-06-26 9:15 ` Damien Le Moal 2020-06-26 9:17 ` hch 2020-06-26 9:17 ` hch 2020-06-26 10:02 ` Javier González 2020-06-26 10:02 ` Javier González 2020-06-26 9:07 ` Christoph Hellwig 2020-06-26 9:07 ` Christoph Hellwig 2020-06-26 1:34 ` Damien Le Moal 2020-06-26 1:34 ` Damien Le Moal 2020-06-26 6:08 ` Javier González 2020-06-26 6:08 ` Javier González 2020-06-26 6:42 ` Damien Le Moal 2020-06-26 6:42 ` Damien Le Moal 2020-06-26 6:58 ` Javier González 2020-06-26 6:58 ` Javier González 2020-06-26 7:17 ` Damien Le Moal 2020-06-26 7:17 ` Damien Le Moal 2020-06-26 7:26 ` Javier González 2020-06-26 7:26 ` Javier González 2020-06-25 12:21 ` [PATCH 4/6] block: introduce IOCTL to report dev properties Javier González 2020-06-25 12:21 ` Javier González 2020-06-25 13:10 ` Matias Bjørling 2020-06-25 13:10 ` Matias Bjørling 2020-06-25 19:42 ` Javier González 2020-06-25 19:42 ` Javier González 2020-06-25 19:58 ` Matias Bjørling 2020-06-25 19:58 ` Matias Bjørling 2020-06-26 6:24 ` Javier González 2020-06-26 6:24 ` Javier González 2020-06-25 20:25 ` Keith Busch 2020-06-25 20:25 ` Keith Busch 2020-06-26 6:28 ` Javier González 2020-06-26 6:28 ` Javier González 2020-06-26 15:52 ` Keith Busch 2020-06-26 15:52 ` Keith Busch 2020-06-26 16:25 ` Javier González 2020-06-26 16:25 ` Javier González 2020-06-26 0:57 ` Damien Le Moal 2020-06-26 0:57 ` Damien Le Moal 2020-06-26 6:27 ` Javier González 2020-06-26 6:27 ` Javier González 2020-06-26 1:38 ` Damien Le Moal 2020-06-26 1:38 ` Damien Le Moal 2020-06-26 6:22 ` Javier González 2020-06-26 6:22 ` Javier González 2020-06-25 12:21 ` [PATCH 5/6] block: add zone attr. to zone mgmt IOCTL struct Javier González 2020-06-25 12:21 ` Javier González 2020-06-25 15:13 ` Matias Bjørling 2020-06-25 15:13 ` Matias Bjørling 2020-06-25 19:51 ` Javier González 2020-06-25 19:51 ` Javier González 2020-06-26 1:45 ` Damien Le Moal 2020-06-26 1:45 ` Damien Le Moal 2020-06-26 6:03 ` Javier González 2020-06-26 6:03 ` Javier González 2020-06-26 6:38 ` Damien Le Moal 2020-06-26 6:38 ` Damien Le Moal 2020-06-26 6:49 ` Javier González 2020-06-26 6:49 ` Javier González 2020-06-26 9:14 ` Christoph Hellwig 2020-06-26 9:14 ` Christoph Hellwig 2020-06-26 10:01 ` Javier González 2020-06-26 10:01 ` Javier González 2020-06-25 12:21 ` Javier González [this message] 2020-06-25 12:21 ` [PATCH 6/6] nvme: Add consistency check for zone count Javier González 2020-06-25 13:16 ` Matias Bjørling 2020-06-25 13:16 ` Matias Bjørling 2020-06-25 19:45 ` Javier González 2020-06-25 19:45 ` Javier González 2020-06-25 21:49 ` Keith Busch 2020-06-25 21:49 ` Keith Busch 2020-06-26 0:04 ` Damien Le Moal 2020-06-26 0:04 ` Damien Le Moal 2020-06-26 6:13 ` Javier González 2020-06-26 6:13 ` Javier González 2020-06-26 6:49 ` Damien Le Moal 2020-06-26 6:49 ` Damien Le Moal 2020-06-26 6:55 ` Javier González 2020-06-26 6:55 ` Javier González 2020-06-26 7:09 ` Damien Le Moal 2020-06-26 7:09 ` Damien Le Moal 2020-06-26 7:29 ` Javier González 2020-06-26 7:29 ` Javier González 2020-06-26 7:42 ` Damien Le Moal 2020-06-26 7:42 ` Damien Le Moal 2020-06-26 9:16 ` Christoph Hellwig 2020-06-26 9:16 ` Christoph Hellwig 2020-06-26 10:03 ` Javier González 2020-06-26 10:03 ` Javier González 2020-06-25 13:04 ` [PATCH 0/6] ZNS: Extra features for current patches Matias Bjørling 2020-06-25 13:04 ` Matias Bjørling 2020-06-25 14:48 ` Matias Bjørling 2020-06-25 14:48 ` Matias Bjørling 2020-06-25 19:39 ` Javier González 2020-06-25 19:39 ` Javier González 2020-06-25 19:53 ` Matias Bjørling 2020-06-25 19:53 ` Matias Bjørling 2020-06-26 6:26 ` Javier González 2020-06-26 6:26 ` Javier González
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200625122152.17359-7-javier@javigon.com \ --to=javier@javigon.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=javier.gonz@samsung.com \ --cc=joshi.k@samsung.com \ --cc=kbusch@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=nj.shetty@samsung.com \ --cc=sagi@grimberg.me \ --cc=selvakuma.s1@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.