From: Mark Brown <broonie@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: ulf.hansson@linaro.org, lgirdwood@gmail.com,
geert+renesas@glider.be, magnus.damm@gmail.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume
Date: Fri, 26 Jun 2020 15:39:15 +0100 [thread overview]
Message-ID: <20200626143914.GE5289@sirena.org.uk> (raw)
In-Reply-To: <1593163942-5087-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On Fri, Jun 26, 2020 at 06:32:20PM +0900, Yoshihiro Shimoda wrote:
> +static int reg_is_enabled(struct regulator_dev *rdev)
> +{
> + struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
> +
> + return !priv->disabled_in_suspend;
> +}
This is broken, the state of the regualtor during system runtime need
have no connection with the state of the regulator during system
suspend.
> +static int reg_prepare_disable(struct regulator_dev *rdev)
> +{
> + struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
> +
> + priv->disabled_in_suspend = true;
> +
> + return 0;
> +}
According to the changelog this is all about reflecting changes in the
system state done by firmware but there's no interaction with firmware
here which means this will be at best fragile. If we need to reflect
changes in firmware configuration I'd expect there to be some
interaction with firmware about how it is configured, or at least that
the configuration would come from the same source.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-26 14:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 9:32 [PATCH/RFC v4 0/4] treewide: add regulator condition on _mmc_suspend() Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 1/4] regulator: core: add prepare and resume_early Yoshihiro Shimoda
2020-06-26 13:51 ` kernel test robot
2020-06-26 14:30 ` Mark Brown
2020-06-29 2:12 ` Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume Yoshihiro Shimoda
2020-06-26 14:39 ` Mark Brown [this message]
2020-06-29 2:42 ` Yoshihiro Shimoda
2020-06-29 12:57 ` Mark Brown
2020-06-29 13:40 ` Sudeep Holla
2020-06-29 14:15 ` Geert Uytterhoeven
2020-06-29 15:07 ` Sudeep Holla
2020-06-29 16:14 ` Mark Brown
2020-06-29 16:42 ` Sudeep Holla
2020-06-29 17:26 ` Mark Brown
2020-06-29 17:42 ` Sudeep Holla
2020-06-30 8:29 ` Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled Yoshihiro Shimoda
2020-06-26 15:13 ` Mark Brown
2020-06-29 2:49 ` Yoshihiro Shimoda
2020-06-26 15:53 ` Sergei Shtylyov
2020-06-29 5:16 ` Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 4/4] arm64: dts: renesas: add regulator-off-in-suspend property for eMMC Yoshihiro Shimoda
2020-06-26 10:13 ` [PATCH/RFC v4 0/4] treewide: add regulator condition on _mmc_suspend() Geert Uytterhoeven
2020-06-29 10:04 ` Yoshihiro Shimoda
2020-06-29 11:49 ` Geert Uytterhoeven
2020-06-30 13:19 ` Geert Uytterhoeven
2020-07-03 11:10 ` Yoshihiro Shimoda
2020-07-06 11:14 ` Geert Uytterhoeven
2020-08-11 13:50 ` E1000 s2idle crash (was: Re: [PATCH/RFC v4 0/4] treewide: add regulator condition on _mmc_suspend()) Geert Uytterhoeven
2020-08-17 12:00 ` Yoshihiro Shimoda
2020-08-27 9:15 ` Geert Uytterhoeven
2020-08-27 9:16 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626143914.GE5289@sirena.org.uk \
--to=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.