All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Hari Bathini <hbathini@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Pingfan Liu <piliu@redhat.com>,
	Kexec-ml <kexec@lists.infradead.org>,
	Mimi Zohar <zohar@linux.ibm.com>, Petr Tesarik <ptesarik@suse.cz>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions
Date: Sat, 27 Jun 2020 18:45:39 +0800	[thread overview]
Message-ID: <202006271822.I4qp1F7k%lkp@intel.com> (raw)
In-Reply-To: <159319831192.16351.17443438699302756548.stgit@hbathini.in.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Hi Hari,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on linux/master linus/master v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hari-Bathini/ppc64-enable-kdump-support-for-kexec_file_load-syscall/20200627-030901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/kexec/file_load_64.c:390:5: warning: no previous prototype for 'arch_kimage_file_post_load_cleanup' [-Wmissing-prototypes]
     390 | int arch_kimage_file_post_load_cleanup(struct kimage *image)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/arch_kimage_file_post_load_cleanup +390 arch/powerpc/kexec/file_load_64.c

   382	
   383	/**
   384	 * arch_kimage_file_post_load_cleanup - Frees up all the allocations done
   385	 *                                      while loading the image.
   386	 * @image:                              kexec image being loaded.
   387	 *
   388	 * Returns 0 on success, negative errno on error.
   389	 */
 > 390	int arch_kimage_file_post_load_cleanup(struct kimage *image)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69557 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Hari Bathini <hbathini@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org, Pingfan Liu <piliu@redhat.com>,
	Petr Tesarik <ptesarik@suse.cz>,
	Kexec-ml <kexec@lists.infradead.org>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Sourabh Jain <sourabhjain@linux.ibm.com>
Subject: Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions
Date: Sat, 27 Jun 2020 18:45:39 +0800	[thread overview]
Message-ID: <202006271822.I4qp1F7k%lkp@intel.com> (raw)
In-Reply-To: <159319831192.16351.17443438699302756548.stgit@hbathini.in.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Hi Hari,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on linux/master linus/master v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hari-Bathini/ppc64-enable-kdump-support-for-kexec_file_load-syscall/20200627-030901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/kexec/file_load_64.c:390:5: warning: no previous prototype for 'arch_kimage_file_post_load_cleanup' [-Wmissing-prototypes]
     390 | int arch_kimage_file_post_load_cleanup(struct kimage *image)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/arch_kimage_file_post_load_cleanup +390 arch/powerpc/kexec/file_load_64.c

   382	
   383	/**
   384	 * arch_kimage_file_post_load_cleanup - Frees up all the allocations done
   385	 *                                      while loading the image.
   386	 * @image:                              kexec image being loaded.
   387	 *
   388	 * Returns 0 on success, negative errno on error.
   389	 */
 > 390	int arch_kimage_file_post_load_cleanup(struct kimage *image)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69557 bytes --]

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions
Date: Sat, 27 Jun 2020 18:45:39 +0800	[thread overview]
Message-ID: <202006271822.I4qp1F7k%lkp@intel.com> (raw)
In-Reply-To: <159319831192.16351.17443438699302756548.stgit@hbathini.in.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

Hi Hari,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on linux/master linus/master v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hari-Bathini/ppc64-enable-kdump-support-for-kexec_file_load-syscall/20200627-030901
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/kexec/file_load_64.c:390:5: warning: no previous prototype for 'arch_kimage_file_post_load_cleanup' [-Wmissing-prototypes]
     390 | int arch_kimage_file_post_load_cleanup(struct kimage *image)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/arch_kimage_file_post_load_cleanup +390 arch/powerpc/kexec/file_load_64.c

   382	
   383	/**
   384	 * arch_kimage_file_post_load_cleanup - Frees up all the allocations done
   385	 *                                      while loading the image.
   386	 * @image:                              kexec image being loaded.
   387	 *
   388	 * Returns 0 on success, negative errno on error.
   389	 */
 > 390	int arch_kimage_file_post_load_cleanup(struct kimage *image)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 69557 bytes --]

  reply	other threads:[~2020-06-27 11:40 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 19:04 [PATCH 00/11] ppc64: enable kdump support for kexec_file_load syscall Hari Bathini
2020-06-26 19:04 ` Hari Bathini
2020-06-26 19:04 ` Hari Bathini
2020-06-26 19:04 ` [PATCH 01/11] kexec_file: allow archs to handle special regions while locating memory hole Hari Bathini
2020-06-26 19:04   ` Hari Bathini
2020-06-26 19:04   ` Hari Bathini
2020-06-27  6:30   ` Christophe Leroy
2020-06-27  6:30     ` Christophe Leroy
2020-06-27  6:30     ` Christophe Leroy
2020-06-28  2:28   ` piliu
2020-06-28  2:28     ` piliu
2020-06-28  2:28     ` piliu
2020-06-29  6:00     ` Hari Bathini
2020-06-29  6:00       ` Hari Bathini
2020-06-29  6:00       ` Hari Bathini
2020-06-29 11:39   ` Petr Tesarik
2020-06-29 11:39     ` Petr Tesarik
2020-06-29 11:39     ` Petr Tesarik
2020-06-29 11:56     ` Hari Bathini
2020-06-29 11:56       ` Hari Bathini
2020-06-29 11:56       ` Hari Bathini
2020-07-01  7:46       ` Dave Young
2020-07-01  7:46         ` Dave Young
2020-07-01  7:46         ` Dave Young
2020-07-01 18:31         ` Hari Bathini
2020-07-01 18:31           ` Hari Bathini
2020-07-01 18:31           ` Hari Bathini
2020-07-02 11:47           ` Dave Young
2020-07-02 11:47             ` Dave Young
2020-07-02 11:47             ` Dave Young
2020-06-26 19:04 ` [PATCH 02/11] powerpc/kexec_file: mark PPC64 specific code Hari Bathini
2020-06-26 19:04   ` Hari Bathini
2020-06-26 19:04   ` Hari Bathini
2020-06-27  6:42   ` Christophe Leroy
2020-06-27  6:42     ` Christophe Leroy
2020-06-27  6:42     ` Christophe Leroy
2020-06-29  6:23     ` Hari Bathini
2020-06-29  6:23       ` Hari Bathini
2020-06-29  6:23       ` Hari Bathini
2020-06-26 19:05 ` [PATCH 03/11] powerpc/kexec_file: add helper functions for getting memory ranges Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05 ` [PATCH 04/11] ppc64/kexec_file: avoid stomping memory used by special regions Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-27 10:45   ` kernel test robot [this message]
2020-06-27 10:45     ` kernel test robot
2020-06-27 10:45     ` kernel test robot
2020-06-28  2:14   ` piliu
2020-06-28  2:14     ` piliu
2020-06-28  2:14     ` piliu
2020-06-29  5:55     ` Hari Bathini
2020-06-29  5:55       ` Hari Bathini
2020-06-29  5:55       ` Hari Bathini
2020-06-30  3:30       ` piliu
2020-06-30  3:30         ` piliu
2020-06-30  3:30         ` piliu
2020-06-30  6:10         ` Hari Bathini
2020-06-30  6:10           ` Hari Bathini
2020-06-30  6:10           ` Hari Bathini
2020-06-30  8:13           ` piliu
2020-06-30  8:13             ` piliu
2020-06-30  8:13             ` piliu
2020-07-01  7:40   ` Dave Young
2020-07-01  7:40     ` Dave Young
2020-07-01  7:40     ` Dave Young
2020-07-01 12:53     ` piliu
2020-07-01 12:53       ` piliu
2020-07-01 12:53       ` piliu
2020-07-02 11:59       ` Dave Young
2020-07-02 11:59         ` Dave Young
2020-07-02 11:59         ` Dave Young
2020-07-01 18:18     ` Hari Bathini
2020-07-01 18:18       ` Hari Bathini
2020-07-01 18:18       ` Hari Bathini
2020-07-02 11:54       ` Dave Young
2020-07-02 11:54         ` Dave Young
2020-07-02 11:54         ` Dave Young
2020-06-26 19:05 ` [PATCH 05/11] powerpc/drmem: make lmb walk a bit more flexible Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05 ` [PATCH 06/11] ppc64/kexec_file: restrict memory usage of kdump kernel Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05 ` [PATCH 07/11] ppc64/kexec_file: add support to relocate purgatory Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-27 11:52   ` kernel test robot
2020-06-27 11:52     ` kernel test robot
2020-06-27 11:52     ` kernel test robot
2020-06-26 19:05 ` [PATCH 08/11] ppc64/kexec_file: setup the stack for purgatory Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05 ` [PATCH 09/11] ppc64/kexec_file: setup backup region for kdump kernel Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-26 19:05   ` Hari Bathini
2020-06-27 13:02   ` kernel test robot
2020-06-27 13:02     ` kernel test robot
2020-06-27 13:02     ` kernel test robot
2020-06-26 19:06 ` [PATCH 10/11] ppc64/kexec_file: prepare elfcore header for crashing kernel Hari Bathini
2020-06-26 19:06   ` Hari Bathini
2020-06-26 19:06   ` Hari Bathini
2020-06-26 19:06 ` [PATCH 11/11] ppc64/kexec_file: add appropriate regions for memory reserve map Hari Bathini
2020-06-26 19:06   ` Hari Bathini
2020-06-26 19:06   ` Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006271822.I4qp1F7k%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hbathini@linux.ibm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mahesh@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=piliu@redhat.com \
    --cc=ptesarik@suse.cz \
    --cc=sourabhjain@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.