* [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
@ 2020-06-29 20:50 Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Jared Bents @ 2020-06-29 20:50 UTC (permalink / raw)
To: buildroot
update to add qemu spice support
Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
---
package/qemu/Config.in | 9 +++++++++
package/qemu/qemu.mk | 8 +++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/package/qemu/Config.in b/package/qemu/Config.in
index 33d4cccd7b..3de73b69ec 100644
--- a/package/qemu/Config.in
+++ b/package/qemu/Config.in
@@ -127,6 +127,15 @@ config BR2_PACKAGE_QEMU_SDL
comment "SDL frontend needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
+config BR2_PACKAGE_QEMU_SPICE
+ bool "Enable Spice frontend"
+ depends on BR2_PACKAGE_SPICE
+ help
+ Say 'y' here to have QEMU support Spice as a (VNC-like) frontend.
+
+comment "Spice support requires spice-server"
+ depends on !BR2_PACKAGE_SPICE
+
comment "Misc. features"
config BR2_PACKAGE_QEMU_FDT
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index cb138fd488..0b76e432e0 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -112,6 +112,13 @@ else
QEMU_OPTS += --disable-numa
endif
+ifeq ($(BR2_PACKAGE_QEMU_SPICE),y)
+QEMU_OPTS += --enable-spice
+QEMU_DEPENDENCIES += spice
+else
+QEMU_OPTS += --disable-spice
+endif
+
# Override CPP, as it expects to be able to call it like it'd
# call the compiler.
define QEMU_CONFIGURE_CMDS
@@ -143,7 +150,6 @@ define QEMU_CONFIGURE_CMDS
--disable-linux-io-uring \
--disable-cap-ng \
--disable-docs \
- --disable-spice \
--disable-rbd \
--disable-libiscsi \
--disable-usb-redir \
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
@ 2020-06-29 20:50 ` Jared Bents
2020-07-07 12:56 ` Romain Naour
2020-06-29 20:50 ` [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support Jared Bents
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Jared Bents @ 2020-06-29 20:50 UTC (permalink / raw)
To: buildroot
update to add vnc support to qemu if libvncserver is
selected
Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
---
package/qemu/qemu.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 0b76e432e0..520547e94e 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -98,6 +98,13 @@ else
QEMU_OPTS += --disable-libusb
endif
+ifeq ($(BR2_PACKAGE_LIBVNCSERVER),y)
+QEMU_OPTS += --enable-vnc
+QEMU_DEPENDENCIES += libvncserver
+else
+QEMU_OPTS += --disable-vnc
+endif
+
ifeq ($(BR2_PACKAGE_NETTLE),y)
QEMU_OPTS += --enable-nettle
QEMU_DEPENDENCIES += nettle
@@ -140,7 +147,6 @@ define QEMU_CONFIGURE_CMDS
--disable-bsd-user \
--disable-containers \
--disable-xen \
- --disable-vnc \
--disable-virtfs \
--disable-brlapi \
--disable-curses \
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
@ 2020-07-07 12:56 ` Romain Naour
0 siblings, 0 replies; 9+ messages in thread
From: Romain Naour @ 2020-07-07 12:56 UTC (permalink / raw)
To: buildroot
Hi Jared,
Le 29/06/2020 ? 22:50, Jared Bents a ?crit?:
> update to add vnc support to qemu if libvncserver is
> selected
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
> package/qemu/qemu.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 0b76e432e0..520547e94e 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -98,6 +98,13 @@ else
> QEMU_OPTS += --disable-libusb
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBVNCSERVER),y)
> +QEMU_OPTS += --enable-vnc
> +QEMU_DEPENDENCIES += libvncserver
> +else
> +QEMU_OPTS += --disable-vnc
> +endif
When vnc support is enabled, vnc suboption will try to detect automatically some
dependencies (like libpng see [1][2]).
vnc-sasl SASL encryption for VNC server
vnc-jpeg JPEG lossy compression for VNC server
vnc-png PNG compression for VNC server
Either disable them explicitly or handle the optional dependencies.
[1]
https://git.buildroot.net/buildroot/commit/?id=ece36b9a46583315fe0d607099e16949ed6c2b0b
[2]
https://git.qemu.org/?p=qemu.git;a=blob;f=configure;h=23b5e93752b6a2597b2099b502184bc5fc352bf1;hb=fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6#l1818
Best regards,
Romain
> +
> ifeq ($(BR2_PACKAGE_NETTLE),y)
> QEMU_OPTS += --enable-nettle
> QEMU_DEPENDENCIES += nettle
> @@ -140,7 +147,6 @@ define QEMU_CONFIGURE_CMDS
> --disable-bsd-user \
> --disable-containers \
> --disable-xen \
> - --disable-vnc \
> --disable-virtfs \
> --disable-brlapi \
> --disable-curses \
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
@ 2020-06-29 20:50 ` Jared Bents
2020-07-07 13:37 ` Romain Naour
2020-06-29 20:59 ` [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Thomas Petazzoni
2020-07-13 21:31 ` Thomas Petazzoni
3 siblings, 1 reply; 9+ messages in thread
From: Jared Bents @ 2020-06-29 20:50 UTC (permalink / raw)
To: buildroot
update to add usb-redir support to qemu if usbredir is enabled
Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
---
package/qemu/qemu.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 520547e94e..3ed5565221 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -126,6 +126,13 @@ else
QEMU_OPTS += --disable-spice
endif
+ifeq ($(BR2_PACKAGE_USBREDIR),y)
+QEMU_OPTS += --enable-usb-redir
+QEMU_DEPENDENCIES += usbredir
+else
+QEMU_OPTS += --disable-usb-redir
+endif
+
# Override CPP, as it expects to be able to call it like it'd
# call the compiler.
define QEMU_CONFIGURE_CMDS
@@ -158,7 +165,6 @@ define QEMU_CONFIGURE_CMDS
--disable-docs \
--disable-rbd \
--disable-libiscsi \
- --disable-usb-redir \
--disable-strip \
--disable-sparse \
--disable-mpath \
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support
2020-06-29 20:50 ` [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support Jared Bents
@ 2020-07-07 13:37 ` Romain Naour
0 siblings, 0 replies; 9+ messages in thread
From: Romain Naour @ 2020-07-07 13:37 UTC (permalink / raw)
To: buildroot
Le 29/06/2020 ? 22:50, Jared Bents a ?crit?:
> update to add usb-redir support to qemu if usbredir is enabled
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
> ---
> package/qemu/qemu.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 520547e94e..3ed5565221 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -126,6 +126,13 @@ else
> QEMU_OPTS += --disable-spice
> endif
>
> +ifeq ($(BR2_PACKAGE_USBREDIR),y)
> +QEMU_OPTS += --enable-usb-redir
> +QEMU_DEPENDENCIES += usbredir
> +else
> +QEMU_OPTS += --disable-usb-redir
> +endif
> +
> # Override CPP, as it expects to be able to call it like it'd
> # call the compiler.
> define QEMU_CONFIGURE_CMDS
> @@ -158,7 +165,6 @@ define QEMU_CONFIGURE_CMDS
> --disable-docs \
> --disable-rbd \
> --disable-libiscsi \
> - --disable-usb-redir \
> --disable-strip \
> --disable-sparse \
> --disable-mpath \
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support Jared Bents
@ 2020-06-29 20:59 ` Thomas Petazzoni
2020-06-29 21:05 ` Jared Bents
2020-07-13 21:31 ` Thomas Petazzoni
3 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2020-06-29 20:59 UTC (permalink / raw)
To: buildroot
On Mon, 29 Jun 2020 15:50:00 -0500
Jared Bents <jared.bents@rockwellcollins.com> wrote:
> update to add qemu spice support
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
> package/qemu/Config.in | 9 +++++++++
> package/qemu/qemu.mk | 8 +++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index 33d4cccd7b..3de73b69ec 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -127,6 +127,15 @@ config BR2_PACKAGE_QEMU_SDL
> comment "SDL frontend needs a toolchain w/ dynamic library"
> depends on BR2_STATIC_LIBS
>
> +config BR2_PACKAGE_QEMU_SPICE
> + bool "Enable Spice frontend"
> + depends on BR2_PACKAGE_SPICE
I am wondering why for this one we are adding a sub-option and not
using automatic detection of BR2_PACKAGE_SPICE=y in the .mk file, like
you've done for VNC and usb-redir.
On the other hand, we do have already a bunch of sub-options to
configure Qemu. We're not very consistent here :/
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
2020-06-29 20:59 ` [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Thomas Petazzoni
@ 2020-06-29 21:05 ` Jared Bents
2020-07-07 13:30 ` Romain Naour
0 siblings, 1 reply; 9+ messages in thread
From: Jared Bents @ 2020-06-29 21:05 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, Jun 29, 2020 at 3:59 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 29 Jun 2020 15:50:00 -0500
> Jared Bents <jared.bents@rockwellcollins.com> wrote:
>
> > update to add qemu spice support
> >
> > Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> > ---
> > package/qemu/Config.in | 9 +++++++++
> > package/qemu/qemu.mk | 8 +++++++-
> > 2 files changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> > index 33d4cccd7b..3de73b69ec 100644
> > --- a/package/qemu/Config.in
> > +++ b/package/qemu/Config.in
> > @@ -127,6 +127,15 @@ config BR2_PACKAGE_QEMU_SDL
> > comment "SDL frontend needs a toolchain w/ dynamic library"
> > depends on BR2_STATIC_LIBS
> >
> > +config BR2_PACKAGE_QEMU_SPICE
> > + bool "Enable Spice frontend"
> > + depends on BR2_PACKAGE_SPICE
>
> I am wondering why for this one we are adding a sub-option and not
> using automatic detection of BR2_PACKAGE_SPICE=y in the .mk file, like
> you've done for VNC and usb-redir.
>
> On the other hand, we do have already a bunch of sub-options to
> configure Qemu. We're not very consistent here :/
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
I based the handling of the --enable-spice option off of an old
upstream attempt from Yann that I had found at
http://lists.buildroot.org/pipermail/buildroot/2012-December/063058.html
. I don't have a preference either way so let me know if you'd prefer
a suboption or have it automatically enabled if BR2_PACKAGE_SPICE is
enabled similarly to the other options I've added.
Thank you,
Jared
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
2020-06-29 21:05 ` Jared Bents
@ 2020-07-07 13:30 ` Romain Naour
0 siblings, 0 replies; 9+ messages in thread
From: Romain Naour @ 2020-07-07 13:30 UTC (permalink / raw)
To: buildroot
Hi Jared, Thomas,
Le 29/06/2020 ? 23:05, Jared Bents a ?crit?:
> Hi Thomas,
>
>
> On Mon, Jun 29, 2020 at 3:59 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
>>
>> On Mon, 29 Jun 2020 15:50:00 -0500
>> Jared Bents <jared.bents@rockwellcollins.com> wrote:
>>
>>> update to add qemu spice support
>>>
>>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>>> ---
>>> package/qemu/Config.in | 9 +++++++++
>>> package/qemu/qemu.mk | 8 +++++++-
>>> 2 files changed, 16 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
>>> index 33d4cccd7b..3de73b69ec 100644
>>> --- a/package/qemu/Config.in
>>> +++ b/package/qemu/Config.in
>>> @@ -127,6 +127,15 @@ config BR2_PACKAGE_QEMU_SDL
>>> comment "SDL frontend needs a toolchain w/ dynamic library"
>>> depends on BR2_STATIC_LIBS
>>>
>>> +config BR2_PACKAGE_QEMU_SPICE
>>> + bool "Enable Spice frontend"
>>> + depends on BR2_PACKAGE_SPICE
>>
>> I am wondering why for this one we are adding a sub-option and not
>> using automatic detection of BR2_PACKAGE_SPICE=y in the .mk file, like
>> you've done for VNC and usb-redir.
>>
>> On the other hand, we do have already a bunch of sub-options to
>> configure Qemu. We're not very consistent here :/
How to enable systems emulation or user-land emulation without sub-options?
What about removing BR2_PACKAGE_QEMU_SDL and BR2_PACKAGE_QEMU_FDT options and
handle the dependencies automatically?
>>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
>
> I based the handling of the --enable-spice option off of an old
> upstream attempt from Yann that I had found at
> http://lists.buildroot.org/pipermail/buildroot/2012-December/063058.html
> . I don't have a preference either way so let me know if you'd prefer
> a suboption or have it automatically enabled if BR2_PACKAGE_SPICE is
> enabled similarly to the other options I've added.
I guess we should enable spice only when spice package is enabled by the user
(automatic detection).
Best regards,
Romain
>
> Thank you,
> Jared
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/qemu: add spice support
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
` (2 preceding siblings ...)
2020-06-29 20:59 ` [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Thomas Petazzoni
@ 2020-07-13 21:31 ` Thomas Petazzoni
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2020-07-13 21:31 UTC (permalink / raw)
To: buildroot
On Mon, 29 Jun 2020 15:50:00 -0500
Jared Bents <jared.bents@rockwellcollins.com> wrote:
> update to add qemu spice support
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> ---
> package/qemu/Config.in | 9 +++++++++
> package/qemu/qemu.mk | 8 +++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
As discussed, I've dropped the sub-option, and simply made it an
implicit optional dependency. And applied, of course!
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-13 21:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 20:50 [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Jared Bents
2020-06-29 20:50 ` [Buildroot] [PATCH v1 2/3] package/qemu: add vnc support Jared Bents
2020-07-07 12:56 ` Romain Naour
2020-06-29 20:50 ` [Buildroot] [PATCH v1 3/3] package/qemu: add usb-redir support Jared Bents
2020-07-07 13:37 ` Romain Naour
2020-06-29 20:59 ` [Buildroot] [PATCH v1 1/3] package/qemu: add spice support Thomas Petazzoni
2020-06-29 21:05 ` Jared Bents
2020-07-07 13:30 ` Romain Naour
2020-07-13 21:31 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.