* [PATCH] iio: adis16480: Use irq types instead of flags
@ 2020-07-01 12:07 Nuno Sá
2020-07-04 16:43 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Nuno Sá @ 2020-07-01 12:07 UTC (permalink / raw)
To: linux-iio
Cc: Lars-Peter Clausen, Peter Meerwald-Stadler, Hartmut Knaack,
Jonathan Cameron, Michael Hennerich
The value retrieved by `irqd_get_trigger_type()` is not an irq flag.
While the values are the same, the meaning is different.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/iio/imu/adis16480.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
index 5163749f568e..1eb4f98076f1 100644
--- a/drivers/iio/imu/adis16480.c
+++ b/drivers/iio/imu/adis16480.c
@@ -1102,12 +1102,12 @@ static int adis16480_config_irq_pin(struct device_node *of_node,
/*
* Get the interrupt line behaviour. The data ready polarity can be
* configured as positive or negative, corresponding to
- * IRQF_TRIGGER_RISING or IRQF_TRIGGER_FALLING respectively.
+ * IRQ_TYPE_EDGE_RISING or IRQ_TYPE_EDGE_FALLING respectively.
*/
irq_type = irqd_get_trigger_type(desc);
- if (irq_type == IRQF_TRIGGER_RISING) { /* Default */
+ if (irq_type == IRQ_TYPE_EDGE_RISING) { /* Default */
val |= ADIS16480_DRDY_POL(1);
- } else if (irq_type == IRQF_TRIGGER_FALLING) {
+ } else if (irq_type == IRQ_TYPE_EDGE_FALLING) {
val |= ADIS16480_DRDY_POL(0);
} else {
dev_err(&st->adis.spi->dev,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adis16480: Use irq types instead of flags
2020-07-01 12:07 [PATCH] iio: adis16480: Use irq types instead of flags Nuno Sá
@ 2020-07-04 16:43 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-07-04 16:43 UTC (permalink / raw)
To: Nuno Sá
Cc: linux-iio, Lars-Peter Clausen, Peter Meerwald-Stadler,
Hartmut Knaack, Michael Hennerich
On Wed, 1 Jul 2020 14:07:02 +0200
Nuno Sá <nuno.sa@analog.com> wrote:
> The value retrieved by `irqd_get_trigger_type()` is not an irq flag.
> While the values are the same, the meaning is different.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to poke at it.
Thanks,
Jonathan
> ---
> drivers/iio/imu/adis16480.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index 5163749f568e..1eb4f98076f1 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -1102,12 +1102,12 @@ static int adis16480_config_irq_pin(struct device_node *of_node,
> /*
> * Get the interrupt line behaviour. The data ready polarity can be
> * configured as positive or negative, corresponding to
> - * IRQF_TRIGGER_RISING or IRQF_TRIGGER_FALLING respectively.
> + * IRQ_TYPE_EDGE_RISING or IRQ_TYPE_EDGE_FALLING respectively.
> */
> irq_type = irqd_get_trigger_type(desc);
> - if (irq_type == IRQF_TRIGGER_RISING) { /* Default */
> + if (irq_type == IRQ_TYPE_EDGE_RISING) { /* Default */
> val |= ADIS16480_DRDY_POL(1);
> - } else if (irq_type == IRQF_TRIGGER_FALLING) {
> + } else if (irq_type == IRQ_TYPE_EDGE_FALLING) {
> val |= ADIS16480_DRDY_POL(0);
> } else {
> dev_err(&st->adis.spi->dev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-04 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 12:07 [PATCH] iio: adis16480: Use irq types instead of flags Nuno Sá
2020-07-04 16:43 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.