All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	"moderated list:ARM/Microchip (AT91) SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] ASoC: atmel: fix kernel-doc
Date: Thu, 2 Jul 2020 20:27:47 +0200	[thread overview]
Message-ID: <20200702182747.GB6538@piout.net> (raw)
In-Reply-To: <20200702165901.164100-2-pierre-louis.bossart@linux.intel.com>

On 02/07/2020 11:58:54-0500, Pierre-Louis Bossart wrote:
> Fix W=1 warning
> 
> Kernel-doc is not used in one file and missing argument in the second.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  sound/soc/atmel/atmel-pcm-dma.c | 2 +-
>  sound/soc/atmel/atmel_ssc_dai.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c
> index cb03c4f7324c..0a2e956232af 100644
> --- a/sound/soc/atmel/atmel-pcm-dma.c
> +++ b/sound/soc/atmel/atmel-pcm-dma.c
> @@ -44,7 +44,7 @@ static const struct snd_pcm_hardware atmel_pcm_dma_hardware = {
>  	.buffer_bytes_max	= 512 * 1024,
>  };
>  
> -/**
> +/*
>   * atmel_pcm_dma_irq: SSC interrupt handler for DMAENGINE enabled SSC
>   *
>   * We use DMAENGINE to send/receive data to/from SSC so this ISR is only to
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 0f18dfb85bfe..6a63e8797a0b 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -887,6 +887,7 @@ static int asoc_ssc_init(struct device *dev)
>  
>  /**
>   * atmel_ssc_set_audio - Allocate the specified SSC for audio use.
> + * @ssc_id: SSD ID in [0, NUM_SSC_DEVICES[
>   */
>  int atmel_ssc_set_audio(int ssc_id)
>  {
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	broonie@kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	"moderated list:ARM/Microchip \(AT91\) SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH 1/8] ASoC: atmel: fix kernel-doc
Date: Thu, 2 Jul 2020 20:27:47 +0200	[thread overview]
Message-ID: <20200702182747.GB6538@piout.net> (raw)
In-Reply-To: <20200702165901.164100-2-pierre-louis.bossart@linux.intel.com>

On 02/07/2020 11:58:54-0500, Pierre-Louis Bossart wrote:
> Fix W=1 warning
> 
> Kernel-doc is not used in one file and missing argument in the second.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  sound/soc/atmel/atmel-pcm-dma.c | 2 +-
>  sound/soc/atmel/atmel_ssc_dai.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c
> index cb03c4f7324c..0a2e956232af 100644
> --- a/sound/soc/atmel/atmel-pcm-dma.c
> +++ b/sound/soc/atmel/atmel-pcm-dma.c
> @@ -44,7 +44,7 @@ static const struct snd_pcm_hardware atmel_pcm_dma_hardware = {
>  	.buffer_bytes_max	= 512 * 1024,
>  };
>  
> -/**
> +/*
>   * atmel_pcm_dma_irq: SSC interrupt handler for DMAENGINE enabled SSC
>   *
>   * We use DMAENGINE to send/receive data to/from SSC so this ISR is only to
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 0f18dfb85bfe..6a63e8797a0b 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -887,6 +887,7 @@ static int asoc_ssc_init(struct device *dev)
>  
>  /**
>   * atmel_ssc_set_audio - Allocate the specified SSC for audio use.
> + * @ssc_id: SSD ID in [0, NUM_SSC_DEVICES[
>   */
>  int atmel_ssc_set_audio(int ssc_id)
>  {
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	broonie@kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	"moderated list:ARM/Microchip \(AT91\) SoC support"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/8] ASoC: atmel: fix kernel-doc
Date: Thu, 2 Jul 2020 20:27:47 +0200	[thread overview]
Message-ID: <20200702182747.GB6538@piout.net> (raw)
In-Reply-To: <20200702165901.164100-2-pierre-louis.bossart@linux.intel.com>

On 02/07/2020 11:58:54-0500, Pierre-Louis Bossart wrote:
> Fix W=1 warning
> 
> Kernel-doc is not used in one file and missing argument in the second.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  sound/soc/atmel/atmel-pcm-dma.c | 2 +-
>  sound/soc/atmel/atmel_ssc_dai.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c
> index cb03c4f7324c..0a2e956232af 100644
> --- a/sound/soc/atmel/atmel-pcm-dma.c
> +++ b/sound/soc/atmel/atmel-pcm-dma.c
> @@ -44,7 +44,7 @@ static const struct snd_pcm_hardware atmel_pcm_dma_hardware = {
>  	.buffer_bytes_max	= 512 * 1024,
>  };
>  
> -/**
> +/*
>   * atmel_pcm_dma_irq: SSC interrupt handler for DMAENGINE enabled SSC
>   *
>   * We use DMAENGINE to send/receive data to/from SSC so this ISR is only to
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 0f18dfb85bfe..6a63e8797a0b 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -887,6 +887,7 @@ static int asoc_ssc_init(struct device *dev)
>  
>  /**
>   * atmel_ssc_set_audio - Allocate the specified SSC for audio use.
> + * @ssc_id: SSD ID in [0, NUM_SSC_DEVICES[
>   */
>  int atmel_ssc_set_audio(int ssc_id)
>  {
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-02 18:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 16:58 [PATCH 0/8] ASoC: fix W=1 warnings for various SOCs Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 1/8] ASoC: atmel: fix kernel-doc Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 18:27   ` Alexandre Belloni [this message]
2020-07-02 18:27     ` Alexandre Belloni
2020-07-02 18:27     ` Alexandre Belloni
2020-07-02 16:58 ` [PATCH 2/8] ASoC: samsung: spdif: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-03 18:07   ` Sylwester Nawrocki
2020-07-03 18:07     ` Sylwester Nawrocki
2020-07-02 16:58 ` [PATCH 3/8] ASoC: samsung: pcm: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-03 18:47   ` Sylwester Nawrocki
2020-07-03 18:47     ` Sylwester Nawrocki
2020-07-06 15:03     ` Pierre-Louis Bossart
2020-07-06 15:03       ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 4/8] ASoC: qcom: q6asm: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 5/8] ASoC: sunxi: sun4i-i2s: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 6/8] ASoC: sunxi: sun4i-spdif: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
     [not found] ` <20200702165901.164100-1-pierre-louis.bossart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-07-02 16:59   ` [PATCH 7/8] ASoC: tegra: tegra20_das: remove always-true comparison Pierre-Louis Bossart
2020-07-02 16:59     ` Pierre-Louis Bossart
2020-07-02 16:59     ` Pierre-Louis Bossart
     [not found]     ` <20200702165901.164100-8-pierre-louis.bossart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-07-06 15:16       ` Jon Hunter
2020-07-06 15:16         ` Jon Hunter
2020-07-06 15:16         ` Jon Hunter
2020-07-02 16:59 ` [PATCH 8/8] ASoC: uniphier: aio-core: fix kernel-doc Pierre-Louis Bossart
2020-07-02 16:59   ` Pierre-Louis Bossart
2020-07-02 16:59   ` Pierre-Louis Bossart
2020-07-07 10:58   ` Masahiro Yamada
2020-07-07 10:58     ` Masahiro Yamada
2020-07-07 10:58     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702182747.GB6538@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.