All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"moderated list:ARM/UNIPHIER ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/8] ASoC: uniphier: aio-core: fix kernel-doc
Date: Tue, 7 Jul 2020 19:58:10 +0900	[thread overview]
Message-ID: <CAK7LNARV9p=TF+5kPx-MBOsGnE9mafndYTEoaWRAaieqeL5a5A@mail.gmail.com> (raw)
In-Reply-To: <20200702165901.164100-9-pierre-louis.bossart@linux.intel.com>

On Fri, Jul 3, 2020 at 1:59 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> Fix W=1 warning - wrong parameter description and bad format
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


>  sound/soc/uniphier/aio-core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
> index 9bcba06ba52e..b8195778953e 100644
> --- a/sound/soc/uniphier/aio-core.c
> +++ b/sound/soc/uniphier/aio-core.c
> @@ -93,9 +93,9 @@ void aio_iecout_set_enable(struct uniphier_aio_chip *chip, bool enable)
>
>  /**
>   * aio_chip_set_pll - set frequency to audio PLL
> - * @chip  : the AIO chip pointer
> - * @source: PLL
> - * @freq  : frequency in Hz, 0 is ignored
> + * @chip: the AIO chip pointer
> + * @pll_id: PLL
> + * @freq: frequency in Hz, 0 is ignored
>   *
>   * Sets frequency of audio PLL. This function can be called anytime,
>   * but it takes time till PLL is locked.
> @@ -267,7 +267,6 @@ void aio_port_reset(struct uniphier_aio_sub *sub)
>  /**
>   * aio_port_set_ch - set channels of LPCM
>   * @sub: the AIO substream pointer, PCM substream only
> - * @ch : count of channels
>   *
>   * Set suitable slot selecting to input/output port block of AIO.
>   *
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/UNIPHIER ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 8/8] ASoC: uniphier: aio-core: fix kernel-doc
Date: Tue, 7 Jul 2020 19:58:10 +0900	[thread overview]
Message-ID: <CAK7LNARV9p=TF+5kPx-MBOsGnE9mafndYTEoaWRAaieqeL5a5A@mail.gmail.com> (raw)
In-Reply-To: <20200702165901.164100-9-pierre-louis.bossart@linux.intel.com>

On Fri, Jul 3, 2020 at 1:59 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> Fix W=1 warning - wrong parameter description and bad format
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


>  sound/soc/uniphier/aio-core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
> index 9bcba06ba52e..b8195778953e 100644
> --- a/sound/soc/uniphier/aio-core.c
> +++ b/sound/soc/uniphier/aio-core.c
> @@ -93,9 +93,9 @@ void aio_iecout_set_enable(struct uniphier_aio_chip *chip, bool enable)
>
>  /**
>   * aio_chip_set_pll - set frequency to audio PLL
> - * @chip  : the AIO chip pointer
> - * @source: PLL
> - * @freq  : frequency in Hz, 0 is ignored
> + * @chip: the AIO chip pointer
> + * @pll_id: PLL
> + * @freq: frequency in Hz, 0 is ignored
>   *
>   * Sets frequency of audio PLL. This function can be called anytime,
>   * but it takes time till PLL is locked.
> @@ -267,7 +267,6 @@ void aio_port_reset(struct uniphier_aio_sub *sub)
>  /**
>   * aio_port_set_ch - set channels of LPCM
>   * @sub: the AIO substream pointer, PCM substream only
> - * @ch : count of channels
>   *
>   * Set suitable slot selecting to input/output port block of AIO.
>   *
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

WARNING: multiple messages have this Message-ID (diff)
From: Masahiro Yamada <masahiroy@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	"moderated list:ARM/UNIPHIER ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 8/8] ASoC: uniphier: aio-core: fix kernel-doc
Date: Tue, 7 Jul 2020 19:58:10 +0900	[thread overview]
Message-ID: <CAK7LNARV9p=TF+5kPx-MBOsGnE9mafndYTEoaWRAaieqeL5a5A@mail.gmail.com> (raw)
In-Reply-To: <20200702165901.164100-9-pierre-louis.bossart@linux.intel.com>

On Fri, Jul 3, 2020 at 1:59 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> Fix W=1 warning - wrong parameter description and bad format
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


>  sound/soc/uniphier/aio-core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
> index 9bcba06ba52e..b8195778953e 100644
> --- a/sound/soc/uniphier/aio-core.c
> +++ b/sound/soc/uniphier/aio-core.c
> @@ -93,9 +93,9 @@ void aio_iecout_set_enable(struct uniphier_aio_chip *chip, bool enable)
>
>  /**
>   * aio_chip_set_pll - set frequency to audio PLL
> - * @chip  : the AIO chip pointer
> - * @source: PLL
> - * @freq  : frequency in Hz, 0 is ignored
> + * @chip: the AIO chip pointer
> + * @pll_id: PLL
> + * @freq: frequency in Hz, 0 is ignored
>   *
>   * Sets frequency of audio PLL. This function can be called anytime,
>   * but it takes time till PLL is locked.
> @@ -267,7 +267,6 @@ void aio_port_reset(struct uniphier_aio_sub *sub)
>  /**
>   * aio_port_set_ch - set channels of LPCM
>   * @sub: the AIO substream pointer, PCM substream only
> - * @ch : count of channels
>   *
>   * Set suitable slot selecting to input/output port block of AIO.
>   *
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-07 10:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 16:58 [PATCH 0/8] ASoC: fix W=1 warnings for various SOCs Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 1/8] ASoC: atmel: fix kernel-doc Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 18:27   ` Alexandre Belloni
2020-07-02 18:27     ` Alexandre Belloni
2020-07-02 18:27     ` Alexandre Belloni
2020-07-02 16:58 ` [PATCH 2/8] ASoC: samsung: spdif: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-03 18:07   ` Sylwester Nawrocki
2020-07-03 18:07     ` Sylwester Nawrocki
2020-07-02 16:58 ` [PATCH 3/8] ASoC: samsung: pcm: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-03 18:47   ` Sylwester Nawrocki
2020-07-03 18:47     ` Sylwester Nawrocki
2020-07-06 15:03     ` Pierre-Louis Bossart
2020-07-06 15:03       ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 4/8] ASoC: qcom: q6asm: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 5/8] ASoC: sunxi: sun4i-i2s: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58 ` [PATCH 6/8] ASoC: sunxi: sun4i-spdif: " Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
2020-07-02 16:58   ` Pierre-Louis Bossart
     [not found] ` <20200702165901.164100-1-pierre-louis.bossart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-07-02 16:59   ` [PATCH 7/8] ASoC: tegra: tegra20_das: remove always-true comparison Pierre-Louis Bossart
2020-07-02 16:59     ` Pierre-Louis Bossart
2020-07-02 16:59     ` Pierre-Louis Bossart
     [not found]     ` <20200702165901.164100-8-pierre-louis.bossart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2020-07-06 15:16       ` Jon Hunter
2020-07-06 15:16         ` Jon Hunter
2020-07-06 15:16         ` Jon Hunter
2020-07-02 16:59 ` [PATCH 8/8] ASoC: uniphier: aio-core: fix kernel-doc Pierre-Louis Bossart
2020-07-02 16:59   ` Pierre-Louis Bossart
2020-07-02 16:59   ` Pierre-Louis Bossart
2020-07-07 10:58   ` Masahiro Yamada [this message]
2020-07-07 10:58     ` Masahiro Yamada
2020-07-07 10:58     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK7LNARV9p=TF+5kPx-MBOsGnE9mafndYTEoaWRAaieqeL5a5A@mail.gmail.com' \
    --to=masahiroy@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.