From: Nicholas Piggin <npiggin@gmail.com> To: linux-arch@vger.kernel.org Cc: Nicholas Piggin <npiggin@gmail.com>, x86@kernel.org, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Arnd Bergmann <arnd@arndb.de>, Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, Anton Blanchard <anton@ozlabs.org> Subject: [RFC PATCH 0/7] mmu context cleanup, lazy tlb cleanup, Date: Fri, 10 Jul 2020 11:56:39 +1000 [thread overview] Message-ID: <20200710015646.2020871-1-npiggin@gmail.com> (raw) This blew up a bit bigger than I thought, so I'd like to get some comments as to whether people agree with the direction it's going. The patches aren't cleanly split out by arch, but as it is now it's probably easier to get a quick overview of the changes at a glance anyway. So there's a few different things here. 1. Clean up and use asm-generic for no-op mmu context functions (so not just for nommu architectures). This should be functionally a no-op for everybody. This allows exit_lazy_tlb to easily be added. 2. Add exit_lazy_tlb and use it for x86, so this is x86 and membarrier specific changes. I _may_ have spotted a small membarrier / core sync bug here when adding exit_lazy_tlb. 3. Tidy up lazy tlb a little bit, have its own refcount function and allow it to be selected out. We can audit the nommu archs and deselect it for those. 4. Add a non-refcounting lazy mmu mode, to help scalability when the same mm is used for a lot of lazy mmu switching. Comments, questions on anything would be much appreciated. Thanks, Nick Nicholas Piggin (7): asm-generic: add generic MMU versions of mmu context functions arch: use asm-generic mmu context for no-op implementations mm: introduce exit_lazy_tlb x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode lazy tlb: introduce lazy mm refcount helper functions lazy tlb: allow lazy tlb mm switching to be configurable lazy tlb: shoot lazies, a non-refcounting lazy tlb option .../membarrier-sync-core/arch-support.txt | 6 +- arch/Kconfig | 23 +++++ arch/alpha/include/asm/mmu_context.h | 12 +-- arch/arc/include/asm/mmu_context.h | 16 ++-- arch/arm/include/asm/mmu_context.h | 26 +----- arch/arm64/include/asm/mmu_context.h | 7 +- arch/csky/include/asm/mmu_context.h | 8 +- arch/hexagon/include/asm/mmu_context.h | 33 ++------ arch/ia64/include/asm/mmu_context.h | 17 +--- arch/m68k/include/asm/mmu_context.h | 47 ++--------- arch/microblaze/include/asm/mmu_context.h | 2 +- arch/microblaze/include/asm/mmu_context_mm.h | 8 +- arch/microblaze/include/asm/processor.h | 3 - arch/mips/include/asm/mmu_context.h | 11 +-- arch/nds32/include/asm/mmu_context.h | 10 +-- arch/nios2/include/asm/mmu_context.h | 21 +---- arch/nios2/mm/mmu_context.c | 1 + arch/openrisc/include/asm/mmu_context.h | 8 +- arch/openrisc/mm/tlb.c | 2 + arch/parisc/include/asm/mmu_context.h | 12 +-- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/mmu_context.h | 22 ++--- arch/powerpc/kernel/smp.c | 2 +- arch/powerpc/mm/book3s64/radix_tlb.c | 4 +- arch/riscv/include/asm/mmu_context.h | 22 +---- arch/s390/include/asm/mmu_context.h | 9 +- arch/sh/include/asm/mmu_context.h | 7 +- arch/sh/include/asm/mmu_context_32.h | 9 -- arch/sparc/include/asm/mmu_context_32.h | 10 +-- arch/sparc/include/asm/mmu_context_64.h | 10 +-- arch/um/include/asm/mmu_context.h | 12 ++- arch/unicore32/include/asm/mmu_context.h | 24 +----- arch/x86/include/asm/mmu_context.h | 41 +++++++++ arch/x86/include/asm/sync_core.h | 28 ------- arch/xtensa/include/asm/mmu_context.h | 11 +-- arch/xtensa/include/asm/nommu_context.h | 26 +----- fs/exec.c | 5 +- include/asm-generic/mmu_context.h | 77 +++++++++++++---- include/asm-generic/nommu_context.h | 19 +++++ include/linux/sched/mm.h | 35 ++++---- include/linux/sync_core.h | 21 ----- kernel/cpu.c | 6 +- kernel/exit.c | 2 +- kernel/fork.c | 39 +++++++++ kernel/kthread.c | 12 ++- kernel/sched/core.c | 84 ++++++++++++------- kernel/sched/sched.h | 4 +- 47 files changed, 388 insertions(+), 427 deletions(-) delete mode 100644 arch/x86/include/asm/sync_core.h create mode 100644 include/asm-generic/nommu_context.h delete mode 100644 include/linux/sync_core.h -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com> To: linux-arch@vger.kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, Peter Zijlstra <peterz@infradead.org>, x86@kernel.org, linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>, linux-mm@kvack.org, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, linuxppc-dev@lists.ozlabs.org Subject: [RFC PATCH 0/7] mmu context cleanup, lazy tlb cleanup, Date: Fri, 10 Jul 2020 11:56:39 +1000 [thread overview] Message-ID: <20200710015646.2020871-1-npiggin@gmail.com> (raw) This blew up a bit bigger than I thought, so I'd like to get some comments as to whether people agree with the direction it's going. The patches aren't cleanly split out by arch, but as it is now it's probably easier to get a quick overview of the changes at a glance anyway. So there's a few different things here. 1. Clean up and use asm-generic for no-op mmu context functions (so not just for nommu architectures). This should be functionally a no-op for everybody. This allows exit_lazy_tlb to easily be added. 2. Add exit_lazy_tlb and use it for x86, so this is x86 and membarrier specific changes. I _may_ have spotted a small membarrier / core sync bug here when adding exit_lazy_tlb. 3. Tidy up lazy tlb a little bit, have its own refcount function and allow it to be selected out. We can audit the nommu archs and deselect it for those. 4. Add a non-refcounting lazy mmu mode, to help scalability when the same mm is used for a lot of lazy mmu switching. Comments, questions on anything would be much appreciated. Thanks, Nick Nicholas Piggin (7): asm-generic: add generic MMU versions of mmu context functions arch: use asm-generic mmu context for no-op implementations mm: introduce exit_lazy_tlb x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode lazy tlb: introduce lazy mm refcount helper functions lazy tlb: allow lazy tlb mm switching to be configurable lazy tlb: shoot lazies, a non-refcounting lazy tlb option .../membarrier-sync-core/arch-support.txt | 6 +- arch/Kconfig | 23 +++++ arch/alpha/include/asm/mmu_context.h | 12 +-- arch/arc/include/asm/mmu_context.h | 16 ++-- arch/arm/include/asm/mmu_context.h | 26 +----- arch/arm64/include/asm/mmu_context.h | 7 +- arch/csky/include/asm/mmu_context.h | 8 +- arch/hexagon/include/asm/mmu_context.h | 33 ++------ arch/ia64/include/asm/mmu_context.h | 17 +--- arch/m68k/include/asm/mmu_context.h | 47 ++--------- arch/microblaze/include/asm/mmu_context.h | 2 +- arch/microblaze/include/asm/mmu_context_mm.h | 8 +- arch/microblaze/include/asm/processor.h | 3 - arch/mips/include/asm/mmu_context.h | 11 +-- arch/nds32/include/asm/mmu_context.h | 10 +-- arch/nios2/include/asm/mmu_context.h | 21 +---- arch/nios2/mm/mmu_context.c | 1 + arch/openrisc/include/asm/mmu_context.h | 8 +- arch/openrisc/mm/tlb.c | 2 + arch/parisc/include/asm/mmu_context.h | 12 +-- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/mmu_context.h | 22 ++--- arch/powerpc/kernel/smp.c | 2 +- arch/powerpc/mm/book3s64/radix_tlb.c | 4 +- arch/riscv/include/asm/mmu_context.h | 22 +---- arch/s390/include/asm/mmu_context.h | 9 +- arch/sh/include/asm/mmu_context.h | 7 +- arch/sh/include/asm/mmu_context_32.h | 9 -- arch/sparc/include/asm/mmu_context_32.h | 10 +-- arch/sparc/include/asm/mmu_context_64.h | 10 +-- arch/um/include/asm/mmu_context.h | 12 ++- arch/unicore32/include/asm/mmu_context.h | 24 +----- arch/x86/include/asm/mmu_context.h | 41 +++++++++ arch/x86/include/asm/sync_core.h | 28 ------- arch/xtensa/include/asm/mmu_context.h | 11 +-- arch/xtensa/include/asm/nommu_context.h | 26 +----- fs/exec.c | 5 +- include/asm-generic/mmu_context.h | 77 +++++++++++++---- include/asm-generic/nommu_context.h | 19 +++++ include/linux/sched/mm.h | 35 ++++---- include/linux/sync_core.h | 21 ----- kernel/cpu.c | 6 +- kernel/exit.c | 2 +- kernel/fork.c | 39 +++++++++ kernel/kthread.c | 12 ++- kernel/sched/core.c | 84 ++++++++++++------- kernel/sched/sched.h | 4 +- 47 files changed, 388 insertions(+), 427 deletions(-) delete mode 100644 arch/x86/include/asm/sync_core.h create mode 100644 include/asm-generic/nommu_context.h delete mode 100644 include/linux/sync_core.h -- 2.23.0
next reply other threads:[~2020-07-10 1:57 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-10 1:56 Nicholas Piggin [this message] 2020-07-10 1:56 ` [RFC PATCH 0/7] mmu context cleanup, lazy tlb cleanup, Nicholas Piggin 2020-07-10 1:56 ` [RFC PATCH 1/7] asm-generic: add generic MMU versions of mmu context functions Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 1:56 ` [RFC PATCH 2/7] arch: use asm-generic mmu context for no-op implementations Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 1:56 ` [RFC PATCH 3/7] mm: introduce exit_lazy_tlb Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 1:56 ` [RFC PATCH 4/7] x86: use exit_lazy_tlb rather than membarrier_mm_sync_core_before_usermode Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 9:42 ` Peter Zijlstra 2020-07-10 9:42 ` Peter Zijlstra 2020-07-10 14:02 ` Mathieu Desnoyers 2020-07-10 14:02 ` Mathieu Desnoyers 2020-07-10 14:02 ` Mathieu Desnoyers 2020-07-10 17:04 ` Andy Lutomirski 2020-07-10 17:04 ` Andy Lutomirski 2020-07-10 17:04 ` Andy Lutomirski 2020-07-13 4:45 ` Nicholas Piggin 2020-07-13 4:45 ` Nicholas Piggin 2020-07-13 13:47 ` Nicholas Piggin 2020-07-13 13:47 ` Nicholas Piggin 2020-07-13 14:13 ` Mathieu Desnoyers 2020-07-13 14:13 ` Mathieu Desnoyers 2020-07-13 14:13 ` Mathieu Desnoyers 2020-07-13 15:48 ` Andy Lutomirski 2020-07-13 15:48 ` Andy Lutomirski 2020-07-13 15:48 ` Andy Lutomirski 2020-07-13 16:37 ` Nicholas Piggin 2020-07-13 16:37 ` Nicholas Piggin 2020-07-16 4:15 ` Nicholas Piggin 2020-07-16 4:15 ` Nicholas Piggin 2020-07-16 4:42 ` Nicholas Piggin 2020-07-16 4:42 ` Nicholas Piggin 2020-07-16 15:46 ` Mathieu Desnoyers 2020-07-16 15:46 ` Mathieu Desnoyers 2020-07-16 15:46 ` Mathieu Desnoyers 2020-07-16 16:03 ` Mathieu Desnoyers 2020-07-16 16:03 ` Mathieu Desnoyers 2020-07-16 16:03 ` Mathieu Desnoyers 2020-07-16 18:58 ` Mathieu Desnoyers 2020-07-16 18:58 ` Mathieu Desnoyers 2020-07-16 18:58 ` Mathieu Desnoyers 2020-07-16 21:24 ` Alan Stern 2020-07-16 21:24 ` Alan Stern 2020-07-17 13:39 ` Mathieu Desnoyers 2020-07-17 13:39 ` Mathieu Desnoyers 2020-07-17 13:39 ` Mathieu Desnoyers 2020-07-17 14:51 ` Alan Stern 2020-07-17 14:51 ` Alan Stern 2020-07-17 15:39 ` Mathieu Desnoyers 2020-07-17 15:39 ` Mathieu Desnoyers 2020-07-17 15:39 ` Mathieu Desnoyers 2020-07-17 16:11 ` Alan Stern 2020-07-17 16:11 ` Alan Stern 2020-07-17 16:22 ` Mathieu Desnoyers 2020-07-17 16:22 ` Mathieu Desnoyers 2020-07-17 16:22 ` Mathieu Desnoyers 2020-07-17 17:44 ` Alan Stern 2020-07-17 17:44 ` Alan Stern 2020-07-17 17:52 ` Mathieu Desnoyers 2020-07-17 17:52 ` Mathieu Desnoyers 2020-07-17 17:52 ` Mathieu Desnoyers 2020-07-17 0:00 ` Nicholas Piggin 2020-07-17 0:00 ` Nicholas Piggin 2020-07-16 5:18 ` Andy Lutomirski 2020-07-16 5:18 ` Andy Lutomirski 2020-07-16 6:06 ` Nicholas Piggin 2020-07-16 6:06 ` Nicholas Piggin 2020-07-16 8:50 ` Peter Zijlstra 2020-07-16 8:50 ` Peter Zijlstra 2020-07-16 10:03 ` Nicholas Piggin 2020-07-16 10:03 ` Nicholas Piggin 2020-07-16 11:00 ` peterz 2020-07-16 11:00 ` peterz 2020-07-16 15:34 ` Mathieu Desnoyers 2020-07-16 15:34 ` Mathieu Desnoyers 2020-07-16 15:34 ` Mathieu Desnoyers 2020-07-16 23:26 ` Nicholas Piggin 2020-07-16 23:26 ` Nicholas Piggin 2020-07-17 13:42 ` Mathieu Desnoyers 2020-07-17 13:42 ` Mathieu Desnoyers 2020-07-17 13:42 ` Mathieu Desnoyers 2020-07-20 3:03 ` Nicholas Piggin 2020-07-20 3:03 ` Nicholas Piggin 2020-07-20 16:46 ` Mathieu Desnoyers 2020-07-20 16:46 ` Mathieu Desnoyers 2020-07-20 16:46 ` Mathieu Desnoyers 2020-07-21 10:04 ` Nicholas Piggin 2020-07-21 10:04 ` Nicholas Piggin 2020-07-21 13:11 ` Mathieu Desnoyers 2020-07-21 13:11 ` Mathieu Desnoyers 2020-07-21 13:11 ` Mathieu Desnoyers 2020-07-21 14:30 ` Nicholas Piggin 2020-07-21 14:30 ` Nicholas Piggin 2020-07-21 15:06 ` peterz 2020-07-21 15:06 ` peterz 2020-07-21 15:15 ` Mathieu Desnoyers 2020-07-21 15:15 ` Mathieu Desnoyers 2020-07-21 15:15 ` Mathieu Desnoyers 2020-07-21 15:19 ` Peter Zijlstra 2020-07-21 15:19 ` Peter Zijlstra 2020-07-21 15:22 ` Mathieu Desnoyers 2020-07-21 15:22 ` Mathieu Desnoyers 2020-07-21 15:22 ` Mathieu Desnoyers 2020-07-10 1:56 ` [RFC PATCH 5/7] lazy tlb: introduce lazy mm refcount helper functions Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 9:48 ` Peter Zijlstra 2020-07-10 9:48 ` Peter Zijlstra 2020-07-10 1:56 ` [RFC PATCH 6/7] lazy tlb: allow lazy tlb mm switching to be configurable Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 1:56 ` [RFC PATCH 7/7] lazy tlb: shoot lazies, a non-refcounting lazy tlb option Nicholas Piggin 2020-07-10 1:56 ` Nicholas Piggin 2020-07-10 9:35 ` Peter Zijlstra 2020-07-10 9:35 ` Peter Zijlstra 2020-07-13 4:58 ` Nicholas Piggin 2020-07-13 4:58 ` Nicholas Piggin 2020-07-13 15:59 ` Andy Lutomirski 2020-07-13 15:59 ` Andy Lutomirski 2020-07-13 15:59 ` Andy Lutomirski 2020-07-13 16:48 ` Nicholas Piggin 2020-07-13 16:48 ` Nicholas Piggin 2020-07-13 18:18 ` Andy Lutomirski 2020-07-13 18:18 ` Andy Lutomirski 2020-07-14 5:04 ` Nicholas Piggin 2020-07-14 5:04 ` Nicholas Piggin 2020-07-14 6:31 ` Nicholas Piggin 2020-07-14 6:31 ` Nicholas Piggin 2020-07-14 12:46 ` Andy Lutomirski 2020-07-14 12:46 ` Andy Lutomirski 2020-07-14 13:23 ` Peter Zijlstra 2020-07-14 13:23 ` Peter Zijlstra 2020-07-16 2:26 ` Nicholas Piggin 2020-07-16 2:26 ` Nicholas Piggin 2020-07-16 2:35 ` Nicholas Piggin 2020-07-16 2:35 ` Nicholas Piggin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200710015646.2020871-1-npiggin@gmail.com \ --to=npiggin@gmail.com \ --cc=anton@ozlabs.org \ --cc=arnd@arndb.de \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=peterz@infradead.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.