[PATCH 0/2] ARM: dts: renesas: Cleanup ADV7180 bindings

[PATCH 0/2] ARM: dts: renesas: Cleanup ADV7180 bindings

[Niklas Söderlund]

Hello,

While converting the ADV7180 bindings to YAML and running the checker on 
the Renesas DTS files some issues where found. I guess all this 
conversion of bindings can pay off :-)

Niklas Söderlund (2):
  ARM: dts: gose: Fix ports node name for adv7180
  ARM: dts: renesas: Remove unused remote property from adv7180 nodes

 arch/arm/boot/dts/r8a7790-lager.dts   | 1 -
 arch/arm/boot/dts/r8a7791-koelsch.dts | 1 -
 arch/arm/boot/dts/r8a7791-porter.dts  | 1 -
 arch/arm/boot/dts/r8a7793-gose.dts    | 3 +--
 arch/arm/boot/dts/r8a7794-alt.dts     | 1 -
 arch/arm/boot/dts/r8a7794-silk.dts    | 1 -
 6 files changed, 1 insertion(+), 7 deletions(-)

-- 
2.27.0

[PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Niklas Söderlund]

When adding the adv7180 device node the ports node was misspelled as
port, fix this.

Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 79baf06019f5a6ff..a378b54867bb4d1f 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -336,7 +336,7 @@ composite-in@20 {
 			reg = <0x20>;
 			remote = <&vin1>;
 
-			port {
+			ports {
 				#address-cells = <1>;
 				#size-cells = <0>;
 
-- 
2.27.0

[PATCH 2/2] ARM: dts: renesas: Remove unused remote property from adv7180 nodes

[Niklas Söderlund]

The remote property is never read by the driver, remove it.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm/boot/dts/r8a7790-lager.dts   | 1 -
 arch/arm/boot/dts/r8a7791-koelsch.dts | 1 -
 arch/arm/boot/dts/r8a7791-porter.dts  | 1 -
 arch/arm/boot/dts/r8a7793-gose.dts    | 1 -
 arch/arm/boot/dts/r8a7794-alt.dts     | 1 -
 arch/arm/boot/dts/r8a7794-silk.dts    | 1 -
 6 files changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index bfe778c4c47bc186..09a152b9155754ac 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -343,7 +343,6 @@ ak4643: codec@12 {
 		composite-in@20 {
 			compatible = "adi,adv7180";
 			reg = <0x20>;
-			remote = <&vin1>;
 
 			port {
 				adv7180: endpoint {
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index fc74c6cd6def5718..f603cba5441fcb9e 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -366,7 +366,6 @@ ak4643: codec@12 {
 		composite-in@20 {
 			compatible = "adi,adv7180";
 			reg = <0x20>;
-			remote = <&vin1>;
 
 			port {
 				adv7180: endpoint {
diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts
index 114bf1c4199b6aa4..c6d563fb7ec7c17f 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -162,7 +162,6 @@ ak4642: codec@12 {
 		composite-in@20 {
 			compatible = "adi,adv7180";
 			reg = <0x20>;
-			remote = <&vin0>;
 
 			port {
 				adv7180: endpoint {
diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index a378b54867bb4d1f..31fd3e9ae33e5551 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -334,7 +334,6 @@ ak4643: codec@12 {
 		composite-in@20 {
 			compatible = "adi,adv7180cp";
 			reg = <0x20>;
-			remote = <&vin1>;
 
 			ports {
 				#address-cells = <1>;
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts
index 935935c1dbac057d..3f1cc5bbf32979e8 100644
--- a/arch/arm/boot/dts/r8a7794-alt.dts
+++ b/arch/arm/boot/dts/r8a7794-alt.dts
@@ -167,7 +167,6 @@ i2chdmi: i2c-11 {
 		composite-in@20 {
 			compatible = "adi,adv7180";
 			reg = <0x20>;
-			remote = <&vin0>;
 
 			port {
 				adv7180: endpoint {
diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
index b8b0941f677c1cd4..677596f6c9c9a7d9 100644
--- a/arch/arm/boot/dts/r8a7794-silk.dts
+++ b/arch/arm/boot/dts/r8a7794-silk.dts
@@ -236,7 +236,6 @@ ak4643: codec@12 {
 		composite-in@20 {
 			compatible = "adi,adv7180";
 			reg = <0x20>;
-			remote = <&vin0>;
 
 			port {
 				adv7180: endpoint {
-- 
2.27.0

Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Geert Uytterhoeven]

Hi Niklas,

On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> When adding the adv7180 device node the ports node was misspelled as
> port, fix this.
>
> Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -336,7 +336,7 @@ composite-in@20 {
>                         reg = <0x20>;
>                         remote = <&vin1>;
>
> -                       port {
> +                       ports {
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>

Does this have any run-time impact, or dependencies?
Don't we need the same fix for the other boards?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Niklas Söderlund]

Hi Geert,

On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > When adding the adv7180 device node the ports node was misspelled as
> > port, fix this.
> >
> > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > @@ -336,7 +336,7 @@ composite-in@20 {
> >                         reg = <0x20>;
> >                         remote = <&vin1>;
> >
> > -                       port {
> > +                       ports {
> >                                 #address-cells = <1>;
> >                                 #size-cells = <0>;
> >
> 
> Does this have any run-time impact, or dependencies?

No run-time impact.

> Don't we need the same fix for the other boards?

The only other board we have that uses the same compatible string 
(adi,adv7180cp) is Draak and there the ports node is already correctly 
named.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
Niklas Söderlund

Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Geert Uytterhoeven]

Hi Niklas,

On Mon, Jul 13, 2020 at 9:24 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> On 2020-07-07 11:59:12 +0200, Geert Uytterhoeven wrote:
> > On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
> > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > > When adding the adv7180 device node the ports node was misspelled as
> > > port, fix this.
> > >
> > > Fixes: 8cae359049a88b75 ("ARM: dts: gose: add composite video input")
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > > +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > > @@ -336,7 +336,7 @@ composite-in@20 {
> > >                         reg = <0x20>;
> > >                         remote = <&vin1>;
> > >
> > > -                       port {
> > > +                       ports {
> > >                                 #address-cells = <1>;
> > >                                 #size-cells = <0>;
> > >
> >
> > Does this have any run-time impact, or dependencies?
>
> No run-time impact.

OK.

> > Don't we need the same fix for the other boards?
>
> The only other board we have that uses the same compatible string
> (adi,adv7180cp) is Draak and there the ports node is already correctly
> named.

Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter,
Alt, and Silk are using "adi,adv7180".

Next question: why the difference? Gose and Koelsch should be identical
w.r.t. these interfaces.  In fact all boards listed above are using
ADV7180WBCP32Z, and seem to use similar wiring.

What's happening?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Niklas Söderlund]

Hi Geert,

On 2020-07-13 09:51:08 +0200, Geert Uytterhoeven wrote:
> > > Don't we need the same fix for the other boards?
> >
> > The only other board we have that uses the same compatible string
> > (adi,adv7180cp) is Draak and there the ports node is already correctly
> > named.
> 
> Ah, I missed Gose is using "adi,adv7180cp", while Lager, Koelsch, Porter,
> Alt, and Silk are using "adi,adv7180".
> 
> Next question: why the difference? Gose and Koelsch should be identical
> w.r.t. these interfaces.  In fact all boards listed above are using
> ADV7180WBCP32Z, and seem to use similar wiring.

Good point.

The difference as far as I can tell is only in the bindings. The older 
'adi,adv7180' compatibility string only describes where the adv7180 is 
transmitting the data it collects from an undescribed connector. While 
the more recent compat string 'adi,adv7180cp' describes both the 
destination and the connector. A good example as you point out is to 
compare koelsch with gose. From a V4L2 point of view the connector being 
described does not effect the capture operation.

Ulrich maybe you can help us shed some light on this as you added the 
new compat strings?

> 
> What's happening?

If I only knew ;-)

-- 
Regards,
Niklas Söderlund

Re: [PATCH 1/2] ARM: dts: gose: Fix ports node name for adv7180

[Ulrich Hecht]

> On July 13, 2020 10:15 AM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote:
> The difference as far as I can tell is only in the bindings. The older 
> 'adi,adv7180' compatibility string only describes where the adv7180 is 
> transmitting the data it collects from an undescribed connector. While 
> the more recent compat string 'adi,adv7180cp' describes both the 
> destination and the connector. A good example as you point out is to 
> compare koelsch with gose. From a V4L2 point of view the connector being 
> described does not effect the capture operation.
> 
> Ulrich maybe you can help us shed some light on this as you added the 
> new compat strings?

Executive summary: "[Laurent and Hans] agreed that DT should model physical ports."
Full details: https://www.mail-archive.com/linux-media@vger.kernel.org/msg103799.html

The reason why it's only in Gose is that that was the patch series that raised the issue, and we didn't update the existing implementations.

CU
Uli

Re: [PATCH 2/2] ARM: dts: renesas: Remove unused remote property from adv7180 nodes

[Geert Uytterhoeven]

Hi Niklas,

Thanks for your patch!

On Sat, Jul 4, 2020 at 5:59 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The remote property is never read by the driver, remove it.

More important: the DT bindings don't mention this property ;-)

Still, there are a few references left in examples:

    $ git grep "remote =" -- Documentation/devicetree/bindings/
    Documentation/devicetree/bindings/i2c/i2c-demux-pinctrl.txt:
             remote = <&vin1>;
    Documentation/devicetree/bindings/media/video-interfaces.txt:
                     remote = <&ov772x_1_1>; /* Remote phandle */
    Documentation/devicetree/bindings/media/video-interfaces.txt:
                     remote = <&csi2_2>;

> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds