All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: trigger: Staticise stub functions
@ 2020-07-14 14:24 Alexandru Ardelean
  2020-07-18 16:25 ` Jonathan Cameron
  2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
  0 siblings, 2 replies; 6+ messages in thread
From: Alexandru Ardelean @ 2020-07-14 14:24 UTC (permalink / raw)
  To: linux-iio, linux-kernel; +Cc: jic23, Lars-Peter Clausen, Alexandru Ardelean

From: Lars-Peter Clausen <lars@metafoo.de>

Make sure that the trigger function stubs are all static inline. Otherwise
we'll get linker errors due to multiple definitions of the same function.

Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---

FWIW: we can skip the Fixes tag from my side; this has been present for
a while.
I just bumped into it while sync-ing the ADI tree with some upstream
stuff.

 drivers/iio/iio_core_trigger.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
index 9d1a92cc6480..374816bc3e73 100644
--- a/drivers/iio/iio_core_trigger.h
+++ b/drivers/iio/iio_core_trigger.h
@@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig,
  * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers
  * @indio_dev: iio_dev associated with the device that will consume the trigger
  **/
-static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
+static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
 {
 	return 0;
 }
@@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
  * iio_device_unregister_trigger_consumer() - reverse the registration process
  * @indio_dev: iio_dev associated with the device that consumed the trigger
  **/
-static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
+static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
 {
 }
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] iio: trigger: Staticise stub functions
  2020-07-14 14:24 [PATCH] iio: trigger: Staticise stub functions Alexandru Ardelean
@ 2020-07-18 16:25 ` Jonathan Cameron
  2020-07-18 16:36   ` Lars-Peter Clausen
  2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
  1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2020-07-18 16:25 UTC (permalink / raw)
  To: Alexandru Ardelean; +Cc: linux-iio, linux-kernel, Lars-Peter Clausen

On Tue, 14 Jul 2020 17:24:56 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> From: Lars-Peter Clausen <lars@metafoo.de>
> 
> Make sure that the trigger function stubs are all static inline. Otherwise
> we'll get linker errors due to multiple definitions of the same function.
> 
> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

I'm curious on what the actual build error is?  Static functions should
result in independent implementations in each C file that includes
them. Inline is normally considered a hint.  Hence what am I missing?

Jonathan

> ---
> 
> FWIW: we can skip the Fixes tag from my side; this has been present for
> a while.
> I just bumped into it while sync-ing the ADI tree with some upstream
> stuff.
> 
>  drivers/iio/iio_core_trigger.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
> index 9d1a92cc6480..374816bc3e73 100644
> --- a/drivers/iio/iio_core_trigger.h
> +++ b/drivers/iio/iio_core_trigger.h
> @@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig,
>   * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers
>   * @indio_dev: iio_dev associated with the device that will consume the trigger
>   **/
> -static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
> +static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
>  {
>  	return 0;
>  }
> @@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
>   * iio_device_unregister_trigger_consumer() - reverse the registration process
>   * @indio_dev: iio_dev associated with the device that consumed the trigger
>   **/
> -static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
> +static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
>  {
>  }
>  


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] iio: trigger: Staticise stub functions
  2020-07-18 16:25 ` Jonathan Cameron
@ 2020-07-18 16:36   ` Lars-Peter Clausen
  2020-07-18 17:10     ` Ardelean, Alexandru
  0 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2020-07-18 16:36 UTC (permalink / raw)
  To: Jonathan Cameron, Alexandru Ardelean; +Cc: linux-iio, linux-kernel

On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
>> From: Lars-Peter Clausen <lars@metafoo.de>
>>
>> Make sure that the trigger function stubs are all static inline. Otherwise
>> we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> I'm curious on what the actual build error is?  Static functions should
> result in independent implementations in each C file that includes
> them. Inline is normally considered a hint.  Hence what am I missing?

It's a bad commit message, my fault. This should have been

Make sure that the trigger function stubs are all static inline. 
Otherwise we might see compiler warnings about declared but unused 
functions.



^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] iio: trigger: Staticise stub functions
  2020-07-18 16:36   ` Lars-Peter Clausen
@ 2020-07-18 17:10     ` Ardelean, Alexandru
  0 siblings, 0 replies; 6+ messages in thread
From: Ardelean, Alexandru @ 2020-07-18 17:10 UTC (permalink / raw)
  To: Lars-Peter Clausen, Jonathan Cameron; +Cc: linux-iio, linux-kernel

Apologies from my side for being too much of a patch-bot here.
I should have also given some more thought to the patch.
Atm, I'm sending this from Outlook, since [for some reason] the Linux mail-client isn't working.
[ Which is why this isn't properly inlined either ]

I'll send a V2.

-----Original Message-----
From: Lars-Peter Clausen <lars@metafoo.de> 
Sent: Saturday, July 18, 2020 7:37 PM
To: Jonathan Cameron <jic23@kernel.org>; Ardelean, Alexandru <alexandru.Ardelean@analog.com>
Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: Staticise stub functions

[External]

On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
>> From: Lars-Peter Clausen <lars@metafoo.de>
>>
>> Make sure that the trigger function stubs are all static inline. 
>> Otherwise we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> I'm curious on what the actual build error is?  Static functions 
> should result in independent implementations in each C file that 
> includes them. Inline is normally considered a hint.  Hence what am I missing?

It's a bad commit message, my fault. This should have been

Make sure that the trigger function stubs are all static inline. 
Otherwise we might see compiler warnings about declared but unused functions.




^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] iio: trigger: make stub functions static inline
  2020-07-14 14:24 [PATCH] iio: trigger: Staticise stub functions Alexandru Ardelean
  2020-07-18 16:25 ` Jonathan Cameron
@ 2020-07-20 13:51 ` Alexandru Ardelean
  2020-07-26 12:43   ` Jonathan Cameron
  1 sibling, 1 reply; 6+ messages in thread
From: Alexandru Ardelean @ 2020-07-20 13:51 UTC (permalink / raw)
  To: linux-iio, linux-kernel; +Cc: lars, jic23, Alexandru Ardelean

From: Lars-Peter Clausen <lars@metafoo.de>

Make sure that the trigger function stubs are all static inline.
Otherwise we might see compiler warnings about declared but unused
functions.

Fixes 77712e5fbe2e4: ("Staging: iio: Staticise non-exported functions")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---

Changelog v1 -> v2:
* fix commit description & title
* added proper Fixes tag

 drivers/iio/iio_core_trigger.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
index 9d1a92cc6480..374816bc3e73 100644
--- a/drivers/iio/iio_core_trigger.h
+++ b/drivers/iio/iio_core_trigger.h
@@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig,
  * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers
  * @indio_dev: iio_dev associated with the device that will consume the trigger
  **/
-static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
+static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
 {
 	return 0;
 }
@@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
  * iio_device_unregister_trigger_consumer() - reverse the registration process
  * @indio_dev: iio_dev associated with the device that consumed the trigger
  **/
-static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
+static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
 {
 }
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: trigger: make stub functions static inline
  2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
@ 2020-07-26 12:43   ` Jonathan Cameron
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-07-26 12:43 UTC (permalink / raw)
  To: Alexandru Ardelean; +Cc: linux-iio, linux-kernel, lars

On Mon, 20 Jul 2020 16:51:33 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> From: Lars-Peter Clausen <lars@metafoo.de>
> 
> Make sure that the trigger function stubs are all static inline.
> Otherwise we might see compiler warnings about declared but unused
> functions.
> 
> Fixes 77712e5fbe2e4: ("Staging: iio: Staticise non-exported functions")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
As it's only warning suppression I'm not going to rush this one.

applied to the togreg branch of iio.git

Thanks,

Jonathan

> ---
> 
> Changelog v1 -> v2:
> * fix commit description & title
> * added proper Fixes tag
> 
>  drivers/iio/iio_core_trigger.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
> index 9d1a92cc6480..374816bc3e73 100644
> --- a/drivers/iio/iio_core_trigger.h
> +++ b/drivers/iio/iio_core_trigger.h
> @@ -30,7 +30,7 @@ int iio_trigger_detach_poll_func(struct iio_trigger *trig,
>   * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers
>   * @indio_dev: iio_dev associated with the device that will consume the trigger
>   **/
> -static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
> +static inline int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
>  {
>  	return 0;
>  }
> @@ -39,7 +39,7 @@ static int iio_device_register_trigger_consumer(struct iio_dev *indio_dev)
>   * iio_device_unregister_trigger_consumer() - reverse the registration process
>   * @indio_dev: iio_dev associated with the device that consumed the trigger
>   **/
> -static void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
> +static inline void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev)
>  {
>  }
>  


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-26 12:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 14:24 [PATCH] iio: trigger: Staticise stub functions Alexandru Ardelean
2020-07-18 16:25 ` Jonathan Cameron
2020-07-18 16:36   ` Lars-Peter Clausen
2020-07-18 17:10     ` Ardelean, Alexandru
2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
2020-07-26 12:43   ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.