[PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix

[PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix

[Jacopo Mondi]

I have added Rob's tag to patches [1/3] and [2/3].

I have added to patch [1/3] an entry for the yaml binding file to MAINTAINERS
and added a new patch which removes the existing maintainers of the driver,
as his email address bounces back, and replaced it with myself.

I hope this is not rude, but I have no way to contact Luis Oliveira and
ask him, and a bouncing email is not that helpful.

Dave, would you like to be added as maintainer as well, as this sensor
is the one used by the RPi Camera Module v1 ?

Thanks
  j

Jacopo Mondi (3):
  dt-bindings: media: ov5647: Convert to json-schema
  dt-bindings: media: i2c: Document 'remote-endpoint'
  media: MAINTAINERS: ov5647: Add myself as maintainer

 .../devicetree/bindings/media/i2c/imx219.yaml |  5 ++
 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 82 +++++++++++++++++++
 .../devicetree/bindings/media/i2c/ov8856.yaml |  5 ++
 MAINTAINERS                                   |  3 +-
 5 files changed, 94 insertions(+), 36 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

--
2.27.0

[PATCH v2 1/3] dt-bindings: media: ov5647: Convert to json-schema

[Jacopo Mondi]

Convert the ov5647 image sensor bindings to DT schema and add
the file entry to MAINTAINERS.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 82 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 3 files changed, 83 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
deleted file mode 100644
index 22e44945b661..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/ov5647.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Omnivision OV5647 raw image sensor
----------------------------------
-
-OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
-and CCI (I2C compatible) control bus.
-
-Required properties:
-
-- compatible		: "ovti,ov5647".
-- reg			: I2C slave address of the sensor.
-- clocks		: Reference to the xclk clock.
-
-The common video interfaces bindings (see video-interfaces.txt) should be
-used to specify link to the image data receiver. The OV5647 device
-node should contain one 'port' child node with an 'endpoint' subnode.
-
-Endpoint node mandatory properties:
-
-- remote-endpoint: A phandle to the bus receiver's endpoint node.
-
-Example:
-
-	i2c@2000 {
-		...
-		ov: camera@36 {
-			compatible = "ovti,ov5647";
-			reg = <0x36>;
-			clocks = <&camera_clk>;
-			port {
-				camera_1: endpoint {
-					remote-endpoint = <&csi1_ep1>;
-				};
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
new file mode 100644
index 000000000000..067e222e0c7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Omnivision OV5647 raw image sensor
+
+maintainers:
+  - Dave Stevenson <dave.stevenson@raspberrypi.com>
+
+description: |-
+  OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
+  and CCI (I2C compatible) control bus.
+
+properties:
+  compatible:
+    const: ovti,ov5647
+
+  reg:
+    description: I2C device address
+    maxItems: 1
+
+  clocks:
+    description: Reference to the xclk clock
+    maxItems: 1
+
+  port:
+    type: object
+    description: |-
+      Should contain one endpoint sub-node used to model connection to the
+      video receiver according to the specification defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt
+
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
+        required:
+          - remote-endpoint
+
+        additionalProperties: false
+
+    required:
+      - endpoint
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ov5647: camera@36 {
+            compatible = "ovti,ov5647";
+            reg = <0x36>;
+            clocks = <&camera_clk>;
+
+            port {
+                camera_out: endpoint {
+                    remote-endpoint = <&csi1_ep1>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 2730af1265ea..1742fa1a88cd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12612,6 +12612,7 @@ L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov5647.c
+F:	Documentation/devicetree/bindings/media/i2c/ov5647.yaml
 
 OMNIVISION OV5670 SENSOR DRIVER
 M:	Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
-- 
2.27.0

[PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Jacopo Mondi]

Document the 'remote-endpoint' property and add it to the list of required
endpoint properties in imx219 and ov8856 dt-schema binding files.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
 Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
index dfc4d29a4f04..0251e15fe0a7 100644
--- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
@@ -71,8 +71,13 @@ properties:
             description:
               Allowed data bus frequencies.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
         required:
           - link-frequencies
+          - remote-endpoint
 
 required:
   - compatible
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
index 1956b2a32bf4..c1f363bb5aee 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
@@ -84,9 +84,14 @@ properties:
               Allowed data bus frequencies. 360000000, 180000000 Hz or both
               are supported by the driver.
 
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port
+
 
         required:
           - link-frequencies
+          - remote-endpoint
 
     required:
       - endpoint
-- 
2.27.0

[PATCH v2 3/3] media: MAINTAINERS: ov5647: Add myself as maintainer

[Jacopo Mondi]

Since the current maintainer email address bounces back, replace
the entry and make myself maintainer of the driver since I have the
sensor and platforms to test it.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1742fa1a88cd..e2128afd83b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12607,7 +12607,7 @@ T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov5640.c
 
 OMNIVISION OV5647 SENSOR DRIVER
-M:	Luis Oliveira <lolivei@synopsys.com>
+M:	Jacopo Mondi <jacopo@jmondi.org>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-- 
2.27.0

Re: [PATCH v2 1/3] dt-bindings: media: ov5647: Convert to json-schema

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Jul 14, 2020 at 04:28:54PM +0200, Jacopo Mondi wrote:
> Convert the ov5647 image sensor bindings to DT schema and add
> the file entry to MAINTAINERS.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
>  .../devicetree/bindings/media/i2c/ov5647.yaml | 82 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  3 files changed, 83 insertions(+), 35 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
> deleted file mode 100644
> index 22e44945b661..000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/ov5647.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Omnivision OV5647 raw image sensor
> ----------------------------------
> -
> -OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
> -and CCI (I2C compatible) control bus.
> -
> -Required properties:
> -
> -- compatible		: "ovti,ov5647".
> -- reg			: I2C slave address of the sensor.
> -- clocks		: Reference to the xclk clock.
> -
> -The common video interfaces bindings (see video-interfaces.txt) should be
> -used to specify link to the image data receiver. The OV5647 device
> -node should contain one 'port' child node with an 'endpoint' subnode.
> -
> -Endpoint node mandatory properties:
> -
> -- remote-endpoint: A phandle to the bus receiver's endpoint node.
> -
> -Example:
> -
> -	i2c@2000 {
> -		...
> -		ov: camera@36 {
> -			compatible = "ovti,ov5647";
> -			reg = <0x36>;
> -			clocks = <&camera_clk>;
> -			port {
> -				camera_1: endpoint {
> -					remote-endpoint = <&csi1_ep1>;
> -				};
> -			};
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
> new file mode 100644
> index 000000000000..067e222e0c7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Omnivision OV5647 raw image sensor
> +
> +maintainers:
> +  - Dave Stevenson <dave.stevenson@raspberrypi.com>
> +
> +description: |-
> +  OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
> +  and CCI (I2C compatible) control bus.
> +
> +properties:
> +  compatible:
> +    const: ovti,ov5647
> +
> +  reg:
> +    description: I2C device address
> +    maxItems: 1
> +
> +  clocks:
> +    description: Reference to the xclk clock
> +    maxItems: 1
> +
> +  port:
> +    type: object
> +    description: |-
> +      Should contain one endpoint sub-node used to model connection to the
> +      video receiver according to the specification defined in
> +      Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +    properties:
> +      endpoint:
> +        type: object
> +
> +        properties:
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port
> +
> +        required:
> +          - remote-endpoint
> +
> +        additionalProperties: false
> +
> +    required:
> +      - endpoint

We usually make it valid for a port to contain no endpoint. This can be
used, for instance, to create a base DT that doesn't describe the
connections, where an overlay will then wire the components together.
I'd thus drop the required property here. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ov5647: camera@36 {
> +            compatible = "ovti,ov5647";
> +            reg = <0x36>;
> +            clocks = <&camera_clk>;
> +
> +            port {
> +                camera_out: endpoint {
> +                    remote-endpoint = <&csi1_ep1>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2730af1265ea..1742fa1a88cd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12612,6 +12612,7 @@ L:	linux-media@vger.kernel.org
>  S:	Maintained
>  T:	git git://linuxtv.org/media_tree.git
>  F:	drivers/media/i2c/ov5647.c
> +F:	Documentation/devicetree/bindings/media/i2c/ov5647.yaml
>  
>  OMNIVISION OV5670 SENSOR DRIVER
>  M:	Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote:
> Document the 'remote-endpoint' property and add it to the list of required
> endpoint properties in imx219 and ov8856 dt-schema binding files.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
>  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> index dfc4d29a4f04..0251e15fe0a7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> @@ -71,8 +71,13 @@ properties:
>              description:
>                Allowed data bus frequencies.
>  
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port
> +
>          required:
>            - link-frequencies
> +          - remote-endpoint
>  
>  required:
>    - compatible
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> index 1956b2a32bf4..c1f363bb5aee 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> @@ -84,9 +84,14 @@ properties:
>                Allowed data bus frequencies. 360000000, 180000000 Hz or both
>                are supported by the driver.
>  
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port
> +

Extraneous blank line ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>          required:
>            - link-frequencies
> +          - remote-endpoint
>  
>      required:
>        - endpoint

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 3/3] media: MAINTAINERS: ov5647: Add myself as maintainer

[Laurent Pinchart]

Hi Jacopo,

Thank you for the patch.

On Tue, Jul 14, 2020 at 04:28:56PM +0200, Jacopo Mondi wrote:
> Since the current maintainer email address bounces back, replace
> the entry and make myself maintainer of the driver since I have the
> sensor and platforms to test it.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

And thank you for stepping up :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1742fa1a88cd..e2128afd83b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12607,7 +12607,7 @@ T:	git git://linuxtv.org/media_tree.git
>  F:	drivers/media/i2c/ov5640.c
>  
>  OMNIVISION OV5647 SENSOR DRIVER
> -M:	Luis Oliveira <lolivei@synopsys.com>
> +M:	Jacopo Mondi <jacopo@jmondi.org>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  T:	git git://linuxtv.org/media_tree.git

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Jacopo Mondi]

Hi Laurent,

On Wed, Jul 15, 2020 at 02:45:35AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Jul 14, 2020 at 04:28:55PM +0200, Jacopo Mondi wrote:
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >  Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >              description:
> >                Allowed data bus frequencies.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >  required:
> >    - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                are supported by the driver.
> >
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
> > +
>
> Extraneous blank line ?
>

Yes indeed.

I'll fix and resend with your comments taken in (this and the one in
the previous patch).

Rob, Hans:
Should this go in through the media tree or through rob ?

Thanks
  j

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> >
> >          required:
> >            - link-frequencies
> > +          - remote-endpoint
> >
> >      required:
> >        - endpoint
>
> --
> Regards,
>
> Laurent Pinchart

Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Sergei Shtylyov]

Hello!

On 14.07.2020 17:28, Jacopo Mondi wrote:

> Document the 'remote-endpoint' property and add it to the list of required
> endpoint properties in imx219 and ov8856 dt-schema binding files.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>   Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
>   Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
>   2 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> index dfc4d29a4f04..0251e15fe0a7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> @@ -71,8 +71,13 @@ properties:
>               description:
>                 Allowed data bus frequencies.
>   
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port

    s/to/of/?

> +
>           required:
>             - link-frequencies
> +          - remote-endpoint
>   
>   required:
>     - compatible
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> index 1956b2a32bf4..c1f363bb5aee 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> @@ -84,9 +84,14 @@ properties:
>                 Allowed data bus frequencies. 360000000, 180000000 Hz or both
>                 are supported by the driver.
>   
> +          remote-endpoint:
> +            description: |-
> +              phandle to the video receiver input port

    s/to/of/?

[...]

MBR, Sergei

Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Jacopo Mondi]

Hi Sergei,

On Wed, Jul 15, 2020 at 11:10:15AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 14.07.2020 17:28, Jacopo Mondi wrote:
>
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >   Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >   Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >   2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >               description:
> >                 Allowed data bus frequencies.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?
>
> > +
> >           required:
> >             - link-frequencies
> > +          - remote-endpoint
> >   required:
> >     - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                 Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                 are supported by the driver.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?

I see both being used in the existing Documentation.
In the media/ folder it seems like "phandle to" is the only used
version, so I think I will go with that for consistency, unless this
is grammatically wrong and I didn't realize it :)

>
> [...]
>
> MBR, Sergei

Re: [PATCH v2 3/3] media: MAINTAINERS: ov5647: Add myself as maintainer

[Geert Uytterhoeven]

CC Luis' last used address

On Tue, Jul 14, 2020 at 4:25 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>
> Since the current maintainer email address bounces back, replace
> the entry and make myself maintainer of the driver since I have the
> sensor and platforms to test it.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1742fa1a88cd..e2128afd83b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12607,7 +12607,7 @@ T:      git git://linuxtv.org/media_tree.git
>  F:     drivers/media/i2c/ov5640.c
>
>  OMNIVISION OV5647 SENSOR DRIVER
> -M:     Luis Oliveira <lolivei@synopsys.com>
> +M:     Jacopo Mondi <jacopo@jmondi.org>
>  L:     linux-media@vger.kernel.org
>  S:     Maintained
>  T:     git git://linuxtv.org/media_tree.git

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 3/3] media: MAINTAINERS: ov5647: Add myself as maintainer

[Jacopo Mondi]

Hi Geert

On Wed, Jul 15, 2020 at 12:26:49PM +0200, Geert Uytterhoeven wrote:
> CC Luis' last used address
>
> On Tue, Jul 14, 2020 at 4:25 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> >
> > Since the current maintainer email address bounces back, replace
> > the entry and make myself maintainer of the driver since I have the
> > sensor and platforms to test it.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> >  MAINTAINERS | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1742fa1a88cd..e2128afd83b6 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12607,7 +12607,7 @@ T:      git git://linuxtv.org/media_tree.git
> >  F:     drivers/media/i2c/ov5640.c
> >
> >  OMNIVISION OV5647 SENSOR DRIVER
> > -M:     Luis Oliveira <lolivei@synopsys.com>
> > +M:     Jacopo Mondi <jacopo@jmondi.org>
> >  L:     linux-media@vger.kernel.org
> >  S:     Maintained
> >  T:     git git://linuxtv.org/media_tree.git

Oh thanks!

I would be happy if Luis would like to keep maintaing the driver and
just update his address in that case. I however volounteer to help here,
so please keep my address here as well.

Thanks
  j

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix

[Dave Stevenson]

Hi Jacopo

On Tue, 14 Jul 2020 at 15:25, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>
> I have added Rob's tag to patches [1/3] and [2/3].
>
> I have added to patch [1/3] an entry for the yaml binding file to MAINTAINERS
> and added a new patch which removes the existing maintainers of the driver,
> as his email address bounces back, and replaced it with myself.
>
> I hope this is not rude, but I have no way to contact Luis Oliveira and
> ask him, and a bouncing email is not that helpful.
>
> Dave, would you like to be added as maintainer as well, as this sensor
> is the one used by the RPi Camera Module v1 ?

I'm happy to be. I had said I would to Sakari when he went to orphan
it, but I didn't get around to sending the email (I've not set up git
send-email since recent changes to our email setup).

  Dave

> Thanks
>   j
>
> Jacopo Mondi (3):
>   dt-bindings: media: ov5647: Convert to json-schema
>   dt-bindings: media: i2c: Document 'remote-endpoint'
>   media: MAINTAINERS: ov5647: Add myself as maintainer
>
>  .../devicetree/bindings/media/i2c/imx219.yaml |  5 ++
>  .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
>  .../devicetree/bindings/media/i2c/ov5647.yaml | 82 +++++++++++++++++++
>  .../devicetree/bindings/media/i2c/ov8856.yaml |  5 ++
>  MAINTAINERS                                   |  3 +-
>  5 files changed, 94 insertions(+), 36 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml
>
> --
> 2.27.0
>

Re: [PATCH v2 0/3] dt-bidings: media: ov5647 bindings + small fix

[Jacopo Mondi]

Hi Dave,

On Wed, Jul 15, 2020 at 12:07:16PM +0100, Dave Stevenson wrote:
> Hi Jacopo
>
> On Tue, 14 Jul 2020 at 15:25, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> >
> > I have added Rob's tag to patches [1/3] and [2/3].
> >
> > I have added to patch [1/3] an entry for the yaml binding file to MAINTAINERS
> > and added a new patch which removes the existing maintainers of the driver,
> > as his email address bounces back, and replaced it with myself.
> >
> > I hope this is not rude, but I have no way to contact Luis Oliveira and
> > ask him, and a bouncing email is not that helpful.
> >
> > Dave, would you like to be added as maintainer as well, as this sensor
> > is the one used by the RPi Camera Module v1 ?
>
> I'm happy to be. I had said I would to Sakari when he went to orphan
> it, but I didn't get around to sending the email (I've not set up git
> send-email since recent changes to our email setup).

I'll then add your name there.

Thanks
  j

>
>   Dave
>
> > Thanks
> >   j
> >
> > Jacopo Mondi (3):
> >   dt-bindings: media: ov5647: Convert to json-schema
> >   dt-bindings: media: i2c: Document 'remote-endpoint'
> >   media: MAINTAINERS: ov5647: Add myself as maintainer
> >
> >  .../devicetree/bindings/media/i2c/imx219.yaml |  5 ++
> >  .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
> >  .../devicetree/bindings/media/i2c/ov5647.yaml | 82 +++++++++++++++++++
> >  .../devicetree/bindings/media/i2c/ov8856.yaml |  5 ++
> >  MAINTAINERS                                   |  3 +-
> >  5 files changed, 94 insertions(+), 36 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml
> >
> > --
> > 2.27.0
> >