From: kernel test robot <lkp@intel.com> To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org Cc: kbuild-all@lists.01.org, Nikolay Borisov <nborisov@suse.com> Subject: Re: [PATCH 2/5] btrfs: Factor out loop logic from btrfs_free_extra_devids Date: Wed, 15 Jul 2020 20:32:35 +0800 [thread overview] Message-ID: <202007152001.hk5XiQ7u%lkp@intel.com> (raw) In-Reply-To: <20200715104850.19071-3-nborisov@suse.com> [-- Attachment #1: Type: text/plain, Size: 3949 bytes --] Hi Nikolay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kdave/for-next] [also build test WARNING on v5.8-rc5 next-20200715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nikolay-Borisov/Convert-seed-devices-to-proper-list-API/20200715-185102 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from fs/btrfs/volumes.c:17: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/volumes.c:28: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ >> fs/btrfs/volumes.c:1029:6: warning: no previous prototype for '__btrfs_free_extra_devids' [-Wmissing-prototypes] 1029 | void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/__btrfs_free_extra_devids +1029 fs/btrfs/volumes.c 1026 1027 1028 > 1029 void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, 1030 struct btrfs_device **latest_dev) 1031 { 1032 struct btrfs_device *device, *next; 1033 1034 /* This is the initialized path, it is safe to release the devices. */ 1035 list_for_each_entry_safe(device, next, &fs_devices->devices, dev_list) { 1036 if (test_bit(BTRFS_DEV_STATE_IN_FS_METADATA, 1037 &device->dev_state)) { 1038 if (!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1039 &device->dev_state) && 1040 !test_bit(BTRFS_DEV_STATE_MISSING, 1041 &device->dev_state) && 1042 (!*latest_dev || 1043 device->generation > (*latest_dev)->generation)) { 1044 *latest_dev = device; 1045 } 1046 continue; 1047 } 1048 1049 if (device->devid == BTRFS_DEV_REPLACE_DEVID) { 1050 /* 1051 * In the first step, keep the device which has 1052 * the correct fsid and the devid that is used 1053 * for the dev_replace procedure. 1054 * In the second step, the dev_replace state is 1055 * read from the device tree and it is known 1056 * whether the procedure is really active or 1057 * not, which means whether this device is 1058 * used or whether it should be removed. 1059 */ 1060 if (step == 0 || test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1061 &device->dev_state)) { 1062 continue; 1063 } 1064 } 1065 if (device->bdev) { 1066 blkdev_put(device->bdev, device->mode); 1067 device->bdev = NULL; 1068 fs_devices->open_devices--; 1069 } 1070 if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state)) { 1071 list_del_init(&device->dev_alloc_list); 1072 clear_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state); 1073 if (!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1074 &device->dev_state)) 1075 fs_devices->rw_devices--; 1076 } 1077 list_del_init(&device->dev_list); 1078 fs_devices->num_devices--; 1079 btrfs_free_device(device); 1080 } 1081 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 50003 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/5] btrfs: Factor out loop logic from btrfs_free_extra_devids Date: Wed, 15 Jul 2020 20:32:35 +0800 [thread overview] Message-ID: <202007152001.hk5XiQ7u%lkp@intel.com> (raw) In-Reply-To: <20200715104850.19071-3-nborisov@suse.com> [-- Attachment #1: Type: text/plain, Size: 4048 bytes --] Hi Nikolay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kdave/for-next] [also build test WARNING on v5.8-rc5 next-20200715] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nikolay-Borisov/Convert-seed-devices-to-proper-list-API/20200715-185102 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): In file included from fs/btrfs/volumes.c:17: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/volumes.c:28: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ >> fs/btrfs/volumes.c:1029:6: warning: no previous prototype for '__btrfs_free_extra_devids' [-Wmissing-prototypes] 1029 | void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/__btrfs_free_extra_devids +1029 fs/btrfs/volumes.c 1026 1027 1028 > 1029 void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, 1030 struct btrfs_device **latest_dev) 1031 { 1032 struct btrfs_device *device, *next; 1033 1034 /* This is the initialized path, it is safe to release the devices. */ 1035 list_for_each_entry_safe(device, next, &fs_devices->devices, dev_list) { 1036 if (test_bit(BTRFS_DEV_STATE_IN_FS_METADATA, 1037 &device->dev_state)) { 1038 if (!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1039 &device->dev_state) && 1040 !test_bit(BTRFS_DEV_STATE_MISSING, 1041 &device->dev_state) && 1042 (!*latest_dev || 1043 device->generation > (*latest_dev)->generation)) { 1044 *latest_dev = device; 1045 } 1046 continue; 1047 } 1048 1049 if (device->devid == BTRFS_DEV_REPLACE_DEVID) { 1050 /* 1051 * In the first step, keep the device which has 1052 * the correct fsid and the devid that is used 1053 * for the dev_replace procedure. 1054 * In the second step, the dev_replace state is 1055 * read from the device tree and it is known 1056 * whether the procedure is really active or 1057 * not, which means whether this device is 1058 * used or whether it should be removed. 1059 */ 1060 if (step == 0 || test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1061 &device->dev_state)) { 1062 continue; 1063 } 1064 } 1065 if (device->bdev) { 1066 blkdev_put(device->bdev, device->mode); 1067 device->bdev = NULL; 1068 fs_devices->open_devices--; 1069 } 1070 if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state)) { 1071 list_del_init(&device->dev_alloc_list); 1072 clear_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state); 1073 if (!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, 1074 &device->dev_state)) 1075 fs_devices->rw_devices--; 1076 } 1077 list_del_init(&device->dev_list); 1078 fs_devices->num_devices--; 1079 btrfs_free_device(device); 1080 } 1081 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 50003 bytes --]
next prev parent reply other threads:[~2020-07-15 12:33 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-15 10:48 [PATCH 0/5] Convert seed devices to proper list API Nikolay Borisov 2020-07-15 10:48 ` [PATCH 1/5] btrfs: Factor out reada loop in __reada_start_machine Nikolay Borisov 2020-08-18 15:02 ` Josef Bacik 2020-08-29 15:06 ` Anand Jain 2020-08-31 12:24 ` David Sterba 2020-07-15 10:48 ` [PATCH 2/5] btrfs: Factor out loop logic from btrfs_free_extra_devids Nikolay Borisov 2020-07-15 12:32 ` kernel test robot [this message] 2020-07-15 12:32 ` kernel test robot 2020-07-15 12:39 ` Nikolay Borisov 2020-07-15 17:39 ` kernel test robot 2020-07-16 7:17 ` [PATCH v2] " Nikolay Borisov 2020-08-29 15:13 ` Anand Jain 2020-08-18 15:03 ` [PATCH 2/5] " Josef Bacik 2020-07-15 10:48 ` [PATCH 3/5] btrfs: Make close_fs_devices return void Nikolay Borisov 2020-08-18 15:05 ` Josef Bacik 2020-08-29 15:14 ` Anand Jain 2020-07-15 10:48 ` [PATCH 4/5] btrfs: Simplify setting/clearing fs_info to btrfs_fs_devices Nikolay Borisov 2020-08-18 15:08 ` Josef Bacik 2020-08-26 10:50 ` Anand Jain 2020-07-15 10:48 ` [PATCH 5/5] btrfs: Switch seed device to list api Nikolay Borisov 2020-07-15 13:14 ` kernel test robot 2020-07-15 13:14 ` kernel test robot 2020-07-15 19:11 ` kernel test robot 2020-07-16 7:25 ` [PATCH v2] " Nikolay Borisov 2020-08-18 15:19 ` Josef Bacik 2020-08-30 14:39 ` Anand Jain 2020-07-24 7:36 ` [PATCH 5/5] " Nikolay Borisov 2020-09-02 15:58 ` Anand Jain 2020-09-03 9:03 ` Nikolay Borisov 2020-09-03 9:33 ` Anand Jain 2020-09-10 16:28 ` David Sterba 2020-07-22 14:26 ` [PATCH 0/5] Convert seed devices to proper list API David Sterba 2020-07-23 8:02 ` Nikolay Borisov 2020-08-21 14:33 ` David Sterba 2020-08-17 19:19 ` Nikolay Borisov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202007152001.hk5XiQ7u%lkp@intel.com \ --to=lkp@intel.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=nborisov@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.