From: kernel test robot <lkp@intel.com> To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org Cc: kbuild-all@lists.01.org, Nikolay Borisov <nborisov@suse.com> Subject: Re: [PATCH 5/5] btrfs: Switch seed device to list api Date: Wed, 15 Jul 2020 21:14:06 +0800 [thread overview] Message-ID: <202007152133.RIB0prjk%lkp@intel.com> (raw) In-Reply-To: <20200715104850.19071-6-nborisov@suse.com> [-- Attachment #1: Type: text/plain, Size: 5808 bytes --] Hi Nikolay, Thank you for the patch! Yet something to improve: [auto build test ERROR on kdave/for-next] [also build test ERROR on next-20200715] [cannot apply to v5.8-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nikolay-Borisov/Convert-seed-devices-to-proper-list-API/20200715-185102 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): In file included from fs/btrfs/volumes.c:17: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/volumes.c:28: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ fs/btrfs/volumes.c:1030:6: warning: no previous prototype for '__btrfs_free_extra_devids' [-Wmissing-prototypes] 1030 | void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/volumes.c: In function 'btrfs_rm_dev_replace_free_srcdev': >> fs/btrfs/volumes.c:2219:28: warning: variable 'tmp_fs_devices' set but not used [-Wunused-but-set-variable] 2219 | struct btrfs_fs_devices *tmp_fs_devices; | ^~~~~~~~~~~~~~ -- In file included from fs/btrfs/delayed-inode.h:17, from fs/btrfs/super.c:30: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/super.c:46: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ fs/btrfs/super.c: In function 'btrfs_show_devname': >> fs/btrfs/super.c:2404:28: error: 'struct btrfs_fs_devices' has no member named 'seed' 2404 | cur_devices = cur_devices->seed; | ^~ vim +2404 fs/btrfs/super.c 9e7cc91a6d18a4 Wang Xiaoguang 2016-08-01 2377 9c5085c147989d Josef Bacik 2012-06-05 2378 static int btrfs_show_devname(struct seq_file *m, struct dentry *root) 9c5085c147989d Josef Bacik 2012-06-05 2379 { 9c5085c147989d Josef Bacik 2012-06-05 2380 struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb); 9c5085c147989d Josef Bacik 2012-06-05 2381 struct btrfs_fs_devices *cur_devices; 9c5085c147989d Josef Bacik 2012-06-05 2382 struct btrfs_device *dev, *first_dev = NULL; 9c5085c147989d Josef Bacik 2012-06-05 2383 struct list_head *head; 9c5085c147989d Josef Bacik 2012-06-05 2384 88c14590cdd6f3 David Sterba 2018-03-16 2385 /* 88c14590cdd6f3 David Sterba 2018-03-16 2386 * Lightweight locking of the devices. We should not need 88c14590cdd6f3 David Sterba 2018-03-16 2387 * device_list_mutex here as we only read the device data and the list 88c14590cdd6f3 David Sterba 2018-03-16 2388 * is protected by RCU. Even if a device is deleted during the list 88c14590cdd6f3 David Sterba 2018-03-16 2389 * traversals, we'll get valid data, the freeing callback will wait at 52042d8e82ff50 Andrea Gelmini 2018-11-28 2390 * least until the rcu_read_unlock. 88c14590cdd6f3 David Sterba 2018-03-16 2391 */ 88c14590cdd6f3 David Sterba 2018-03-16 2392 rcu_read_lock(); 9c5085c147989d Josef Bacik 2012-06-05 2393 cur_devices = fs_info->fs_devices; 9c5085c147989d Josef Bacik 2012-06-05 2394 while (cur_devices) { 9c5085c147989d Josef Bacik 2012-06-05 2395 head = &cur_devices->devices; 88c14590cdd6f3 David Sterba 2018-03-16 2396 list_for_each_entry_rcu(dev, head, dev_list) { e6e674bd4d54fe Anand Jain 2017-12-04 2397 if (test_bit(BTRFS_DEV_STATE_MISSING, &dev->dev_state)) aa9ddcd4b55571 Josef Bacik 2012-08-02 2398 continue; 0aeb8a6e67cdde Anand Jain 2014-06-30 2399 if (!dev->name) 0aeb8a6e67cdde Anand Jain 2014-06-30 2400 continue; 9c5085c147989d Josef Bacik 2012-06-05 2401 if (!first_dev || dev->devid < first_dev->devid) 9c5085c147989d Josef Bacik 2012-06-05 2402 first_dev = dev; 9c5085c147989d Josef Bacik 2012-06-05 2403 } 9c5085c147989d Josef Bacik 2012-06-05 @2404 cur_devices = cur_devices->seed; 9c5085c147989d Josef Bacik 2012-06-05 2405 } 9c5085c147989d Josef Bacik 2012-06-05 2406 672d599041c862 Misono Tomohiro 2018-08-02 2407 if (first_dev) 672d599041c862 Misono Tomohiro 2018-08-02 2408 seq_escape(m, rcu_str_deref(first_dev->name), " \t\n\\"); 672d599041c862 Misono Tomohiro 2018-08-02 2409 else 9c5085c147989d Josef Bacik 2012-06-05 2410 WARN_ON(1); 88c14590cdd6f3 David Sterba 2018-03-16 2411 rcu_read_unlock(); 9c5085c147989d Josef Bacik 2012-06-05 2412 return 0; 9c5085c147989d Josef Bacik 2012-06-05 2413 } 9c5085c147989d Josef Bacik 2012-06-05 2414 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 50003 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 5/5] btrfs: Switch seed device to list api Date: Wed, 15 Jul 2020 21:14:06 +0800 [thread overview] Message-ID: <202007152133.RIB0prjk%lkp@intel.com> (raw) In-Reply-To: <20200715104850.19071-6-nborisov@suse.com> [-- Attachment #1: Type: text/plain, Size: 5908 bytes --] Hi Nikolay, Thank you for the patch! Yet something to improve: [auto build test ERROR on kdave/for-next] [also build test ERROR on next-20200715] [cannot apply to v5.8-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nikolay-Borisov/Convert-seed-devices-to-proper-list-API/20200715-185102 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-rhel-7.6-kselftests (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): In file included from fs/btrfs/volumes.c:17: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/volumes.c:28: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ fs/btrfs/volumes.c:1030:6: warning: no previous prototype for '__btrfs_free_extra_devids' [-Wmissing-prototypes] 1030 | void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices, int step, | ^~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/volumes.c: In function 'btrfs_rm_dev_replace_free_srcdev': >> fs/btrfs/volumes.c:2219:28: warning: variable 'tmp_fs_devices' set but not used [-Wunused-but-set-variable] 2219 | struct btrfs_fs_devices *tmp_fs_devices; | ^~~~~~~~~~~~~~ -- In file included from fs/btrfs/delayed-inode.h:17, from fs/btrfs/super.c:30: fs/btrfs/ctree.h:2271:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 2271 | size_t __const btrfs_get_num_csums(void); | ^~~~~~~ In file included from fs/btrfs/super.c:46: fs/btrfs/sysfs.h:16:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] 16 | const char * const btrfs_feature_set_name(enum btrfs_feature_set set); | ^~~~~ fs/btrfs/super.c: In function 'btrfs_show_devname': >> fs/btrfs/super.c:2404:28: error: 'struct btrfs_fs_devices' has no member named 'seed' 2404 | cur_devices = cur_devices->seed; | ^~ vim +2404 fs/btrfs/super.c 9e7cc91a6d18a4 Wang Xiaoguang 2016-08-01 2377 9c5085c147989d Josef Bacik 2012-06-05 2378 static int btrfs_show_devname(struct seq_file *m, struct dentry *root) 9c5085c147989d Josef Bacik 2012-06-05 2379 { 9c5085c147989d Josef Bacik 2012-06-05 2380 struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb); 9c5085c147989d Josef Bacik 2012-06-05 2381 struct btrfs_fs_devices *cur_devices; 9c5085c147989d Josef Bacik 2012-06-05 2382 struct btrfs_device *dev, *first_dev = NULL; 9c5085c147989d Josef Bacik 2012-06-05 2383 struct list_head *head; 9c5085c147989d Josef Bacik 2012-06-05 2384 88c14590cdd6f3 David Sterba 2018-03-16 2385 /* 88c14590cdd6f3 David Sterba 2018-03-16 2386 * Lightweight locking of the devices. We should not need 88c14590cdd6f3 David Sterba 2018-03-16 2387 * device_list_mutex here as we only read the device data and the list 88c14590cdd6f3 David Sterba 2018-03-16 2388 * is protected by RCU. Even if a device is deleted during the list 88c14590cdd6f3 David Sterba 2018-03-16 2389 * traversals, we'll get valid data, the freeing callback will wait at 52042d8e82ff50 Andrea Gelmini 2018-11-28 2390 * least until the rcu_read_unlock. 88c14590cdd6f3 David Sterba 2018-03-16 2391 */ 88c14590cdd6f3 David Sterba 2018-03-16 2392 rcu_read_lock(); 9c5085c147989d Josef Bacik 2012-06-05 2393 cur_devices = fs_info->fs_devices; 9c5085c147989d Josef Bacik 2012-06-05 2394 while (cur_devices) { 9c5085c147989d Josef Bacik 2012-06-05 2395 head = &cur_devices->devices; 88c14590cdd6f3 David Sterba 2018-03-16 2396 list_for_each_entry_rcu(dev, head, dev_list) { e6e674bd4d54fe Anand Jain 2017-12-04 2397 if (test_bit(BTRFS_DEV_STATE_MISSING, &dev->dev_state)) aa9ddcd4b55571 Josef Bacik 2012-08-02 2398 continue; 0aeb8a6e67cdde Anand Jain 2014-06-30 2399 if (!dev->name) 0aeb8a6e67cdde Anand Jain 2014-06-30 2400 continue; 9c5085c147989d Josef Bacik 2012-06-05 2401 if (!first_dev || dev->devid < first_dev->devid) 9c5085c147989d Josef Bacik 2012-06-05 2402 first_dev = dev; 9c5085c147989d Josef Bacik 2012-06-05 2403 } 9c5085c147989d Josef Bacik 2012-06-05 @2404 cur_devices = cur_devices->seed; 9c5085c147989d Josef Bacik 2012-06-05 2405 } 9c5085c147989d Josef Bacik 2012-06-05 2406 672d599041c862 Misono Tomohiro 2018-08-02 2407 if (first_dev) 672d599041c862 Misono Tomohiro 2018-08-02 2408 seq_escape(m, rcu_str_deref(first_dev->name), " \t\n\\"); 672d599041c862 Misono Tomohiro 2018-08-02 2409 else 9c5085c147989d Josef Bacik 2012-06-05 2410 WARN_ON(1); 88c14590cdd6f3 David Sterba 2018-03-16 2411 rcu_read_unlock(); 9c5085c147989d Josef Bacik 2012-06-05 2412 return 0; 9c5085c147989d Josef Bacik 2012-06-05 2413 } 9c5085c147989d Josef Bacik 2012-06-05 2414 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 50003 bytes --]
next prev parent reply other threads:[~2020-07-15 13:23 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-15 10:48 [PATCH 0/5] Convert seed devices to proper list API Nikolay Borisov 2020-07-15 10:48 ` [PATCH 1/5] btrfs: Factor out reada loop in __reada_start_machine Nikolay Borisov 2020-08-18 15:02 ` Josef Bacik 2020-08-29 15:06 ` Anand Jain 2020-08-31 12:24 ` David Sterba 2020-07-15 10:48 ` [PATCH 2/5] btrfs: Factor out loop logic from btrfs_free_extra_devids Nikolay Borisov 2020-07-15 12:32 ` kernel test robot 2020-07-15 12:32 ` kernel test robot 2020-07-15 12:39 ` Nikolay Borisov 2020-07-15 17:39 ` kernel test robot 2020-07-16 7:17 ` [PATCH v2] " Nikolay Borisov 2020-08-29 15:13 ` Anand Jain 2020-08-18 15:03 ` [PATCH 2/5] " Josef Bacik 2020-07-15 10:48 ` [PATCH 3/5] btrfs: Make close_fs_devices return void Nikolay Borisov 2020-08-18 15:05 ` Josef Bacik 2020-08-29 15:14 ` Anand Jain 2020-07-15 10:48 ` [PATCH 4/5] btrfs: Simplify setting/clearing fs_info to btrfs_fs_devices Nikolay Borisov 2020-08-18 15:08 ` Josef Bacik 2020-08-26 10:50 ` Anand Jain 2020-07-15 10:48 ` [PATCH 5/5] btrfs: Switch seed device to list api Nikolay Borisov 2020-07-15 13:14 ` kernel test robot [this message] 2020-07-15 13:14 ` kernel test robot 2020-07-15 19:11 ` kernel test robot 2020-07-16 7:25 ` [PATCH v2] " Nikolay Borisov 2020-08-18 15:19 ` Josef Bacik 2020-08-30 14:39 ` Anand Jain 2020-07-24 7:36 ` [PATCH 5/5] " Nikolay Borisov 2020-09-02 15:58 ` Anand Jain 2020-09-03 9:03 ` Nikolay Borisov 2020-09-03 9:33 ` Anand Jain 2020-09-10 16:28 ` David Sterba 2020-07-22 14:26 ` [PATCH 0/5] Convert seed devices to proper list API David Sterba 2020-07-23 8:02 ` Nikolay Borisov 2020-08-21 14:33 ` David Sterba 2020-08-17 19:19 ` Nikolay Borisov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202007152133.RIB0prjk%lkp@intel.com \ --to=lkp@intel.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=nborisov@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.