* [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
@ 2020-07-16 22:00 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-16 22:00 UTC (permalink / raw)
To: Baruch Siach
Cc: linux-i2c, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/i2c/busses/i2c-digicolor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
index 332f00437479..f67639dc74b7 100644
--- a/drivers/i2c/busses/i2c-digicolor.c
+++ b/drivers/i2c/busses/i2c-digicolor.c
@@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
break;
}
i2c->state = STATE_WRITE;
- /* fall through */
+ fallthrough;
case STATE_WRITE:
if (i2c->msgbuf_ptr < i2c->msg->len)
dc_i2c_write_buf(i2c);
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
@ 2020-07-16 22:00 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-16 22:00 UTC (permalink / raw)
To: Baruch Siach
Cc: Gustavo A. R. Silva, linux-i2c, linux-arm-kernel, linux-kernel
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/i2c/busses/i2c-digicolor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
index 332f00437479..f67639dc74b7 100644
--- a/drivers/i2c/busses/i2c-digicolor.c
+++ b/drivers/i2c/busses/i2c-digicolor.c
@@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
break;
}
i2c->state = STATE_WRITE;
- /* fall through */
+ fallthrough;
case STATE_WRITE:
if (i2c->msgbuf_ptr < i2c->msg->len)
dc_i2c_write_buf(i2c);
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
2020-07-16 22:00 ` Gustavo A. R. Silva
@ 2020-07-17 4:38 ` Baruch Siach
-1 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2020-07-17 4:38 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-i2c, linux-arm-kernel, linux-kernel, Gustavo A. R. Silva
Hi Gustavo,
On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
This URL is likely to break at some point as documentation contest changes.
Just refer to in kernel Documentation/process/deprecated.rst file.
Other than that:
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/i2c/busses/i2c-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
> index 332f00437479..f67639dc74b7 100644
> --- a/drivers/i2c/busses/i2c-digicolor.c
> +++ b/drivers/i2c/busses/i2c-digicolor.c
> @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
> break;
> }
> i2c->state = STATE_WRITE;
> - /* fall through */
> + fallthrough;
> case STATE_WRITE:
> if (i2c->msgbuf_ptr < i2c->msg->len)
> dc_i2c_write_buf(i2c);
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
@ 2020-07-17 4:38 ` Baruch Siach
0 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2020-07-17 4:38 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Gustavo A. R. Silva, linux-i2c, linux-arm-kernel, linux-kernel
Hi Gustavo,
On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
This URL is likely to break at some point as documentation contest changes.
Just refer to in kernel Documentation/process/deprecated.rst file.
Other than that:
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/i2c/busses/i2c-digicolor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
> index 332f00437479..f67639dc74b7 100644
> --- a/drivers/i2c/busses/i2c-digicolor.c
> +++ b/drivers/i2c/busses/i2c-digicolor.c
> @@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
> break;
> }
> i2c->state = STATE_WRITE;
> - /* fall through */
> + fallthrough;
> case STATE_WRITE:
> if (i2c->msgbuf_ptr < i2c->msg->len)
> dc_i2c_write_buf(i2c);
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
2020-07-17 4:38 ` Baruch Siach
@ 2020-07-21 23:00 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-21 23:00 UTC (permalink / raw)
To: Baruch Siach, Gustavo A. R. Silva
Cc: linux-i2c, linux-arm-kernel, linux-kernel
Hi Baruch,
On 7/16/20 23:38, Baruch Siach wrote:
> Hi Gustavo,
>
> On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1].
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> This URL is likely to break at some point as documentation contest changes.
> Just refer to in kernel Documentation/process/deprecated.rst file.
>
You're right. Helpdesk just generated the proper doc for v5.7:
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> Other than that:
>
> Acked-by: Baruch Siach <baruch@tkos.co.il>
>
I'll send v2 with the URL above and your Acked-by, shortly.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword
@ 2020-07-21 23:00 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-21 23:00 UTC (permalink / raw)
To: Baruch Siach, Gustavo A. R. Silva
Cc: linux-i2c, linux-arm-kernel, linux-kernel
Hi Baruch,
On 7/16/20 23:38, Baruch Siach wrote:
> Hi Gustavo,
>
> On Thu, Jul 16, 2020 at 05:00:55PM -0500, Gustavo A. R. Silva wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1].
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> This URL is likely to break at some point as documentation contest changes.
> Just refer to in kernel Documentation/process/deprecated.rst file.
>
You're right. Helpdesk just generated the proper doc for v5.7:
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> Other than that:
>
> Acked-by: Baruch Siach <baruch@tkos.co.il>
>
I'll send v2 with the URL above and your Acked-by, shortly.
Thanks
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-21 23:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 22:00 [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-16 22:00 ` Gustavo A. R. Silva
2020-07-17 4:38 ` Baruch Siach
2020-07-17 4:38 ` Baruch Siach
2020-07-21 23:00 ` Gustavo A. R. Silva
2020-07-21 23:00 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.