All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz,
	devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition
Date: Mon, 20 Jul 2020 11:54:09 +0200	[thread overview]
Message-ID: <20200720095409.GA13137@amd> (raw)
In-Reply-To: <20200716182007.18389-2-dmurphy@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

Hi!

> Introduce a multicolor class that groups colored LEDs
> within a LED node.
> 
> The multicolor class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via the intensity file and the latter is controlled
> via brightness file.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Thanks, applied and pushed out.

> +====================================
> +MultiColor LED handling under Linux
> +====================================
...
> +Multicolor Class Control
> +========================

AFAICT The first one should be "Multicolor" for consistency.

> +config LEDS_CLASS_MULTICOLOR
> +	tristate "LED MultiColor Class Support"

Here too.

Can you send a followup patch to fix it up?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	marek.behun@nic.cz, jacek.anaszewski@gmail.com,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition
Date: Mon, 20 Jul 2020 11:54:09 +0200	[thread overview]
Message-ID: <20200720095409.GA13137@amd> (raw)
In-Reply-To: <20200716182007.18389-2-dmurphy@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]

Hi!

> Introduce a multicolor class that groups colored LEDs
> within a LED node.
> 
> The multicolor class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via the intensity file and the latter is controlled
> via brightness file.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Thanks, applied and pushed out.

> +====================================
> +MultiColor LED handling under Linux
> +====================================
...
> +Multicolor Class Control
> +========================

AFAICT The first one should be "Multicolor" for consistency.

> +config LEDS_CLASS_MULTICOLOR
> +	tristate "LED MultiColor Class Support"

Here too.

Can you send a followup patch to fix it up?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-20  9:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 18:19 [PATCH v31 00/12] Multicolor Framework v31 Dan Murphy
2020-07-16 18:19 ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-07-16 18:19   ` Dan Murphy
2020-07-20  9:54   ` Pavel Machek [this message]
2020-07-20  9:54     ` Pavel Machek
2020-07-20 12:07     ` Dan Murphy
2020-07-20 12:07       ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 02/12] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-16 18:19   ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-07-16 18:19   ` Dan Murphy
2020-07-21 21:05   ` Pavel Machek
2020-07-21 21:05     ` Pavel Machek
2020-07-22  0:04     ` Dan Murphy
2020-07-22  0:04       ` Dan Murphy
2020-07-22  7:10       ` Pavel Machek
2020-07-22  7:10         ` Pavel Machek
2020-07-22 12:26         ` Dan Murphy
2020-07-22 12:26           ` Dan Murphy
2020-07-22 12:39           ` Pavel Machek
2020-07-22 12:39             ` Pavel Machek
2020-07-21 21:07   ` Pavel Machek
2020-07-21 21:07     ` Pavel Machek
2020-07-22  0:05     ` Dan Murphy
2020-07-22  0:05       ` Dan Murphy
2020-07-16 18:19 ` [PATCH v31 04/12] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-07-16 18:19   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 05/12] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 06/12] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-21 21:11   ` Pavel Machek
2020-07-21 21:11     ` Pavel Machek
2020-07-22 16:40     ` Dan Murphy
2020-07-22 16:40       ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 07/12] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 08/12] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 09/12] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 10/12] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 11/12] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-07-16 18:20   ` Dan Murphy
2020-07-16 18:20 ` [PATCH v31 12/12] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-07-16 18:20   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720095409.GA13137@amd \
    --to=pavel@ucw.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.