From: Andrew Lunn <andrew@lunn.ch>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com,
claudiu.beznea@microchip.com, davem@davemloft.net,
kuba@kernel.org, f.fainelli@gmail.com, robh+dt@kernel.org,
alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com
Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node
Date: Tue, 21 Jul 2020 15:36:55 +0200 [thread overview]
Message-ID: <20200721133655.GA1472201@lunn.ch> (raw)
In-Reply-To: <20200721100234.1302910-4-codrin.ciubotariu@microchip.com>
> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
> * decrement it before returning.
> */
> of_node_put(child);
> -
> return of_mdiobus_register(bp->mii_bus, np);
> }
Please avoid white space changes like this.
Otherwise this looks O.K.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
f.fainelli@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ludovic.desroches@microchip.com, robh+dt@kernel.org,
kuba@kernel.org, claudiu.beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node
Date: Tue, 21 Jul 2020 15:36:55 +0200 [thread overview]
Message-ID: <20200721133655.GA1472201@lunn.ch> (raw)
In-Reply-To: <20200721100234.1302910-4-codrin.ciubotariu@microchip.com>
> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
> * decrement it before returning.
> */
> of_node_put(child);
> -
> return of_mdiobus_register(bp->mii_bus, np);
> }
Please avoid white space changes like this.
Otherwise this looks O.K.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-21 13:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:02 [PATCH net-next 0/7] Add an MDIO sub-node under MACB Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 1/7] net: macb: use device-managed devm_mdiobus_alloc() Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 2/7] macb: bindings doc: use an MDIO node as a container for PHY nodes Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 13:29 ` Alexandre Belloni
2020-07-21 13:29 ` Alexandre Belloni
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 13:36 ` Andrew Lunn [this message]
2020-07-21 13:36 ` Andrew Lunn
2020-07-21 13:40 ` Codrin.Ciubotariu
2020-07-21 13:40 ` Codrin.Ciubotariu
2020-07-21 13:42 ` Codrin.Ciubotariu
2020-07-21 13:42 ` Codrin.Ciubotariu
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 4/7] ARM: dts: at91: sama5d2: add an mdio sub-node to macb Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 5/7] ARM: dts: at91: sama5d3: " Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 6/7] ARM: dts: at91: sama5d4: " Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 7/7] ARM: dts: at91: sam9x60: " Codrin Ciubotariu
2020-07-21 10:02 ` Codrin Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721133655.GA1472201@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.