From: Mauro Carvalho Chehab <mchehab@kernel.org> To: Rahul Gottipati <rahul.blr97@gmail.com> Cc: sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: atomisp: Fix coding style issue - correct multiline comments Date: Wed, 22 Jul 2020 16:05:26 +0200 [thread overview] Message-ID: <20200722160526.5b83341e@coco.lan> (raw) In-Reply-To: <c73ee9bced34777cea5b1a3a97f57c723b0a97b1.1595416585.git.rahul.blr97@gmail.com> Em Wed, 22 Jul 2020 17:00:52 +0530 Rahul Gottipati <rahul.blr97@gmail.com> escreveu: > This fixes some coding style issues of multiline comments to > correct a few checkpatch.pl warnings. > > Signed-off-by: Rahul Gottipati <rahul.blr97@gmail.com> > --- > Changes in v2: > Distributed changes across 2 patches instead of the previous 1. > drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > index 9cdcbe774229..5bf3a86f98f8 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > @@ -1281,7 +1281,8 @@ static int atomisp_qbuf(struct file *file, void *fh, struct v4l2_buffer *buf) > * But the capture number cannot be determined by HAL. > * So HAL only sets the capture number to be 1 and queue multiple > * buffers. Atomisp driver needs to check this case and re-trigger > - * CSS to do capture when new buffer is queued. */ > + * CSS to do capture when new buffer is queued. > + */ > if (asd->continuous_mode->val && > atomisp_subdev_source_pad(vdev) > == ATOMISP_SUBDEV_PAD_SOURCE_CAPTURE && > @@ -1806,7 +1807,7 @@ static int atomisp_streamon(struct file *file, void *fh, > /* > * set freq to max when streaming count > 1 which indicate > * dual camera would run > - */ > + */ > if (atomisp_streaming_count(isp) > 1) { > if (atomisp_freq_scaling(isp, > ATOMISP_DFS_MODE_MAX, false) < 0) > @@ -2438,7 +2439,8 @@ static int atomisp_g_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ On media (and on several subsystems), we keep the first line in blank, on multi-line comments: /* * input_lock is not need for the Camera related IOCTLs * The input_lock downgrade the FPS of 3A */ > ret = atomisp_camera_g_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; > @@ -2521,7 +2523,8 @@ static int atomisp_camera_s_ext_ctrls(struct file *file, void *fh, > v4l2_s_ctrl(NULL, isp->flash->ctrl_handler, > &ctrl); > /* When flash mode is changed we need to reset > - * flash state */ > + * flash state > + */ > if (ctrl.id == V4L2_CID_FLASH_MODE) { > asd->params.flash_state = > ATOMISP_FLASH_IDLE; > @@ -2560,7 +2563,8 @@ static int atomisp_s_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ > ret = atomisp_camera_s_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; Thanks, Mauro
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@kernel.org> To: Rahul Gottipati <rahul.blr97@gmail.com> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: atomisp: Fix coding style issue - correct multiline comments Date: Wed, 22 Jul 2020 16:05:26 +0200 [thread overview] Message-ID: <20200722160526.5b83341e@coco.lan> (raw) In-Reply-To: <c73ee9bced34777cea5b1a3a97f57c723b0a97b1.1595416585.git.rahul.blr97@gmail.com> Em Wed, 22 Jul 2020 17:00:52 +0530 Rahul Gottipati <rahul.blr97@gmail.com> escreveu: > This fixes some coding style issues of multiline comments to > correct a few checkpatch.pl warnings. > > Signed-off-by: Rahul Gottipati <rahul.blr97@gmail.com> > --- > Changes in v2: > Distributed changes across 2 patches instead of the previous 1. > drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > index 9cdcbe774229..5bf3a86f98f8 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > @@ -1281,7 +1281,8 @@ static int atomisp_qbuf(struct file *file, void *fh, struct v4l2_buffer *buf) > * But the capture number cannot be determined by HAL. > * So HAL only sets the capture number to be 1 and queue multiple > * buffers. Atomisp driver needs to check this case and re-trigger > - * CSS to do capture when new buffer is queued. */ > + * CSS to do capture when new buffer is queued. > + */ > if (asd->continuous_mode->val && > atomisp_subdev_source_pad(vdev) > == ATOMISP_SUBDEV_PAD_SOURCE_CAPTURE && > @@ -1806,7 +1807,7 @@ static int atomisp_streamon(struct file *file, void *fh, > /* > * set freq to max when streaming count > 1 which indicate > * dual camera would run > - */ > + */ > if (atomisp_streaming_count(isp) > 1) { > if (atomisp_freq_scaling(isp, > ATOMISP_DFS_MODE_MAX, false) < 0) > @@ -2438,7 +2439,8 @@ static int atomisp_g_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ On media (and on several subsystems), we keep the first line in blank, on multi-line comments: /* * input_lock is not need for the Camera related IOCTLs * The input_lock downgrade the FPS of 3A */ > ret = atomisp_camera_g_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; > @@ -2521,7 +2523,8 @@ static int atomisp_camera_s_ext_ctrls(struct file *file, void *fh, > v4l2_s_ctrl(NULL, isp->flash->ctrl_handler, > &ctrl); > /* When flash mode is changed we need to reset > - * flash state */ > + * flash state > + */ > if (ctrl.id == V4L2_CID_FLASH_MODE) { > asd->params.flash_state = > ATOMISP_FLASH_IDLE; > @@ -2560,7 +2563,8 @@ static int atomisp_s_ext_ctrls(struct file *file, void *fh, > int i, ret = 0; > > /* input_lock is not need for the Camera related IOCTLs > - * The input_lock downgrade the FPS of 3A*/ > + * The input_lock downgrade the FPS of 3A > + */ > ret = atomisp_camera_s_ext_ctrls(file, fh, c); > if (ret != -EINVAL) > return ret; Thanks, Mauro _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-22 14:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 11:24 [PATCH v2 0/2] General coding style clean up Rahul Gottipati 2020-07-22 11:24 ` Rahul Gottipati 2020-07-22 11:28 ` [PATCH v2 1/2] media: atomisp: Fix coding style issue - remove beginning whitespaces Rahul Gottipati 2020-07-22 11:28 ` Rahul Gottipati 2020-07-22 14:03 ` Mauro Carvalho Chehab 2020-07-22 14:03 ` Mauro Carvalho Chehab 2020-07-22 11:30 ` [PATCH v2 2/2] media: atomisp: Fix coding style issue - correct multiline comments Rahul Gottipati 2020-07-22 11:30 ` Rahul Gottipati 2020-07-22 14:05 ` Mauro Carvalho Chehab [this message] 2020-07-22 14:05 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200722160526.5b83341e@coco.lan \ --to=mchehab@kernel.org \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=rahul.blr97@gmail.com \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.