From: Rob Herring <robh@kernel.org> To: miguelborgesdefreitas@gmail.com Cc: a.zummo@towertech.it, baruch@tkos.co.il, linux@armlinux.org.uk, alexandre.belloni@bootlin.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over Date: Thu, 23 Jul 2020 11:49:05 -0600 [thread overview] Message-ID: <20200723174905.GA596242@bogus> (raw) In-Reply-To: <20200720112401.4620-2-miguelborgesdefreitas@gmail.com> On Mon, Jul 20, 2020 at 12:23:59PM +0100, miguelborgesdefreitas@gmail.com wrote: > From: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com> > > This adds direct-switching mode as a configurable DT flag for > RTC modules supporting it (e.g. nxp pcf8523). > DSM switches the power source to the battery supply whenever the > VDD drops below VBAT. The option is recommended for hw designs > where VDD is always expected to be higher than VBAT. > > Signed-off-by: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com> > --- > Changes in v2: > - Added extended commit message for git history > - Separate dt bindings documentation into a single patch > > Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 7 ++++++- > Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > index 0b1080c..f715a8f 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > @@ -4,10 +4,14 @@ Required properties: > - compatible: Should contain "nxp,pcf8523". > - reg: I2C address for chip. > > -Optional property: > +Optional properties: > - quartz-load-femtofarads: The capacitive load of the quartz(x-tal), > expressed in femto Farad (fF). Valid values are 7000 and 12500. > Default value (if no value is specified) is 12500fF. > +- pm-enable-dsm: battery switch-over function is enabled in direct > + switching mode. The power failure condition happens when VDD < VBAT, > + without requiring VDD to drop below Vth(sw)bat. > + Default value (if not provided) is the standard mode. > > Example: > > @@ -15,4 +19,5 @@ pcf8523: rtc@68 { > compatible = "nxp,pcf8523"; > reg = <0x68>; > quartz-load-femtofarads = <7000>; > + pm-enable-dsm; > }; > diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml > index ee237b2..a0048f4 100644 > --- a/Documentation/devicetree/bindings/rtc/rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml > @@ -47,4 +47,11 @@ properties: > description: > Enables wake up of host system on alarm. > > + pm-enable-dsm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Enables the battery switch-over function in direct switching > + mode. Should be set in systems where VDD is higher than VBAT > + at all times. I'm all for common properties, but is this common across vendors? > + > ... > -- > 1.8.3.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: miguelborgesdefreitas@gmail.com Cc: a.zummo@towertech.it, baruch@tkos.co.il, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over Date: Thu, 23 Jul 2020 11:49:05 -0600 [thread overview] Message-ID: <20200723174905.GA596242@bogus> (raw) In-Reply-To: <20200720112401.4620-2-miguelborgesdefreitas@gmail.com> On Mon, Jul 20, 2020 at 12:23:59PM +0100, miguelborgesdefreitas@gmail.com wrote: > From: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com> > > This adds direct-switching mode as a configurable DT flag for > RTC modules supporting it (e.g. nxp pcf8523). > DSM switches the power source to the battery supply whenever the > VDD drops below VBAT. The option is recommended for hw designs > where VDD is always expected to be higher than VBAT. > > Signed-off-by: Miguel Borges de Freitas <miguelborgesdefreitas@gmail.com> > --- > Changes in v2: > - Added extended commit message for git history > - Separate dt bindings documentation into a single patch > > Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt | 7 ++++++- > Documentation/devicetree/bindings/rtc/rtc.yaml | 7 +++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > index 0b1080c..f715a8f 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt > @@ -4,10 +4,14 @@ Required properties: > - compatible: Should contain "nxp,pcf8523". > - reg: I2C address for chip. > > -Optional property: > +Optional properties: > - quartz-load-femtofarads: The capacitive load of the quartz(x-tal), > expressed in femto Farad (fF). Valid values are 7000 and 12500. > Default value (if no value is specified) is 12500fF. > +- pm-enable-dsm: battery switch-over function is enabled in direct > + switching mode. The power failure condition happens when VDD < VBAT, > + without requiring VDD to drop below Vth(sw)bat. > + Default value (if not provided) is the standard mode. > > Example: > > @@ -15,4 +19,5 @@ pcf8523: rtc@68 { > compatible = "nxp,pcf8523"; > reg = <0x68>; > quartz-load-femtofarads = <7000>; > + pm-enable-dsm; > }; > diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml > index ee237b2..a0048f4 100644 > --- a/Documentation/devicetree/bindings/rtc/rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml > @@ -47,4 +47,11 @@ properties: > description: > Enables wake up of host system on alarm. > > + pm-enable-dsm: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Enables the battery switch-over function in direct switching > + mode. Should be set in systems where VDD is higher than VBAT > + at all times. I'm all for common properties, but is this common across vendors? > + > ... > -- > 1.8.3.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 17:49 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-19 14:50 [PATCH 0/2] rtc: pcf8523: Make DSM for battery switch-over configurable from DT and enable it for the cubox-i miguelborgesdefreitas 2020-07-19 14:50 ` miguelborgesdefreitas 2020-07-19 14:50 ` [PATCH 1/2] rtc: pcf8523: Make DSM for battery switch-over configurable from DT miguelborgesdefreitas 2020-07-19 14:50 ` miguelborgesdefreitas 2020-07-19 14:50 ` [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC miguelborgesdefreitas 2020-07-19 14:50 ` miguelborgesdefreitas 2020-07-19 15:00 ` Baruch Siach 2020-07-19 15:00 ` Baruch Siach 2020-07-20 11:23 ` [PATCH v2 0/3] rtc: pcf8523: imx6qdl-cubox-i: Make DSM for battery switch-over configurable from DT and enable it for the cubox-i miguelborgesdefreitas 2020-07-20 11:23 ` miguelborgesdefreitas 2020-07-20 11:23 ` [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over miguelborgesdefreitas 2020-07-20 11:23 ` miguelborgesdefreitas 2020-07-23 17:49 ` Rob Herring [this message] 2020-07-23 17:49 ` Rob Herring 2020-07-23 19:57 ` Alexandre Belloni 2020-07-23 19:57 ` Alexandre Belloni 2020-07-23 20:41 ` Miguel Borges de Freitas 2020-07-23 20:41 ` Miguel Borges de Freitas 2020-07-27 9:19 ` Jon Nettleton 2020-07-27 9:19 ` Jon Nettleton 2020-07-27 9:45 ` Russell King - ARM Linux admin 2020-07-27 9:45 ` Russell King - ARM Linux admin 2020-07-27 13:33 ` Jon Nettleton 2020-07-27 13:33 ` Jon Nettleton 2020-07-27 14:17 ` Russell King - ARM Linux admin 2020-07-27 14:17 ` Russell King - ARM Linux admin 2020-07-27 14:52 ` Jon Nettleton 2020-07-27 14:52 ` Jon Nettleton 2020-07-27 14:49 ` Alexandre Belloni 2020-07-27 14:49 ` Alexandre Belloni 2020-07-27 15:24 ` Russell King - ARM Linux admin 2020-07-27 15:24 ` Russell King - ARM Linux admin 2020-07-27 15:41 ` Alexandre Belloni 2020-07-27 15:41 ` Alexandre Belloni 2020-07-27 15:43 ` Russell King - ARM Linux admin 2020-07-27 15:43 ` Russell King - ARM Linux admin 2020-07-27 15:55 ` Jon Nettleton 2020-07-27 15:55 ` Jon Nettleton 2020-07-27 16:16 ` Alexandre Belloni 2020-07-27 16:16 ` Alexandre Belloni 2020-07-27 17:04 ` Jon Nettleton 2020-07-27 17:04 ` Jon Nettleton 2020-07-27 17:30 ` Russell King - ARM Linux admin 2020-07-27 17:30 ` Russell King - ARM Linux admin 2020-07-27 21:13 ` Miguel Borges de Freitas 2020-07-27 21:13 ` Miguel Borges de Freitas 2020-08-25 20:08 ` Alexandre Belloni 2020-08-25 20:08 ` Alexandre Belloni 2020-07-20 11:24 ` [PATCH v2 2/3] rtc: pcf8523: Make DSM for battery switch-over configurable from DT miguelborgesdefreitas 2020-07-20 11:24 ` miguelborgesdefreitas 2020-07-20 11:24 ` [PATCH v2 3/3] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC miguelborgesdefreitas 2020-07-20 11:24 ` miguelborgesdefreitas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200723174905.GA596242@bogus \ --to=robh@kernel.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=baruch@tkos.co.il \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=miguelborgesdefreitas@gmail.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.