All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, marvin24@gmx.de,
	p.zabel@pengutronix.de, linux-tegra@vger.kernel.org,
	ac100@lists.launchpad.net
Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary
Date: Fri, 24 Jul 2020 18:23:31 +0200	[thread overview]
Message-ID: <20200724162331.GA542507@kroah.com> (raw)
In-Reply-To: <79c59734-d4ed-7968-5c9d-17d0ffe37b73@gmail.com>

On Fri, Jul 24, 2020 at 09:21:47PM +0530, Rohit K Bharadwaj wrote:
> On 24/07/20 7:39 pm, Dan Carpenter wrote:
> > On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
> >> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> >>  	platform_set_drvdata(pdev, nvec);
> >>  	nvec->dev = dev;
> >>  
> >> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> >> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
> > 
> > Sorry, I should have looked for v3 at the start to reply to it.  This
> > line will break the driver.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Thank you for your review sir, my intention was to fix kernel coding style issues and hence had picked this one. 
> Could you please let me know whether I should undo that particular line and submit the patch again so as not to break the driver? 

Try making patches that do not break things :)

Maybe a different type of patch?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: devel@driverdev.osuosl.org, marvin24@gmx.de,
	Dan Carpenter <dan.carpenter@oracle.com>,
	p.zabel@pengutronix.de, linux-tegra@vger.kernel.org,
	ac100@lists.launchpad.net
Subject: Re: [PATCH v3] staging: nvec: change usage of slave to secondary
Date: Fri, 24 Jul 2020 18:23:31 +0200	[thread overview]
Message-ID: <20200724162331.GA542507@kroah.com> (raw)
In-Reply-To: <79c59734-d4ed-7968-5c9d-17d0ffe37b73@gmail.com>

On Fri, Jul 24, 2020 at 09:21:47PM +0530, Rohit K Bharadwaj wrote:
> On 24/07/20 7:39 pm, Dan Carpenter wrote:
> > On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
> >> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
> >>  	platform_set_drvdata(pdev, nvec);
> >>  	nvec->dev = dev;
> >>  
> >> -	if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) {
> >> +	if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) {
> > 
> > Sorry, I should have looked for v3 at the start to reply to it.  This
> > line will break the driver.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Thank you for your review sir, my intention was to fix kernel coding style issues and hence had picked this one. 
> Could you please let me know whether I should undo that particular line and submit the patch again so as not to break the driver? 

Try making patches that do not break things :)

Maybe a different type of patch?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-07-24 16:23 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 15:15 ` Rohit K Bharadwaj
     [not found] ` <20200723151511.22193-1-bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-23 17:06   ` Greg KH
2020-07-23 17:06     ` Greg KH
     [not found]     ` <20200723170618.GA2835510-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-07-24  4:55       ` Rohit Bharadwaj
2020-07-24  4:55         ` Rohit Bharadwaj
2020-07-24  4:36   ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24  4:36     ` Rohit K Bharadwaj
2020-07-24  8:14     ` Rohit Bharadwaj
2020-07-24  8:14       ` Rohit Bharadwaj
2020-07-24  8:28       ` Greg KH
2020-07-24  8:28         ` Greg KH
2020-07-24  8:35         ` Rohit Bharadwaj
2020-07-24  8:35           ` Rohit Bharadwaj
2020-07-24 16:33           ` Marc Dietrich
2020-07-24 16:33             ` Marc Dietrich
2020-07-24 16:36             ` Marc Dietrich
2020-07-24 16:36               ` Marc Dietrich
2020-07-24 16:57               ` Rohit K Bharadwaj
2020-07-24 16:57                 ` Rohit K Bharadwaj
2020-07-24 20:42                 ` Marc Dietrich
2020-07-24 20:42                   ` Marc Dietrich
2020-07-25  6:50                   ` Rohit K Bharadwaj
2020-07-25  6:50                     ` Rohit K Bharadwaj
2020-07-24 14:09     ` Dan Carpenter
2020-07-24 14:09       ` Dan Carpenter
2020-07-24 15:51       ` Rohit K Bharadwaj
2020-07-24 15:51         ` Rohit K Bharadwaj
2020-07-24 16:23         ` Greg KH [this message]
2020-07-24 16:23           ` Greg KH
2020-07-25  6:29     ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25  6:29       ` Rohit K Bharadwaj
2020-07-25 12:01       ` Michał Mirosław
2020-07-25 12:01         ` Michał Mirosław
2020-07-25 12:31         ` Rohit K Bharadwaj
2020-07-25 12:31           ` Rohit K Bharadwaj
2020-07-25 12:50           ` Michał Mirosław
2020-07-25 12:50             ` Michał Mirosław
2020-07-25 13:02             ` Rohit K Bharadwaj
2020-07-25 13:02               ` Rohit K Bharadwaj
2020-08-02  8:07             ` Marc Dietrich
2020-08-02  8:07               ` Marc Dietrich
2020-08-02  8:13       ` Marc Dietrich
2020-08-02  8:13         ` Marc Dietrich
2020-08-02  9:09         ` Rohit K Bharadwaj
2020-08-02  9:09           ` Rohit K Bharadwaj
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter
2020-07-24 14:07   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724162331.GA542507@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ac100@lists.launchpad.net \
    --cc=bharadwaj.rohit8@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marvin24@gmx.de \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.