From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: marvin24@posteo.de, gregkh@linuxfoundation.org,
p.zabel@pengutronix.de, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary
Date: Sat, 25 Jul 2020 14:01:47 +0200 [thread overview]
Message-ID: <20200725120146.GB26689@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200725062938.15388-1-bharadwaj.rohit8@gmail.com>
On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (which is deprecated) to secondary without breaking the driver
The relevant I2C and SMBus standards use master/slave terminology. Why are
you changing the names to something unfamiliar?
If the reason are the recent coding-style changes, then please note they
are about avoiding introducing *NEW* uses of the specific words and not
about blindly replacing existing occurrences.
Best Regards
Michał Mirosław
WARNING: multiple messages have this Message-ID (diff)
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
To: Rohit K Bharadwaj <bharadwaj.rohit8@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Dan Carpenter <dan.carpenter@oracle.com>,
p.zabel@pengutronix.de, linux-tegra@vger.kernel.org,
ac100@lists.launchpad.net
Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary
Date: Sat, 25 Jul 2020 14:01:47 +0200 [thread overview]
Message-ID: <20200725120146.GB26689@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200725062938.15388-1-bharadwaj.rohit8@gmail.com>
On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
> changed usage of slave (which is deprecated) to secondary without breaking the driver
The relevant I2C and SMBus standards use master/slave terminology. Why are
you changing the names to something unfamiliar?
If the reason are the recent coding-style changes, then please note they
are about avoiding introducing *NEW* uses of the specific words and not
about blindly replacing existing occurrences.
Best Regards
Michał Mirosław
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-25 12:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 15:15 [PATCH] change slave occurence to secondary everywhere Rohit K Bharadwaj
2020-07-23 15:15 ` Rohit K Bharadwaj
[not found] ` <20200723151511.22193-1-bharadwaj.rohit8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-23 17:06 ` Greg KH
2020-07-23 17:06 ` Greg KH
[not found] ` <20200723170618.GA2835510-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2020-07-24 4:55 ` Rohit Bharadwaj
2020-07-24 4:55 ` Rohit Bharadwaj
2020-07-24 4:36 ` [PATCH v3] staging: nvec: change usage of slave to secondary Rohit K Bharadwaj
2020-07-24 4:36 ` Rohit K Bharadwaj
2020-07-24 8:14 ` Rohit Bharadwaj
2020-07-24 8:14 ` Rohit Bharadwaj
2020-07-24 8:28 ` Greg KH
2020-07-24 8:28 ` Greg KH
2020-07-24 8:35 ` Rohit Bharadwaj
2020-07-24 8:35 ` Rohit Bharadwaj
2020-07-24 16:33 ` Marc Dietrich
2020-07-24 16:33 ` Marc Dietrich
2020-07-24 16:36 ` Marc Dietrich
2020-07-24 16:36 ` Marc Dietrich
2020-07-24 16:57 ` Rohit K Bharadwaj
2020-07-24 16:57 ` Rohit K Bharadwaj
2020-07-24 20:42 ` Marc Dietrich
2020-07-24 20:42 ` Marc Dietrich
2020-07-25 6:50 ` Rohit K Bharadwaj
2020-07-25 6:50 ` Rohit K Bharadwaj
2020-07-24 14:09 ` Dan Carpenter
2020-07-24 14:09 ` Dan Carpenter
2020-07-24 15:51 ` Rohit K Bharadwaj
2020-07-24 15:51 ` Rohit K Bharadwaj
2020-07-24 16:23 ` Greg KH
2020-07-24 16:23 ` Greg KH
2020-07-25 6:29 ` [PATCH v4] " Rohit K Bharadwaj
2020-07-25 6:29 ` Rohit K Bharadwaj
2020-07-25 12:01 ` Michał Mirosław [this message]
2020-07-25 12:01 ` Michał Mirosław
2020-07-25 12:31 ` Rohit K Bharadwaj
2020-07-25 12:31 ` Rohit K Bharadwaj
2020-07-25 12:50 ` Michał Mirosław
2020-07-25 12:50 ` Michał Mirosław
2020-07-25 13:02 ` Rohit K Bharadwaj
2020-07-25 13:02 ` Rohit K Bharadwaj
2020-08-02 8:07 ` Marc Dietrich
2020-08-02 8:07 ` Marc Dietrich
2020-08-02 8:13 ` Marc Dietrich
2020-08-02 8:13 ` Marc Dietrich
2020-08-02 9:09 ` Rohit K Bharadwaj
2020-08-02 9:09 ` Rohit K Bharadwaj
2020-07-24 14:07 ` [PATCH] change slave occurence to secondary everywhere Dan Carpenter
2020-07-24 14:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725120146.GB26689@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=ac100@lists.launchpad.net \
--cc=bharadwaj.rohit8@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@posteo.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.