* [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
@ 2020-07-24 21:42 ` Grygorii Strashko
0 siblings, 0 replies; 8+ messages in thread
From: Grygorii Strashko @ 2020-07-24 21:42 UTC (permalink / raw)
To: Murali Karicheri, Santosh Shilimkar, santosh.shilimkar
Cc: Sekhar Nori, linux-arm-kernel, David S . Miller, linux-kernel,
netdev, devicetree, Grygorii Strashko, Oleksij Rempel,
Andrew Lunn, Philippe Schenker
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
The above board have phy-mode = "rgmii-id" and it is worked before because
KSZ9031 PHY started with default RGMII internal delays configuration (TX
off, RX on 1.2 ns) and MAC provided TX delay by default.
After above commit, the KSZ9031 PHY starts handling phy mode properly and
enables both RX and TX delays, as result networking is become broken.
Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
behavior.
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Philippe Schenker <philippe.schenker@toradex.com>
Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Fix for one more broken TI board with KSZ9031 PHY.
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
index db640bab8c1d..8b3d64c913d8 100644
--- a/arch/arm/boot/dts/keystone-k2g-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
@@ -402,7 +402,7 @@
&gbe0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii-id";
+ phy-mode = "rgmii-rxid";
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
@ 2020-07-24 21:42 ` Grygorii Strashko
0 siblings, 0 replies; 8+ messages in thread
From: Grygorii Strashko @ 2020-07-24 21:42 UTC (permalink / raw)
To: Murali Karicheri, Santosh Shilimkar, santosh.shilimkar
Cc: devicetree, Philippe Schenker, Grygorii Strashko, Andrew Lunn,
netdev, Sekhar Nori, linux-kernel, Oleksij Rempel,
David S . Miller, linux-arm-kernel
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
The above board have phy-mode = "rgmii-id" and it is worked before because
KSZ9031 PHY started with default RGMII internal delays configuration (TX
off, RX on 1.2 ns) and MAC provided TX delay by default.
After above commit, the KSZ9031 PHY starts handling phy mode properly and
enables both RX and TX delays, as result networking is become broken.
Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
behavior.
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Philippe Schenker <philippe.schenker@toradex.com>
Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Fix for one more broken TI board with KSZ9031 PHY.
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
index db640bab8c1d..8b3d64c913d8 100644
--- a/arch/arm/boot/dts/keystone-k2g-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
@@ -402,7 +402,7 @@
&gbe0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii-id";
+ phy-mode = "rgmii-rxid";
status = "okay";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
2020-07-24 21:42 ` Grygorii Strashko
@ 2020-07-24 21:55 ` santosh.shilimkar
-1 siblings, 0 replies; 8+ messages in thread
From: santosh.shilimkar @ 2020-07-24 21:55 UTC (permalink / raw)
To: arm, Arnd Bergmann, Olof Johansson
Cc: Grygorii Strashko, Murali Karicheri, Santosh Shilimkar,
Sekhar Nori, linux-arm-kernel, David S . Miller, linux-kernel,
netdev, devicetree, Oleksij Rempel, Andrew Lunn,
Philippe Schenker
Hi Arnd, Olof,
On 7/24/20 2:42 PM, Grygorii Strashko wrote:
> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
>
> The above board have phy-mode = "rgmii-id" and it is worked before because
> KSZ9031 PHY started with default RGMII internal delays configuration (TX
> off, RX on 1.2 ns) and MAC provided TX delay by default.
> After above commit, the KSZ9031 PHY starts handling phy mode properly and
> enables both RX and TX delays, as result networking is become broken.
>
> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> behavior.
>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Philippe Schenker <philippe.schenker@toradex.com>
> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Fix for one more broken TI board with KSZ9031 PHY.
Can you please apply this patch to your v5.8 fixes branch and send it
upstream ? Without the fix K2G EVM board is broken with v5.8.
Am hoping you can pick this up with pull request since it just one
patch.
Regards,
Santosh
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
@ 2020-07-24 21:55 ` santosh.shilimkar
0 siblings, 0 replies; 8+ messages in thread
From: santosh.shilimkar @ 2020-07-24 21:55 UTC (permalink / raw)
To: arm, Arnd Bergmann, Olof Johansson
Cc: devicetree, Philippe Schenker, Grygorii Strashko, Andrew Lunn,
netdev, Sekhar Nori, linux-kernel, Oleksij Rempel,
Murali Karicheri, Santosh Shilimkar, David S . Miller,
linux-arm-kernel
Hi Arnd, Olof,
On 7/24/20 2:42 PM, Grygorii Strashko wrote:
> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
>
> The above board have phy-mode = "rgmii-id" and it is worked before because
> KSZ9031 PHY started with default RGMII internal delays configuration (TX
> off, RX on 1.2 ns) and MAC provided TX delay by default.
> After above commit, the KSZ9031 PHY starts handling phy mode properly and
> enables both RX and TX delays, as result networking is become broken.
>
> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> behavior.
>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Philippe Schenker <philippe.schenker@toradex.com>
> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Fix for one more broken TI board with KSZ9031 PHY.
Can you please apply this patch to your v5.8 fixes branch and send it
upstream ? Without the fix K2G EVM board is broken with v5.8.
Am hoping you can pick this up with pull request since it just one
patch.
Regards,
Santosh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
2020-07-24 21:55 ` santosh.shilimkar
@ 2020-07-25 7:57 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2020-07-25 7:57 UTC (permalink / raw)
To: santosh.shilimkar
Cc: arm, Olof Johansson, Grygorii Strashko, Murali Karicheri,
Santosh Shilimkar, Sekhar Nori, Linux ARM, David S . Miller,
linux-kernel, Networking, DTML, Oleksij Rempel, Andrew Lunn,
Philippe Schenker
On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com
<santosh.shilimkar@oracle.com> wrote:
> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
> >
> > The above board have phy-mode = "rgmii-id" and it is worked before because
> > KSZ9031 PHY started with default RGMII internal delays configuration (TX
> > off, RX on 1.2 ns) and MAC provided TX delay by default.
> > After above commit, the KSZ9031 PHY starts handling phy mode properly and
> > enables both RX and TX delays, as result networking is become broken.
> >
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> >
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Philippe Schenker <philippe.schenker@toradex.com>
> > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > Fix for one more broken TI board with KSZ9031 PHY.
> Can you please apply this patch to your v5.8 fixes branch and send it
> upstream ? Without the fix K2G EVM board is broken with v5.8.
>
> Am hoping you can pick this up with pull request since it just one
> patch.
I've applied it now, but would point out that it's generally better if you could
forward the patch to soc@kernel.org with your Signed-off-by if you come
across a similar patch again. That way it ends up in patchwork, and we
are more likely to pick it up quickly.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
@ 2020-07-25 7:57 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2020-07-25 7:57 UTC (permalink / raw)
To: santosh.shilimkar
Cc: DTML, Philippe Schenker, Grygorii Strashko, Andrew Lunn,
Networking, Sekhar Nori, linux-kernel, Oleksij Rempel, arm,
Murali Karicheri, Santosh Shilimkar, Olof Johansson,
David S . Miller, Linux ARM
On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com
<santosh.shilimkar@oracle.com> wrote:
> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
> >
> > The above board have phy-mode = "rgmii-id" and it is worked before because
> > KSZ9031 PHY started with default RGMII internal delays configuration (TX
> > off, RX on 1.2 ns) and MAC provided TX delay by default.
> > After above commit, the KSZ9031 PHY starts handling phy mode properly and
> > enables both RX and TX delays, as result networking is become broken.
> >
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> >
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Philippe Schenker <philippe.schenker@toradex.com>
> > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > Fix for one more broken TI board with KSZ9031 PHY.
> Can you please apply this patch to your v5.8 fixes branch and send it
> upstream ? Without the fix K2G EVM board is broken with v5.8.
>
> Am hoping you can pick this up with pull request since it just one
> patch.
I've applied it now, but would point out that it's generally better if you could
forward the patch to soc@kernel.org with your Signed-off-by if you come
across a similar patch again. That way it ends up in patchwork, and we
are more likely to pick it up quickly.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
2020-07-25 7:57 ` Arnd Bergmann
@ 2020-07-25 20:56 ` santosh.shilimkar
-1 siblings, 0 replies; 8+ messages in thread
From: santosh.shilimkar @ 2020-07-25 20:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: arm, Olof Johansson, Grygorii Strashko, Murali Karicheri,
Santosh Shilimkar, Sekhar Nori, Linux ARM, David S . Miller,
linux-kernel, Networking, DTML, Oleksij Rempel, Andrew Lunn,
Philippe Schenker
On 7/25/20 12:57 AM, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com
> <santosh.shilimkar@oracle.com> wrote:
>> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
>>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>>> KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
>>>
>>> The above board have phy-mode = "rgmii-id" and it is worked before because
>>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>>> off, RX on 1.2 ns) and MAC provided TX delay by default.
>>> After above commit, the KSZ9031 PHY starts handling phy mode properly and
>>> enables both RX and TX delays, as result networking is become broken.
>>>
>>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>>> behavior.
>>>
>>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>> Cc: Philippe Schenker <philippe.schenker@toradex.com>
>>> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>> ---
>>> Fix for one more broken TI board with KSZ9031 PHY.
>> Can you please apply this patch to your v5.8 fixes branch and send it
>> upstream ? Without the fix K2G EVM board is broken with v5.8.
>>
>> Am hoping you can pick this up with pull request since it just one
>> patch.
>
> I've applied it now, but would point out that it's generally better if you could
> forward the patch to soc@kernel.org with your Signed-off-by if you come
> across a similar patch again. That way it ends up in patchwork, and we
> are more likely to pick it up quickly.
>
Will do next time. Thanks for picking it up.
Regards,
Santosh
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy
@ 2020-07-25 20:56 ` santosh.shilimkar
0 siblings, 0 replies; 8+ messages in thread
From: santosh.shilimkar @ 2020-07-25 20:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: DTML, Philippe Schenker, Grygorii Strashko, Andrew Lunn,
Networking, Sekhar Nori, linux-kernel, Oleksij Rempel, arm,
Murali Karicheri, Santosh Shilimkar, Olof Johansson,
David S . Miller, Linux ARM
On 7/25/20 12:57 AM, Arnd Bergmann wrote:
> On Fri, Jul 24, 2020 at 11:57 PM santosh.shilimkar@oracle.com
> <santosh.shilimkar@oracle.com> wrote:
>> On 7/24/20 2:42 PM, Grygorii Strashko wrote:
>>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>>> KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
>>>
>>> The above board have phy-mode = "rgmii-id" and it is worked before because
>>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>>> off, RX on 1.2 ns) and MAC provided TX delay by default.
>>> After above commit, the KSZ9031 PHY starts handling phy mode properly and
>>> enables both RX and TX delays, as result networking is become broken.
>>>
>>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>>> behavior.
>>>
>>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>>> Cc: Andrew Lunn <andrew@lunn.ch>
>>> Cc: Philippe Schenker <philippe.schenker@toradex.com>
>>> Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>> ---
>>> Fix for one more broken TI board with KSZ9031 PHY.
>> Can you please apply this patch to your v5.8 fixes branch and send it
>> upstream ? Without the fix K2G EVM board is broken with v5.8.
>>
>> Am hoping you can pick this up with pull request since it just one
>> patch.
>
> I've applied it now, but would point out that it's generally better if you could
> forward the patch to soc@kernel.org with your Signed-off-by if you come
> across a similar patch again. That way it ends up in patchwork, and we
> are more likely to pick it up quickly.
>
Will do next time. Thanks for picking it up.
Regards,
Santosh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-25 20:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 21:42 [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy Grygorii Strashko
2020-07-24 21:42 ` Grygorii Strashko
2020-07-24 21:55 ` santosh.shilimkar
2020-07-24 21:55 ` santosh.shilimkar
2020-07-25 7:57 ` Arnd Bergmann
2020-07-25 7:57 ` Arnd Bergmann
2020-07-25 20:56 ` santosh.shilimkar
2020-07-25 20:56 ` santosh.shilimkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.