[PATCH] udf: use common error code for unclean filesystem

[PATCH] udf: use common error code for unclean filesystem

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]


Use common error code for unclean filesystem, and warn when
incosistency is detected.

Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index adaba8e8b326..8e74c7b5b8d0 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)
 	if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT &&
 	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG &&
 	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) {
-		ret = -EIO;
+		ret = -EUCLEAN;
+		udf_err(inode->i_sb, "invalid allocation type: %u\n",
+			iinfo->i_alloc_type);
+
 		goto out;
 	}
 	iinfo->i_unique = 0;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] udf: use common error code for unclean filesystem

[Jan Kara]

On Sun 26-07-20 09:58:28, Pavel Machek wrote:
> 
> Use common error code for unclean filesystem, and warn when
> incosistency is detected.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>

So this is going in the right direction but there are *much* more places
that would need a similar treatment (furthermore I'd prefer to use the
EFSCORRUPTED redefine of EUCLEAN as other filesystems do). Any reason why
you converted this particular place?

								Honza

> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index adaba8e8b326..8e74c7b5b8d0 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)
>  	if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) {
> -		ret = -EIO;
> +		ret = -EUCLEAN;
> +		udf_err(inode->i_sb, "invalid allocation type: %u\n",
> +			iinfo->i_alloc_type);
> +
>  		goto out;
>  	}
>  	iinfo->i_unique = 0;
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR