From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Bjorn Helgaas <bjorn@helgaas.com>, Vaibhav Gupta <vaibhav.varodek@gmail.com>, Mark Brown <broonie@kernel.org>, linux-spi <linux-spi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan <skhan@linuxfoundation.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net> Subject: Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management Date: Mon, 27 Jul 2020 18:38:58 +0530 [thread overview] Message-ID: <20200727130858.GB82098@gmail.com> (raw) In-Reply-To: <CAHp75VdzAk6U_mKn32+dmw1aNyREtaXMB6sHubE8G9imtv5=3g@mail.gmail.com> On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > <andy.shevchenko@gmail.com> wrote: > > ... > > > > The only problem here, is that the 2nd is already in the Mark's tree > > > and he doesn't do rebases. > > > So, it will be the other way around. > > > > > Concluding from yours and Bjorn's suggestion, I will drop the > > device_wakeup_disable() call form .resume() and send the fix. I will also track > > the drivers who got similar upgrades and went un-noticed. > > Thanks for doing this! > > > As Bjorn mentioned, the problem is that I don't have hardware to test, so I just > > replicated the legacy behaviour in generic by replacing > > pci_enable_wake(....,false) with device_wakeup_disable(). > > > > So, from now, while upgrading drivers with generic PM, should I completely drop > > the pci_enable_wake(....,false) calls if both .suspend() and .resume() try to > > wakeup-disable the device? > > I guess the best approach is to rely on the PCI core to do the right thing. > But mention this change in the commit message that we will have a > track of the changes properly. > Okay. Thanks ! Vaibhav Gupta > -- > With Best Regards, > Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>, Mark Brown <broonie@kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v1] spi: spi-topcliff-pch: use generic power management Date: Mon, 27 Jul 2020 18:38:58 +0530 [thread overview] Message-ID: <20200727130858.GB82098@gmail.com> (raw) In-Reply-To: <CAHp75VdzAk6U_mKn32+dmw1aNyREtaXMB6sHubE8G9imtv5=3g@mail.gmail.com> On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta <vaibhavgupta40@gmail.com> wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > <andy.shevchenko@gmail.com> wrote: > > ... > > > > The only problem here, is that the 2nd is already in the Mark's tree > > > and he doesn't do rebases. > > > So, it will be the other way around. > > > > > Concluding from yours and Bjorn's suggestion, I will drop the > > device_wakeup_disable() call form .resume() and send the fix. I will also track > > the drivers who got similar upgrades and went un-noticed. > > Thanks for doing this! > > > As Bjorn mentioned, the problem is that I don't have hardware to test, so I just > > replicated the legacy behaviour in generic by replacing > > pci_enable_wake(....,false) with device_wakeup_disable(). > > > > So, from now, while upgrading drivers with generic PM, should I completely drop > > the pci_enable_wake(....,false) calls if both .suspend() and .resume() try to > > wakeup-disable the device? > > I guess the best approach is to rely on the PCI core to do the right thing. > But mention this change in the commit message that we will have a > track of the changes properly. > Okay. Thanks ! Vaibhav Gupta > -- > With Best Regards, > Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-27 13:10 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-20 15:57 [PATCH v1] spi: spi-topcliff-pch: use generic power management Vaibhav Gupta 2020-07-20 15:57 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 13:45 ` Mark Brown 2020-07-22 13:45 ` [Linux-kernel-mentees] " Mark Brown 2020-07-22 20:01 ` Vaibhav Gupta 2020-07-22 20:01 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-24 10:51 ` Andy Shevchenko 2020-07-24 10:51 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-24 15:16 ` Vaibhav Gupta 2020-07-24 15:16 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-24 20:16 ` Andy Shevchenko 2020-07-24 20:16 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-24 22:37 ` Bjorn Helgaas 2020-07-24 22:37 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-25 10:42 ` Andy Shevchenko 2020-07-25 10:42 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-25 10:44 ` Andy Shevchenko 2020-07-25 10:44 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-27 7:06 ` Vaibhav Gupta 2020-07-27 7:06 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 11:12 ` Andy Shevchenko 2020-07-27 11:12 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-27 13:08 ` Vaibhav Gupta [this message] 2020-07-27 13:08 ` Vaibhav Gupta 2020-07-27 13:17 ` [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable Vaibhav Gupta 2020-07-27 13:17 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 13:38 ` Andy Shevchenko 2020-07-27 13:38 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-27 13:46 ` Vaibhav Gupta 2020-07-27 13:46 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 14:08 ` Andy Shevchenko 2020-07-27 14:08 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-27 14:17 ` Joe Perches 2020-07-27 14:17 ` [Linux-kernel-mentees] " Joe Perches 2020-07-27 17:29 ` [PATCH v3] " Vaibhav Gupta 2020-07-27 17:29 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 19:21 ` Andy Shevchenko 2020-07-27 19:21 ` [Linux-kernel-mentees] " Andy Shevchenko 2020-07-28 16:31 ` Mark Brown 2020-07-28 16:31 ` [Linux-kernel-mentees] " Mark Brown 2020-07-28 16:31 ` [PATCH v2] " Mark Brown 2020-07-28 16:31 ` [Linux-kernel-mentees] " Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200727130858.GB82098@gmail.com \ --to=vaibhavgupta40@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=bhelgaas@google.com \ --cc=bjorn@helgaas.com \ --cc=broonie@kernel.org \ --cc=helgaas@kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=skhan@linuxfoundation.org \ --cc=vaibhav.varodek@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.