* [cip-dev] [PATCH 4.4.y-cip 1/9] drm: Add an encoder and connector type enum for DPI.
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 2/9] of: add node name compare helper functions Biju Das
` (8 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 2685 bytes --]
From: Eric Anholt <eric@anholt.net>
commit 0b27c02a7f1c697694f2ad6d6517e7dbf9ecfa39 upstream.
Right now exynos is exposing DPI as a TMDS encoder and VGA connector,
which seems rather misleading. This isn't just an internal detail,
since xrandr actually exposes "VGA" as the output name. Define some
new enums so that vc4's DPI can have a more informative name.
I considered other names for the connector as well. For VC4, the
Adafruit DPI kippah takes the 28 GPIO pins and routes them to a
standard-ish 40-pin FPC connector, but "40-pin FPC" doesn't uniquely
identify an ordering of pins (apparently some other orderings exist),
doesn't explain things as well for the user (who, if anything, knows
their product is a DPI kippah/panel combo), and actually doesn't have
to exist (one could connect the 28 GPIOs directly to something else).
Simply "DPI" seems like a good compromise name to distinguish from the
HDMI, DSI, and TV connectors .
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/gpu/drm/drm_crtc.c | 2 ++
include/uapi/drm/drm_mode.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 5e4bb4837bae..34538444fd19 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -168,6 +168,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = {
{ DRM_MODE_CONNECTOR_eDP, "eDP" },
{ DRM_MODE_CONNECTOR_VIRTUAL, "Virtual" },
{ DRM_MODE_CONNECTOR_DSI, "DSI" },
+ { DRM_MODE_CONNECTOR_DPI, "DPI" },
};
static const struct drm_prop_enum_list drm_encoder_enum_list[] = {
@@ -179,6 +180,7 @@ static const struct drm_prop_enum_list drm_encoder_enum_list[] = {
{ DRM_MODE_ENCODER_VIRTUAL, "Virtual" },
{ DRM_MODE_ENCODER_DSI, "DSI" },
{ DRM_MODE_ENCODER_DPMST, "DP MST" },
+ { DRM_MODE_ENCODER_DPI, "DPI" },
};
static const struct drm_prop_enum_list drm_subpixel_enum_list[] = {
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 6c11ca401de8..325e9eb3d812 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -202,6 +202,7 @@ struct drm_mode_get_plane_res {
#define DRM_MODE_ENCODER_VIRTUAL 5
#define DRM_MODE_ENCODER_DSI 6
#define DRM_MODE_ENCODER_DPMST 7
+#define DRM_MODE_ENCODER_DPI 8
struct drm_mode_get_encoder {
__u32 encoder_id;
@@ -241,6 +242,7 @@ struct drm_mode_get_encoder {
#define DRM_MODE_CONNECTOR_eDP 14
#define DRM_MODE_CONNECTOR_VIRTUAL 15
#define DRM_MODE_CONNECTOR_DSI 16
+#define DRM_MODE_CONNECTOR_DPI 17
struct drm_mode_get_connector {
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5033): https://lists.cip-project.org/g/cip-dev/message/5033
Mute This Topic: https://lists.cip-project.org/mt/75842038/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 2/9] of: add node name compare helper functions
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 1/9] drm: Add an encoder and connector type enum for DPI Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 3/9] dt-bindings: display: Add bindings for EDT panel Biju Das
` (7 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 2393 bytes --]
From: Rob Herring <robh@kernel.org>
commit f42b0e18f2e5cf34f73ef1b6327b49040b307a33 upstream.
In preparation to remove device_node.name pointer, add helper functions
for node name comparisons which are a common pattern throughout the kernel.
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/of/base.c | 22 ++++++++++++++++++++++
include/linux/of.h | 13 +++++++++++++
2 files changed, 35 insertions(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 164eb1306661..b02f4b272e5b 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -54,6 +54,28 @@ DEFINE_MUTEX(of_mutex);
*/
DEFINE_RAW_SPINLOCK(devtree_lock);
+bool of_node_name_eq(const struct device_node *np, const char *name)
+{
+ const char *node_name;
+ size_t len;
+
+ if (!np)
+ return false;
+
+ node_name = kbasename(np->full_name);
+ len = strchrnul(node_name, '@') - node_name;
+
+ return (strlen(name) == len) && (strncmp(node_name, name, len) == 0);
+}
+
+bool of_node_name_prefix(const struct device_node *np, const char *prefix)
+{
+ if (!np)
+ return false;
+
+ return strncmp(kbasename(np->full_name), prefix, strlen(prefix)) == 0;
+}
+
int of_n_addr_cells(struct device_node *np)
{
const __be32 *ip;
diff --git a/include/linux/of.h b/include/linux/of.h
index a09b9fb8e67d..1bef273a1909 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -231,6 +231,9 @@ static inline unsigned long of_read_ulong(const __be32 *cell, int size)
#define OF_IS_DYNAMIC(x) test_bit(OF_DYNAMIC, &x->_flags)
#define OF_MARK_DYNAMIC(x) set_bit(OF_DYNAMIC, &x->_flags)
+extern bool of_node_name_eq(const struct device_node *np, const char *name);
+extern bool of_node_name_prefix(const struct device_node *np, const char *prefix);
+
static inline const char *of_node_full_name(const struct device_node *np)
{
return np ? np->full_name : "<no-node>";
@@ -397,6 +400,16 @@ static inline struct device_node *to_of_node(struct fwnode_handle *fwnode)
return NULL;
}
+static inline bool of_node_name_eq(const struct device_node *np, const char *name)
+{
+ return false;
+}
+
+static inline bool of_node_name_prefix(const struct device_node *np, const char *prefix)
+{
+ return false;
+}
+
static inline const char* of_node_full_name(const struct device_node *np)
{
return "<no-node>";
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5037): https://lists.cip-project.org/g/cip-dev/message/5037
Mute This Topic: https://lists.cip-project.org/mt/75842042/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 3/9] dt-bindings: display: Add bindings for EDT panel
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 1/9] drm: Add an encoder and connector type enum for DPI Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 2/9] of: add node name compare helper functions Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 4/9] drm/panel: simple: Add EDT panel support Biju Das
` (6 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP
display, which is a 480x272 4.3" TFT display with capacitive touchscreen.
This patch is based on the upstream commit c752affbadb05b619
("dt-bindings: display: Add bindings for EDT panel").
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
.../bindings/display/panel/edt,etm043080dh6gp.txt | 9 +++++++++
1 file changed, 9 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/edt,etm043080dh6gp.txt
diff --git a/Documentation/devicetree/bindings/display/panel/edt,etm043080dh6gp.txt b/Documentation/devicetree/bindings/display/panel/edt,etm043080dh6gp.txt
new file mode 100644
index 000000000000..c837e0bfb1a9
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/edt,etm043080dh6gp.txt
@@ -0,0 +1,9 @@
+Emerging Display Technology Corp. ETM043080DH6-GP 4.3" WQVGA TFT LCD panel
+
+Required properties:
+- compatible: should be "edt,etm043080dh6gp"
+
+ETM043080DH6-GP is 480x272 TFT Display with capacitive touchscreen.
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5034): https://lists.cip-project.org/g/cip-dev/message/5034
Mute This Topic: https://lists.cip-project.org/mt/75842039/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 4/9] drm/panel: simple: Add EDT panel support
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (2 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 3/9] dt-bindings: display: Add bindings for EDT panel Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 5/9] drm: rcar-du: Support panels connected directly to the DPAD outputs Biju Das
` (5 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]
From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
commit 82d57a590f51eb86e1ad0f24db257739ce0bfd74 upstream.
EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave
Generic SODIMM Development Platform.
Changes in v2:
-added mandatory .connector_type field
-changed the .bus_format MEDIA_BUS_FMT_RGB666_1X18
Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1580386118-22895-3-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
[Removed connector type. Supporting the same requires framework changes]
---
drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ecad4d7c6cd1..2b2a2f3da9a4 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -614,6 +614,36 @@ static const struct panel_desc chunghwa_claa101wb01 = {
},
};
+static const struct drm_display_mode edt_etm043080dh6gp_mode = {
+ .clock = 10870,
+ .hdisplay = 480,
+ .hsync_start = 480 + 8,
+ .hsync_end = 480 + 8 + 4,
+ .htotal = 480 + 8 + 4 + 41,
+
+ /*
+ * IWG22M: Y resolution changed for "dc_linuxfb" module crashing while
+ * fb_align
+ */
+
+ .vdisplay = 288,
+ .vsync_start = 288 + 2,
+ .vsync_end = 288 + 2 + 4,
+ .vtotal = 288 + 2 + 4 + 10,
+ .vrefresh = 60,
+};
+
+static const struct panel_desc edt_etm043080dh6gp = {
+ .modes = &edt_etm043080dh6gp_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 100,
+ .height = 65,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+};
+
static const struct drm_display_mode edt_et057090dhu_mode = {
.clock = 25175,
.hdisplay = 640,
@@ -1129,6 +1159,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "chunghwa,claa101wb01",
.data = &chunghwa_claa101wb01
+ }, {
+ .compatible = "edt,etm043080dh6gp",
+ .data = &edt_etm043080dh6gp,
}, {
.compatible = "edt,et057090dhu",
.data = &edt_et057090dhu,
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5038): https://lists.cip-project.org/g/cip-dev/message/5038
Mute This Topic: https://lists.cip-project.org/mt/75842043/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 5/9] drm: rcar-du: Support panels connected directly to the DPAD outputs
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (3 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 4/9] drm/panel: simple: Add EDT panel support Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 6/9] drm: rcar-du: Use the DRM panel API Biju Das
` (4 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 7622 bytes --]
The DPAD outputs can be connected directly to a panel. To support this
use case, detect whether the entities connected to the DU DPAD outputs
are panels based on the number of ports of their DT node, and retrieve
the corresponding type of DRM objects.
This patch is based on the commit 73eb5476df72
("Support panels connected directly to the DPAD outputs") and
commit 56c5dd00f8db ("drm/rcar-du: Split LVDS encoder and connector")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/Makefile | 1 +
drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 36 ++++++++
drivers/gpu/drm/rcar-du/rcar_du_rgbcon.c | 105 ++++++++++++++++++++++
drivers/gpu/drm/rcar-du/rcar_du_rgbcon.h | 22 +++++
4 files changed, 164 insertions(+)
create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_rgbcon.c
create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_rgbcon.h
diff --git a/drivers/gpu/drm/rcar-du/Makefile b/drivers/gpu/drm/rcar-du/Makefile
index 05de1c4097af..51b7ccc66cb7 100644
--- a/drivers/gpu/drm/rcar-du/Makefile
+++ b/drivers/gpu/drm/rcar-du/Makefile
@@ -4,6 +4,7 @@ rcar-du-drm-y := rcar_du_crtc.o \
rcar_du_group.o \
rcar_du_kms.o \
rcar_du_lvdscon.o \
+ rcar_du_rgbcon.o \
rcar_du_plane.o \
rcar_du_vgacon.o
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
index d0ae1e8009c6..c407fd4c98ce 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
@@ -16,6 +16,7 @@
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_panel.h>
#include "rcar_du_drv.h"
#include "rcar_du_encoder.h"
@@ -23,6 +24,7 @@
#include "rcar_du_hdmienc.h"
#include "rcar_du_kms.h"
#include "rcar_du_lvdscon.h"
+#include "rcar_du_rgbcon.h"
#include "rcar_du_lvdsenc.h"
#include "rcar_du_vgacon.h"
@@ -42,6 +44,26 @@ rcar_du_connector_best_encoder(struct drm_connector *connector)
* Encoder
*/
+static unsigned int rcar_du_encoder_count_ports(struct device_node *node)
+{
+ struct device_node *ports;
+ struct device_node *port;
+ unsigned int num_ports = 0;
+
+ ports = of_get_child_by_name(node, "ports");
+ if (!ports)
+ ports = of_node_get(node);
+
+ for_each_child_of_node(ports, port) {
+ if (of_node_name_eq(port, "port"))
+ num_ports++;
+ }
+
+ of_node_put(ports);
+
+ return num_ports;
+}
+
static void rcar_du_encoder_disable(struct drm_encoder *encoder)
{
struct rcar_du_encoder *renc = to_rcar_encoder(encoder);
@@ -127,6 +149,7 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
{
struct rcar_du_encoder *renc;
struct drm_encoder *encoder;
+ struct drm_panel *panel;
unsigned int encoder_type;
int ret;
@@ -193,6 +216,19 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
ret = rcar_du_hdmi_connector_init(rcdu, renc);
break;
+ case DRM_MODE_ENCODER_NONE:
+ if ((output == RCAR_DU_OUTPUT_DPAD0 ||
+ output == RCAR_DU_OUTPUT_DPAD1) &&
+ rcar_du_encoder_count_ports(con_node) == 1) {
+ panel = of_drm_find_panel(con_node);
+ if (!panel)
+ ret = -EPROBE_DEFER;
+ else
+ ret = rcar_du_rgb_connector_init(rcdu, renc,
+ panel);
+ }
+ break;
+
default:
ret = -EINVAL;
break;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.c b/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.c
new file mode 100644
index 000000000000..f62073e65f03
--- /dev/null
+++ b/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.c
@@ -0,0 +1,105 @@
+/*
+ * rcar_du_rgbcon.c -- R-Car Display Unit RGB Connector
+ *
+ * Copyright (C) 2013-2020 Renesas Electronics Corporation
+ *
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <drm/drmP.h>
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_crtc.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_panel.h>
+
+#include "rcar_du_drv.h"
+#include "rcar_du_encoder.h"
+#include "rcar_du_kms.h"
+#include "rcar_du_rgbcon.h"
+
+struct rcar_du_rgb_connector {
+ struct rcar_du_connector connector;
+ struct drm_panel *drmpanel;
+};
+
+#define to_rcar_rgb_connector(c) \
+ container_of(c, struct rcar_du_rgb_connector, connector.connector)
+
+static int rcar_du_rgb_connector_get_modes(struct drm_connector *connector)
+{
+ struct rcar_du_rgb_connector *rgbcon =
+ to_rcar_rgb_connector(connector);
+
+ return drm_panel_get_modes(rgbcon->drmpanel);
+}
+
+static const struct drm_connector_helper_funcs connector_helper_funcs = {
+ .get_modes = rcar_du_rgb_connector_get_modes,
+ .best_encoder = rcar_du_connector_best_encoder,
+};
+
+static enum drm_connector_status
+rcar_du_rgb_connector_detect(struct drm_connector *connector, bool force)
+{
+ return connector_status_connected;
+}
+
+static void rcar_du_rgb_connector_destroy(struct drm_connector *connector)
+{
+ struct rcar_du_rgb_connector *rgbcon =
+ to_rcar_rgb_connector(connector);
+
+ drm_panel_detach(rgbcon->drmpanel);
+ drm_connector_cleanup(connector);
+}
+
+static const struct drm_connector_funcs connector_funcs = {
+ .dpms = drm_atomic_helper_connector_dpms,
+ .reset = drm_atomic_helper_connector_reset,
+ .detect = rcar_du_rgb_connector_detect,
+ .fill_modes = drm_helper_probe_single_connector_modes,
+ .destroy = rcar_du_rgb_connector_destroy,
+ .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+ .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
+};
+
+int rcar_du_rgb_connector_init(struct rcar_du_device *rcdu,
+ struct rcar_du_encoder *renc,
+ struct drm_panel *drmpanel)
+{
+ struct drm_encoder *encoder = rcar_encoder_to_drm_encoder(renc);
+ struct rcar_du_rgb_connector *rgbcon;
+ struct drm_connector *connector;
+ int ret;
+
+ rgbcon = devm_kzalloc(rcdu->dev, sizeof(*rgbcon), GFP_KERNEL);
+ if (!rgbcon)
+ return -ENOMEM;
+
+ rgbcon->drmpanel = drmpanel;
+ connector = &rgbcon->connector.connector;
+ ret = drm_connector_init(rcdu->ddev, connector, &connector_funcs,
+ DRM_MODE_CONNECTOR_DPI);
+ if (ret < 0)
+ return ret;
+
+ drm_connector_helper_add(connector, &connector_helper_funcs);
+
+ connector->dpms = DRM_MODE_DPMS_OFF;
+ drm_object_property_set_value(&connector->base,
+ rcdu->ddev->mode_config.dpms_property,
+ DRM_MODE_DPMS_OFF);
+
+ ret = drm_mode_connector_attach_encoder(connector, encoder);
+ if (ret < 0)
+ return ret;
+
+ drm_panel_attach(rgbcon->drmpanel, connector);
+ rgbcon->connector.encoder = renc;
+
+ return 0;
+}
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.h b/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.h
new file mode 100644
index 000000000000..b3bfad52f589
--- /dev/null
+++ b/drivers/gpu/drm/rcar-du/rcar_du_rgbcon.h
@@ -0,0 +1,22 @@
+/*
+ * rcar_du_rgbcon.h -- R-Car Display Unit RGB Connector
+ *
+ * Copyright (C) 2013-2020 Renesas Electronics Corporation
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#ifndef __RCAR_DU_RGBCON_H__
+#define __RCAR_DU_RGBCON_H__
+
+struct rcar_du_device;
+struct rcar_du_encoder;
+
+int rcar_du_rgb_connector_init(struct rcar_du_device *rcdu,
+ struct rcar_du_encoder *renc,
+ struct drm_panel *drmpanel);
+
+#endif /* __RCAR_DU_RGBCON_H__ */
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5039): https://lists.cip-project.org/g/cip-dev/message/5039
Mute This Topic: https://lists.cip-project.org/mt/75842044/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 6/9] drm: rcar-du: Use the DRM panel API
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (4 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 5/9] drm: rcar-du: Support panels connected directly to the DPAD outputs Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 7/9] ARM: shmobile: defconfig: Enable frame buffer console for armadillo800eva Biju Das
` (3 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
commit bf7149f34241dcd6c95ea76b2b5ab4ff33f1c9b9 upstream.
Instead of parsing the panel device tree node manually, use the panel
API to delegate panel handling to a panel driver.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
[Removed all other changes except Kconfig. This config is
required for building simple panel driver]
---
drivers/gpu/drm/rcar-du/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index d4e0a39568f6..4261a302e051 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -21,6 +21,7 @@ config DRM_RCAR_HDMI
config DRM_RCAR_LVDS
bool "R-Car DU LVDS Encoder Support"
depends on DRM_RCAR_DU
+ select DRM_PANEL
depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST
help
Enable support for the R-Car Display Unit embedded LVDS encoders
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5035): https://lists.cip-project.org/g/cip-dev/message/5035
Mute This Topic: https://lists.cip-project.org/mt/75842040/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 7/9] ARM: shmobile: defconfig: Enable frame buffer console for armadillo800eva
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (5 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 6/9] drm: rcar-du: Use the DRM panel API Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 8/9] ARM: shmobile: defconfig: Enable support for panels from EDT Biju Das
` (2 subsequent siblings)
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
From: Geert Uytterhoeven <geert+renesas@glider.be>
commit af48156ff3a1762989627fba7c56e77743fc0fdc upstream.
Enabling the frame buffer device on armadillo800eva requires the board
staging code.
Also enable the frame buffer, so you will actually see output during
boot.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
[Removed staging related configs]
---
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 9e48febd5956..f21de1bec37c 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -161,6 +161,7 @@ CONFIG_FB_SH_MOBILE_MERAM=y
# CONFIG_BACKLIGHT_GENERIC is not set
CONFIG_BACKLIGHT_PWM=y
CONFIG_BACKLIGHT_AS3711=y
+CONFIG_FRAMEBUFFER_CONSOLE=y
CONFIG_SOUND=y
CONFIG_SND=y
CONFIG_SND_SOC=y
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5036): https://lists.cip-project.org/g/cip-dev/message/5036
Mute This Topic: https://lists.cip-project.org/mt/75842041/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 8/9] ARM: shmobile: defconfig: Enable support for panels from EDT
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (6 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 7/9] ARM: shmobile: defconfig: Enable frame buffer console for armadillo800eva Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 9/9] ARM: dts: iwg22d-sodimm: Enable LCD panel Biju Das
2020-07-28 20:40 ` [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Pavel Machek
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
commit a630a6121bef3e9598482a49eda6b1fa715385d6 upstream.
The iwg20d comes with an LCD panel from Emerging Display
Technologies Corporation (EDT), therefore enable what's
required to support it.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/1573660292-10629-12-git-send-email-fabrizio.castro@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
[Removed DRM_LVDS_CODEC configuration]
---
arch/arm/configs/shmobile_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index f21de1bec37c..151fad5c0b8d 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -98,6 +98,7 @@ CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_GPIO=y
# CONFIG_INPUT_MOUSE is not set
CONFIG_INPUT_TOUCHSCREEN=y
+CONFIG_TOUCHSCREEN_EDT_FT5X06=y
CONFIG_TOUCHSCREEN_ST1232=y
CONFIG_INPUT_MISC=y
CONFIG_INPUT_ADXL34X=y
@@ -155,6 +156,7 @@ CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_RCAR_DU=y
CONFIG_DRM_RCAR_HDMI=y
CONFIG_DRM_RCAR_LVDS=y
+CONFIG_DRM_PANEL_SIMPLE=y
CONFIG_FB_SH_MOBILE_LCDC=y
CONFIG_FB_SH_MOBILE_MERAM=y
# CONFIG_LCD_CLASS_DEVICE is not set
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5031): https://lists.cip-project.org/g/cip-dev/message/5031
Mute This Topic: https://lists.cip-project.org/mt/75842036/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* [cip-dev] [PATCH 4.4.y-cip 9/9] ARM: dts: iwg22d-sodimm: Enable LCD panel
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (7 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 8/9] ARM: shmobile: defconfig: Enable support for panels from EDT Biju Das
@ 2020-07-28 10:43 ` Biju Das
2020-07-28 20:40 ` [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Pavel Machek
9 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-28 10:43 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 3525 bytes --]
From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
commit 7f61dff1ed915c44845d6865d295853b1c39b6d7 upstream.
On the Generic SODIMM Development Platform there is an RGB LCD panel
directly connected to the DU output. It uses the TPU0 as backlight, one
GPIO pull-up configuration for power enable, R[2:7], G[2:7], B[2:7],
VSYNC, HSYNC, DU0_DISP and, DU0_CLK as inputs.
There is no encoder between the DU and the panel, therefore the default
connector driver is used.
The two variants of the iW-G22D should be mutually exclusive, therefore
this patch also disables the RGB LCD display when the HDMI extension board
is used.
Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
Link: https://lore.kernel.org/r/1583239490-8837-1-git-send-email-marian-cristian.rotariu.rb@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
[Removed enable-active-high property to make backlight to work on 4.4.]
---
.../dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 6 ++
arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 59 +++++++++++++++++++
2 files changed, 65 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
index 654d28b629e5..b01405fc1b49 100644
--- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
+++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts
@@ -109,6 +109,12 @@
};
};
+&lcd_panel {
+ status = "disabled";
+
+ /delete-node/ port;
+};
+
&pfc {
can1_pins: can1 {
groups = "can1_data_b";
diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
index 94e9088f6b40..1e331d1e414b 100644
--- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
+++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
@@ -33,6 +33,7 @@
/dts-v1/;
#include "r8a7745-iwg22m.dtsi"
+#include <dt-bindings/pwm/pwm.h>
/ {
model = "iWave Systems RainboW-G22D-SODIMM board based on RZ/G1E";
@@ -82,6 +83,48 @@
states = <3300000 1
1800000 0>;
};
+
+ vccq_panel: regulator-vccq-panel {
+ compatible = "regulator-fixed";
+ regulator-name = "Panel VccQ";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio1 13 GPIO_ACTIVE_LOW>;
+ };
+
+ backlight_lcd: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 4 8 16 32 64 128 255>;
+ default-brightness-level = <7>;
+ };
+
+ lcd_panel: lcd {
+ compatible = "edt,etm043080dh6gp";
+ power-supply = <&vccq_panel>;
+ backlight = <&backlight_lcd>;
+
+ port {
+ lcd_in: endpoint {
+ remote-endpoint = <&du_out_rgb0>;
+ };
+ };
+ };
+};
+
+&du {
+ pinctrl-0 = <&du0_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ ports {
+ port@0 {
+ endpoint {
+ remote-endpoint = <&lcd_in>;
+ };
+ };
+ };
};
&can0 {
@@ -117,11 +160,21 @@
};
&pfc {
+ backlight_pins: backlight {
+ groups = "tpu_to3_c";
+ function = "tpu";
+ };
+
can0_pins: can0 {
groups = "can0_data";
function = "can0";
};
+ du0_pins: du0 {
+ groups = "du0_rgb666", "du0_sync", "du0_disp", "du0_clk0_out";
+ function = "du0";
+ };
+
hscif1_pins: hscif1 {
groups = "hscif1_data", "hscif1_ctrl";
function = "hscif1";
@@ -233,6 +286,12 @@
shared-pin;
};
+&tpu {
+ pinctrl-0 = <&backlight_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&usbphy {
status = "okay";
};
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5040): https://lists.cip-project.org/g/cip-dev/message/5040
Mute This Topic: https://lists.cip-project.org/mt/75842045/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board
2020-07-28 10:43 [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Biju Das
` (8 preceding siblings ...)
2020-07-28 10:43 ` [cip-dev] [PATCH 4.4.y-cip 9/9] ARM: dts: iwg22d-sodimm: Enable LCD panel Biju Das
@ 2020-07-28 20:40 ` Pavel Machek
2020-07-29 6:11 ` Nobuhiro Iwamatsu
9 siblings, 1 reply; 13+ messages in thread
From: Pavel Machek @ 2020-07-28 20:40 UTC (permalink / raw)
To: Biju Das
Cc: cip-dev, Nobuhiro Iwamatsu, Chris Paterson, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi!
> Add LCD Panel support for iWave RZ/G1E board based on r8a7745 SoC.
>
> Backporting the panel patch as it is, requires drm bridge Api changes,
> which is not present at 4.4 kernel. So used the 4.4 rm framework to attach
> the simple panel driver with rgb connector driver. The rgb connector is
> based on the workdone for the lvds connector. The display panel binding
> patch is backported to 4.4 kernel,since the mainline uses yaml file and
> it conflict with corresponding .txt in 4.4 kernel.
>
> Other patches in this series are cherry picked from mainline.
I don't see anything wrong with this, so I'll test/apply it if noone objects.
I guess we could like patches for cip-kernel-config repository to actually enable this in
our testing...
Best regards,
Pavel
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5041): https://lists.cip-project.org/g/cip-dev/message/5041
Mute This Topic: https://lists.cip-project.org/mt/75842037/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board
2020-07-28 20:40 ` [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board Pavel Machek
@ 2020-07-29 6:11 ` Nobuhiro Iwamatsu
2020-07-29 6:57 ` Biju Das
0 siblings, 1 reply; 13+ messages in thread
From: Nobuhiro Iwamatsu @ 2020-07-29 6:11 UTC (permalink / raw)
To: pavel, biju.das.jz; +Cc: cip-dev, chris.paterson2, prabhakar.mahadev-lad.rj
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
Hi all,
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@denx.de]
> Sent: Wednesday, July 29, 2020 5:40 AM
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Chris Paterson <chris.paterson2@renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board
>
> Hi!
>
> > Add LCD Panel support for iWave RZ/G1E board based on r8a7745 SoC.
> >
> > Backporting the panel patch as it is, requires drm bridge Api changes,
> > which is not present at 4.4 kernel. So used the 4.4 rm framework to attach
> > the simple panel driver with rgb connector driver. The rgb connector is
> > based on the workdone for the lvds connector. The display panel binding
> > patch is backported to 4.4 kernel,since the mainline uses yaml file and
> > it conflict with corresponding .txt in 4.4 kernel.
> >
> > Other patches in this series are cherry picked from mainline.
>
> I don't see anything wrong with this, so I'll test/apply it if noone objects.
>
I didn't see any isseue this patche series.
The CI test is fine, so I commit.
> I guess we could like patches for cip-kernel-config repository to actually enable this in
> our testing...
+1.
>
> Best regards,
> Pavel
Best regards,
Nobuhiro
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5043): https://lists.cip-project.org/g/cip-dev/message/5043
Mute This Topic: https://lists.cip-project.org/mt/75842037/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [cip-dev] [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board
2020-07-29 6:11 ` Nobuhiro Iwamatsu
@ 2020-07-29 6:57 ` Biju Das
0 siblings, 0 replies; 13+ messages in thread
From: Biju Das @ 2020-07-29 6:57 UTC (permalink / raw)
To: nobuhiro1.iwamatsu, pavel; +Cc: cip-dev, Chris Paterson, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]
Hi All,
Thanks for the feedback.
> Subject: RE: [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E board
>
> Hi all,
>
> > -----Original Message-----
> > From: Pavel Machek [mailto:pavel@denx.de]
> > Sent: Wednesday, July 29, 2020 5:40 AM
> > To: Biju Das <biju.das.jz@bp.renesas.com>
> > Cc: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ
> ◯ＡＣＴ)
> > <nobuhiro1.iwamatsu@toshiba.co.jp>; Chris Paterson
> > <chris.paterson2@renesas.com>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Subject: Re: [PATCH 4.4.y-cip 0/9] Add LCD Panel support for RZ/G1E
> > board
> >
> > Hi!
> >
> > > Add LCD Panel support for iWave RZ/G1E board based on r8a7745 SoC.
> > >
> > > Backporting the panel patch as it is, requires drm bridge Api
> > > changes, which is not present at 4.4 kernel. So used the 4.4 rm
> > > framework to attach the simple panel driver with rgb connector
> > > driver. The rgb connector is based on the workdone for the lvds
> > > connector. The display panel binding patch is backported to 4.4
> > > kernel,since the mainline uses yaml file and it conflict with corresponding
> .txt in 4.4 kernel.
> > >
> > > Other patches in this series are cherry picked from mainline.
> >
> > I don't see anything wrong with this, so I'll test/apply it if noone objects.
> >
>
> I didn't see any isseue this patche series.
> The CI test is fine, so I commit.
>
> > I guess we could like patches for cip-kernel-config repository to
> > actually enable this in our testing...
>
> +1.
Sure I will send a new merge request for cip-kernel-config.
Cheers,
Biju
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5044): https://lists.cip-project.org/g/cip-dev/message/5044
Mute This Topic: https://lists.cip-project.org/mt/75842037/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 13+ messages in thread