* [PATCH] habanalabs: fix up absolute include instructions
@ 2020-07-28 17:18 Greg Kroah-Hartman
2020-07-28 22:09 ` Stephen Rothwell
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-28 17:18 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Stephen Rothwell, Oded Gabbay,
Omer Shpigelman, Tomer Tayar, Moti Haimovski, Ofir Bitton,
Ben Segal, Christine Gharzuzi, Pawel Piskorski
There's no need to try to be cute with the include file locations in the
Makefile, so just specify exactly where the files are.
Bonus is this fixes the problem of building with O= as well as trying to
just build the subdirectory alone.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: Omer Shpigelman <oshpigelman@habana.ai>
Cc: Tomer Tayar <ttayar@habana.ai>
Cc: Moti Haimovski <mhaimovski@habana.ai>
Cc: Ofir Bitton <obitton@habana.ai>
Cc: Ben Segal <bpsegal20@gmail.com>
Cc: Christine Gharzuzi <cgharzuzi@habana.ai>
Cc: Pawel Piskorski <ppiskorski@habana.ai>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/habanalabs/common/Makefile | 2 --
drivers/misc/habanalabs/common/debugfs.c | 2 +-
drivers/misc/habanalabs/common/firmware_if.c | 2 +-
drivers/misc/habanalabs/common/habanalabs.h | 4 ++--
drivers/misc/habanalabs/common/memory.c | 2 +-
drivers/misc/habanalabs/common/mmu.c | 2 +-
drivers/misc/habanalabs/common/pci.c | 2 +-
drivers/misc/habanalabs/gaudi/Makefile | 2 --
drivers/misc/habanalabs/gaudi/gaudi.c | 12 ++++++------
drivers/misc/habanalabs/gaudi/gaudiP.h | 10 +++++-----
drivers/misc/habanalabs/gaudi/gaudi_coresight.c | 6 +++---
drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c | 2 +-
drivers/misc/habanalabs/gaudi/gaudi_security.c | 2 +-
drivers/misc/habanalabs/goya/Makefile | 2 --
drivers/misc/habanalabs/goya/goya.c | 8 ++++----
drivers/misc/habanalabs/goya/goyaP.h | 12 ++++++------
drivers/misc/habanalabs/goya/goya_coresight.c | 6 +++---
drivers/misc/habanalabs/goya/goya_security.c | 2 +-
18 files changed, 37 insertions(+), 43 deletions(-)
diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
index 97d03b5c8683..b984bfa4face 100644
--- a/drivers/misc/habanalabs/common/Makefile
+++ b/drivers/misc/habanalabs/common/Makefile
@@ -1,6 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
-subdir-ccflags-y += -I$(src)/common
-
HL_COMMON_FILES := common/habanalabs_drv.o common/device.o common/context.o \
common/asid.o common/habanalabs_ioctl.o \
common/command_buffer.o common/hw_queue.o common/irq.o \
diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c
index 0bc036e01ee8..c50c6fc9e905 100644
--- a/drivers/misc/habanalabs/common/debugfs.c
+++ b/drivers/misc/habanalabs/common/debugfs.c
@@ -6,7 +6,7 @@
*/
#include "habanalabs.h"
-#include "include/hw_ip/mmu/mmu_general.h"
+#include "../include/hw_ip/mmu/mmu_general.h"
#include <linux/pci.h>
#include <linux/debugfs.h>
diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c
index 5981dbd8c6df..f70302cdab1b 100644
--- a/drivers/misc/habanalabs/common/firmware_if.c
+++ b/drivers/misc/habanalabs/common/firmware_if.c
@@ -6,7 +6,7 @@
*/
#include "habanalabs.h"
-#include "include/common/hl_boot_if.h"
+#include "../include/common/hl_boot_if.h"
#include <linux/firmware.h>
#include <linux/genalloc.h>
diff --git a/drivers/misc/habanalabs/common/habanalabs.h b/drivers/misc/habanalabs/common/habanalabs.h
index eb42aa5476a9..018d9d67e8e6 100644
--- a/drivers/misc/habanalabs/common/habanalabs.h
+++ b/drivers/misc/habanalabs/common/habanalabs.h
@@ -8,8 +8,8 @@
#ifndef HABANALABSP_H_
#define HABANALABSP_H_
-#include "include/common/armcp_if.h"
-#include "include/common/qman_if.h"
+#include "../include/common/armcp_if.h"
+#include "../include/common/qman_if.h"
#include <uapi/misc/habanalabs.h>
#include <linux/cdev.h>
diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
index e4e1693e5c6c..dce9273e557a 100644
--- a/drivers/misc/habanalabs/common/memory.c
+++ b/drivers/misc/habanalabs/common/memory.c
@@ -7,7 +7,7 @@
#include <uapi/misc/habanalabs.h>
#include "habanalabs.h"
-#include "include/hw_ip/mmu/mmu_general.h"
+#include "../include/hw_ip/mmu/mmu_general.h"
#include <linux/uaccess.h>
#include <linux/slab.h>
diff --git a/drivers/misc/habanalabs/common/mmu.c b/drivers/misc/habanalabs/common/mmu.c
index 04303950e630..edcc11d5eaf1 100644
--- a/drivers/misc/habanalabs/common/mmu.c
+++ b/drivers/misc/habanalabs/common/mmu.c
@@ -6,7 +6,7 @@
*/
#include "habanalabs.h"
-#include "include/hw_ip/mmu/mmu_general.h"
+#include "../include/hw_ip/mmu/mmu_general.h"
#include <linux/genalloc.h>
#include <linux/slab.h>
diff --git a/drivers/misc/habanalabs/common/pci.c b/drivers/misc/habanalabs/common/pci.c
index 1791f6623c69..7bd3737571f3 100644
--- a/drivers/misc/habanalabs/common/pci.c
+++ b/drivers/misc/habanalabs/common/pci.c
@@ -6,7 +6,7 @@
*/
#include "habanalabs.h"
-#include "include/hw_ip/pci/pci_general.h"
+#include "../include/hw_ip/pci/pci_general.h"
#include <linux/pci.h>
#include <linux/bitfield.h>
diff --git a/drivers/misc/habanalabs/gaudi/Makefile b/drivers/misc/habanalabs/gaudi/Makefile
index 75104ae74e2b..c9f4703cff24 100644
--- a/drivers/misc/habanalabs/gaudi/Makefile
+++ b/drivers/misc/habanalabs/gaudi/Makefile
@@ -1,5 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
-subdir-ccflags-y += -I$(src)/common
-
HL_GAUDI_FILES := gaudi/gaudi.o gaudi/gaudi_hwmgr.o gaudi/gaudi_security.o \
gaudi/gaudi_coresight.o
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 78fbff646f99..d4b3b995f69d 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -6,12 +6,12 @@
*/
#include "gaudiP.h"
-#include "include/hw_ip/mmu/mmu_general.h"
-#include "include/hw_ip/mmu/mmu_v1_1.h"
-#include "include/gaudi/gaudi_masks.h"
-#include "include/gaudi/gaudi_fw_if.h"
-#include "include/gaudi/gaudi_reg_map.h"
-#include "include/gaudi/gaudi_async_ids_map_extended.h"
+#include "../include/hw_ip/mmu/mmu_general.h"
+#include "../include/hw_ip/mmu/mmu_v1_1.h"
+#include "../include/gaudi/gaudi_masks.h"
+#include "../include/gaudi/gaudi_fw_if.h"
+#include "../include/gaudi/gaudi_reg_map.h"
+#include "../include/gaudi/gaudi_async_ids_map_extended.h"
#include <linux/module.h>
#include <linux/pci.h>
diff --git a/drivers/misc/habanalabs/gaudi/gaudiP.h b/drivers/misc/habanalabs/gaudi/gaudiP.h
index a94ab6a180f0..5dc99f6f0296 100644
--- a/drivers/misc/habanalabs/gaudi/gaudiP.h
+++ b/drivers/misc/habanalabs/gaudi/gaudiP.h
@@ -9,11 +9,11 @@
#define GAUDIP_H_
#include <uapi/misc/habanalabs.h>
-#include "habanalabs.h"
-#include "include/common/hl_boot_if.h"
-#include "include/gaudi/gaudi_packets.h"
-#include "include/gaudi/gaudi.h"
-#include "include/gaudi/gaudi_async_events.h"
+#include "../common/habanalabs.h"
+#include "../include/common/hl_boot_if.h"
+#include "../include/gaudi/gaudi_packets.h"
+#include "../include/gaudi/gaudi.h"
+#include "../include/gaudi/gaudi_async_events.h"
#define NUMBER_OF_EXT_HW_QUEUES 12
#define NUMBER_OF_CMPLT_QUEUES NUMBER_OF_EXT_HW_QUEUES
diff --git a/drivers/misc/habanalabs/gaudi/gaudi_coresight.c b/drivers/misc/habanalabs/gaudi/gaudi_coresight.c
index c32322cb1728..5673ee49819e 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi_coresight.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi_coresight.c
@@ -6,9 +6,9 @@
*/
#include "gaudiP.h"
-#include "include/gaudi/gaudi_coresight.h"
-#include "include/gaudi/asic_reg/gaudi_regs.h"
-#include "include/gaudi/gaudi_masks.h"
+#include "../include/gaudi/gaudi_coresight.h"
+#include "../include/gaudi/asic_reg/gaudi_regs.h"
+#include "../include/gaudi/gaudi_masks.h"
#include <uapi/misc/habanalabs.h>
#include <linux/coresight.h>
diff --git a/drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c b/drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c
index 6dd2c2a1cd70..1076b4932ce2 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi_hwmgr.c
@@ -6,7 +6,7 @@
*/
#include "gaudiP.h"
-#include "include/gaudi/gaudi_fw_if.h"
+#include "../include/gaudi/gaudi_fw_if.h"
void gaudi_set_pll_profile(struct hl_device *hdev, enum hl_pll_frequency freq)
{
diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c
index abdd5ed8f2cf..8d5d6ddee6ed 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi_security.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c
@@ -6,7 +6,7 @@
*/
#include "gaudiP.h"
-#include "include/gaudi/asic_reg/gaudi_regs.h"
+#include "../include/gaudi/asic_reg/gaudi_regs.h"
#define GAUDI_NUMBER_OF_RR_REGS 24
#define GAUDI_NUMBER_OF_LBW_RANGES 12
diff --git a/drivers/misc/habanalabs/goya/Makefile b/drivers/misc/habanalabs/goya/Makefile
index bd769083628e..b3f3b7b96683 100644
--- a/drivers/misc/habanalabs/goya/Makefile
+++ b/drivers/misc/habanalabs/goya/Makefile
@@ -1,5 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
-subdir-ccflags-y += -I$(src)
-
HL_GOYA_FILES := goya/goya.o goya/goya_security.o goya/goya_hwmgr.o \
goya/goya_coresight.o
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index a4dfea7556da..dedcd2211fb7 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -6,10 +6,10 @@
*/
#include "goyaP.h"
-#include "include/hw_ip/mmu/mmu_general.h"
-#include "include/hw_ip/mmu/mmu_v1_0.h"
-#include "include/goya/asic_reg/goya_masks.h"
-#include "include/goya/goya_reg_map.h"
+#include "../include/hw_ip/mmu/mmu_general.h"
+#include "../include/hw_ip/mmu/mmu_v1_0.h"
+#include "../include/goya/asic_reg/goya_masks.h"
+#include "../include/goya/goya_reg_map.h"
#include <linux/pci.h>
#include <linux/genalloc.h>
diff --git a/drivers/misc/habanalabs/goya/goyaP.h b/drivers/misc/habanalabs/goya/goyaP.h
index 9e674cf39fd9..bb7474ee9784 100644
--- a/drivers/misc/habanalabs/goya/goyaP.h
+++ b/drivers/misc/habanalabs/goya/goyaP.h
@@ -9,12 +9,12 @@
#define GOYAP_H_
#include <uapi/misc/habanalabs.h>
-#include "habanalabs.h"
-#include "include/common/hl_boot_if.h"
-#include "include/goya/goya_packets.h"
-#include "include/goya/goya.h"
-#include "include/goya/goya_async_events.h"
-#include "include/goya/goya_fw_if.h"
+#include "../common/habanalabs.h"
+#include "../include/common/hl_boot_if.h"
+#include "../include/goya/goya_packets.h"
+#include "../include/goya/goya.h"
+#include "../include/goya/goya_async_events.h"
+#include "../include/goya/goya_fw_if.h"
#define NUMBER_OF_CMPLT_QUEUES 5
#define NUMBER_OF_EXT_HW_QUEUES 5
diff --git a/drivers/misc/habanalabs/goya/goya_coresight.c b/drivers/misc/habanalabs/goya/goya_coresight.c
index 18e12e9d284b..b03912483de0 100644
--- a/drivers/misc/habanalabs/goya/goya_coresight.c
+++ b/drivers/misc/habanalabs/goya/goya_coresight.c
@@ -6,9 +6,9 @@
*/
#include "goyaP.h"
-#include "include/goya/goya_coresight.h"
-#include "include/goya/asic_reg/goya_regs.h"
-#include "include/goya/asic_reg/goya_masks.h"
+#include "../include/goya/goya_coresight.h"
+#include "../include/goya/asic_reg/goya_regs.h"
+#include "../include/goya/asic_reg/goya_masks.h"
#include <uapi/misc/habanalabs.h>
diff --git a/drivers/misc/habanalabs/goya/goya_security.c b/drivers/misc/habanalabs/goya/goya_security.c
index de8297001fea..14701836f92b 100644
--- a/drivers/misc/habanalabs/goya/goya_security.c
+++ b/drivers/misc/habanalabs/goya/goya_security.c
@@ -6,7 +6,7 @@
*/
#include "goyaP.h"
-#include "include/goya/asic_reg/goya_regs.h"
+#include "../include/goya/asic_reg/goya_regs.h"
/*
* goya_set_block_as_protected - set the given block as protected
--
2.27.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
@ 2020-07-28 22:09 ` Stephen Rothwell
2020-07-29 5:58 ` Greg Kroah-Hartman
2020-07-28 23:27 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2020-07-28 22:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, Oded Gabbay, Omer Shpigelman, Tomer Tayar,
Moti Haimovski, Ofir Bitton, Ben Segal, Christine Gharzuzi,
Pawel Piskorski
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Hi Greg,
On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
> index 97d03b5c8683..b984bfa4face 100644
> --- a/drivers/misc/habanalabs/common/Makefile
> +++ b/drivers/misc/habanalabs/common/Makefile
> @@ -1,6 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -subdir-ccflags-y += -I$(src)/common
I've seen oter places use
subdir-ccflags-y += -I$(srcdir)/$(src)/common
which would probably work as well. i.e. just change this in the
Makefiles rather than every source file.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
@ 2020-07-28 23:27 ` kernel test robot
2020-07-28 23:27 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-28 23:27 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: kbuild-all, Greg Kroah-Hartman, Oded Gabbay, Omer Shpigelman,
Tomer Tayar, Moti Haimovski, Ofir Bitton, Ben Segal,
Christine Gharzuzi, Pawel Piskorski
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to linux/master linus/master v5.8-rc7 next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 65a9bde6ed484880987a6d88de6e372eca52059f
config: x86_64-randconfig-m001-20200728 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/habanalabs/goya/goya.c:5228:5: warning: no previous prototype for 'goya_ctx_init' [-Wmissing-prototypes]
5228 | int goya_ctx_init(struct hl_ctx *ctx)
| ^~~~~~~~~~~~~
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning: no previous prototype for 'gaudi_ctx_init' [-Wmissing-prototypes]
6275 | int gaudi_ctx_init(struct hl_ctx *ctx)
| ^~~~~~~~~~~~~~
vim +/goya_ctx_init +5228 drivers/misc/habanalabs/goya/goya.c
f8c8c7d5f1b0ea Oded Gabbay 2019-02-16 5227
a04b7cd97eef13 Ofir Bitton 2020-07-13 @5228 int goya_ctx_init(struct hl_ctx *ctx)
a04b7cd97eef13 Ofir Bitton 2020-07-13 5229 {
a04b7cd97eef13 Ofir Bitton 2020-07-13 5230 return 0;
a04b7cd97eef13 Ofir Bitton 2020-07-13 5231 }
a04b7cd97eef13 Ofir Bitton 2020-07-13 5232
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31595 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
@ 2020-07-28 23:27 ` kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-28 23:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to linux/master linus/master v5.8-rc7 next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 65a9bde6ed484880987a6d88de6e372eca52059f
config: x86_64-randconfig-m001-20200728 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/habanalabs/goya/goya.c:5228:5: warning: no previous prototype for 'goya_ctx_init' [-Wmissing-prototypes]
5228 | int goya_ctx_init(struct hl_ctx *ctx)
| ^~~~~~~~~~~~~
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning: no previous prototype for 'gaudi_ctx_init' [-Wmissing-prototypes]
6275 | int gaudi_ctx_init(struct hl_ctx *ctx)
| ^~~~~~~~~~~~~~
vim +/goya_ctx_init +5228 drivers/misc/habanalabs/goya/goya.c
f8c8c7d5f1b0ea Oded Gabbay 2019-02-16 5227
a04b7cd97eef13 Ofir Bitton 2020-07-13 @5228 int goya_ctx_init(struct hl_ctx *ctx)
a04b7cd97eef13 Ofir Bitton 2020-07-13 5229 {
a04b7cd97eef13 Ofir Bitton 2020-07-13 5230 return 0;
a04b7cd97eef13 Ofir Bitton 2020-07-13 5231 }
a04b7cd97eef13 Ofir Bitton 2020-07-13 5232
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31595 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
@ 2020-07-29 0:03 ` kernel test robot
2020-07-28 23:27 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-29 0:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: kbuild-all, Greg Kroah-Hartman, Oded Gabbay, Omer Shpigelman,
Tomer Tayar, Moti Haimovski, Ofir Bitton, Ben Segal,
Christine Gharzuzi, Pawel Piskorski
[-- Attachment #1: Type: text/plain, Size: 6889 bytes --]
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to linux/master linus/master v5.8-rc7 next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 65a9bde6ed484880987a6d88de6e372eca52059f
config: i386-randconfig-s001-20200728 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-94-geb6779f6-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/misc/habanalabs/goya/goya.c:2778:17: sparse: sparse: cast removes address space '__iomem' of expression
>> drivers/misc/habanalabs/goya/goya.c:5228:5: sparse: sparse: symbol 'goya_ctx_init' was not declared. Should it be static?
drivers/misc/habanalabs/goya/goya.c:885:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:887:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:891:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:934:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1143:9: sparse: sparse: cast truncates bits from constant value (8000000000 becomes 0)
drivers/misc/habanalabs/goya/goya.c:1618:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1620:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1624:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1667:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1669:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1673:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1705:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1725:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1727:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1731:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1774:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1776:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1780:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1815:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:2339:27: sparse: sparse: cast truncates bits from constant value (7ff0000000 becomes f0000000)
drivers/misc/habanalabs/goya/goya.c:3422:26: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:3423:24: sparse: sparse: cast truncates bits from constant value (7ffc112ffc becomes fc112ffc)
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: sparse: sparse: symbol 'gaudi_ctx_init' was not declared. Should it be static?
drivers/misc/habanalabs/gaudi/gaudi.c:1807:26: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:1811:25: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:1815:26: sparse: sparse: cast truncates bits from constant value (7ffc494000 becomes fc494000)
drivers/misc/habanalabs/gaudi/gaudi.c:1819:25: sparse: sparse: cast truncates bits from constant value (7ffc492000 becomes fc492000)
drivers/misc/habanalabs/gaudi/gaudi.c:1858:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:1896:9: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:1969:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:1973:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2006:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2079:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:2083:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2118:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2193:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:2197:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2233:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2730:27: sparse: sparse: cast truncates bits from constant value (7ff0000000 becomes f0000000)
drivers/misc/habanalabs/gaudi/gaudi.c:6204:9: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33278 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
@ 2020-07-29 0:03 ` kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-29 0:03 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6966 bytes --]
Hi Greg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[cannot apply to linux/master linus/master v5.8-rc7 next-20200728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Greg-Kroah-Hartman/habanalabs-fix-up-absolute-include-instructions/20200729-012043
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 65a9bde6ed484880987a6d88de6e372eca52059f
config: i386-randconfig-s001-20200728 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-94-geb6779f6-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/misc/habanalabs/goya/goya.c:2778:17: sparse: sparse: cast removes address space '__iomem' of expression
>> drivers/misc/habanalabs/goya/goya.c:5228:5: sparse: sparse: symbol 'goya_ctx_init' was not declared. Should it be static?
drivers/misc/habanalabs/goya/goya.c:885:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:887:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:891:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:934:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1143:9: sparse: sparse: cast truncates bits from constant value (8000000000 becomes 0)
drivers/misc/habanalabs/goya/goya.c:1618:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1620:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1624:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1667:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1669:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1673:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1705:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1725:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1727:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1731:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1774:23: sparse: sparse: cast truncates bits from constant value (7ffc113000 becomes fc113000)
drivers/misc/habanalabs/goya/goya.c:1776:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:1780:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/goya/goya.c:1815:22: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:2339:27: sparse: sparse: cast truncates bits from constant value (7ff0000000 becomes f0000000)
drivers/misc/habanalabs/goya/goya.c:3422:26: sparse: sparse: cast truncates bits from constant value (7ffc112000 becomes fc112000)
drivers/misc/habanalabs/goya/goya.c:3423:24: sparse: sparse: cast truncates bits from constant value (7ffc112ffc becomes fc112ffc)
--
>> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: sparse: sparse: symbol 'gaudi_ctx_init' was not declared. Should it be static?
drivers/misc/habanalabs/gaudi/gaudi.c:1807:26: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:1811:25: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:1815:26: sparse: sparse: cast truncates bits from constant value (7ffc494000 becomes fc494000)
drivers/misc/habanalabs/gaudi/gaudi.c:1819:25: sparse: sparse: cast truncates bits from constant value (7ffc492000 becomes fc492000)
drivers/misc/habanalabs/gaudi/gaudi.c:1858:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:1896:9: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:1969:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:1973:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2006:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2079:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:2083:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2118:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2193:23: sparse: sparse: cast truncates bits from constant value (7ffc4f4000 becomes fc4f4000)
drivers/misc/habanalabs/gaudi/gaudi.c:2197:22: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
drivers/misc/habanalabs/gaudi/gaudi.c:2233:17: sparse: sparse: cast truncates bits from constant value (7ffc800040 becomes fc800040)
drivers/misc/habanalabs/gaudi/gaudi.c:2730:27: sparse: sparse: cast truncates bits from constant value (7ff0000000 becomes f0000000)
drivers/misc/habanalabs/gaudi/gaudi.c:6204:9: sparse: sparse: cast truncates bits from constant value (7ffc4f2000 becomes fc4f2000)
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33278 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [RFC PATCH] habanalabs: goya_ctx_init() can be static
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
@ 2020-07-29 0:03 ` kernel test robot
2020-07-28 23:27 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-29 0:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: kbuild-all, Greg Kroah-Hartman, Oded Gabbay, Omer Shpigelman,
Tomer Tayar, Moti Haimovski, Ofir Bitton, Ben Segal,
Christine Gharzuzi, Pawel Piskorski
Signed-off-by: kernel test robot <lkp@intel.com>
---
gaudi/gaudi.c | 2 +-
goya/goya.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index d4b3b995f69d8..00a0a7238d814 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -6272,7 +6272,7 @@ static enum hl_device_hw_state gaudi_get_hw_state(struct hl_device *hdev)
return RREG32(mmHW_STATE);
}
-int gaudi_ctx_init(struct hl_ctx *ctx)
+static int gaudi_ctx_init(struct hl_ctx *ctx)
{
return 0;
}
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index dedcd2211fb73..85030759b2afe 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5225,7 +5225,7 @@ static enum hl_device_hw_state goya_get_hw_state(struct hl_device *hdev)
return RREG32(mmHW_STATE);
}
-int goya_ctx_init(struct hl_ctx *ctx)
+static int goya_ctx_init(struct hl_ctx *ctx)
{
return 0;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [RFC PATCH] habanalabs: goya_ctx_init() can be static
@ 2020-07-29 0:03 ` kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2020-07-29 0:03 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
Signed-off-by: kernel test robot <lkp@intel.com>
---
gaudi/gaudi.c | 2 +-
goya/goya.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index d4b3b995f69d8..00a0a7238d814 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -6272,7 +6272,7 @@ static enum hl_device_hw_state gaudi_get_hw_state(struct hl_device *hdev)
return RREG32(mmHW_STATE);
}
-int gaudi_ctx_init(struct hl_ctx *ctx)
+static int gaudi_ctx_init(struct hl_ctx *ctx)
{
return 0;
}
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index dedcd2211fb73..85030759b2afe 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5225,7 +5225,7 @@ static enum hl_device_hw_state goya_get_hw_state(struct hl_device *hdev)
return RREG32(mmHW_STATE);
}
-int goya_ctx_init(struct hl_ctx *ctx)
+static int goya_ctx_init(struct hl_ctx *ctx)
{
return 0;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] habanalabs: fix up absolute include instructions
2020-07-28 22:09 ` Stephen Rothwell
@ 2020-07-29 5:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 9+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-29 5:58 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-kernel, Oded Gabbay, Omer Shpigelman, Tomer Tayar,
Moti Haimovski, Ofir Bitton, Ben Segal, Christine Gharzuzi,
Pawel Piskorski
On Wed, Jul 29, 2020 at 08:09:38AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
> > index 97d03b5c8683..b984bfa4face 100644
> > --- a/drivers/misc/habanalabs/common/Makefile
> > +++ b/drivers/misc/habanalabs/common/Makefile
> > @@ -1,6 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > -subdir-ccflags-y += -I$(src)/common
>
> I've seen oter places use
>
> subdir-ccflags-y += -I$(srcdir)/$(src)/common
>
> which would probably work as well. i.e. just change this in the
> Makefiles rather than every source file.
I hate seeing odd ccflags stuff in Makefiles as it can catch you "by
surprise" as to what exactly is happening when looking at .c code.
But yes, your change would also work.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-29 5:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
2020-07-28 22:09 ` Stephen Rothwell
2020-07-29 5:58 ` Greg Kroah-Hartman
2020-07-28 23:27 ` kernel test robot
2020-07-28 23:27 ` kernel test robot
2020-07-29 0:03 ` kernel test robot
2020-07-29 0:03 ` kernel test robot
2020-07-29 0:03 ` [RFC PATCH] habanalabs: goya_ctx_init() can be static kernel test robot
2020-07-29 0:03 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.