All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: rjw@rjwysocki.net, dietmar.eggemann@arm.com,
	catalin.marinas@arm.com, sudeep.holla@arm.com, will@kernel.org,
	linux@armlinux.org.uk, mingo@redhat.com, peterz@infradead.org,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH v2 7/7] cpufreq: make schedutil the default for arm and arm64
Date: Thu, 30 Jul 2020 10:24:08 +0530	[thread overview]
Message-ID: <20200730045408.cpsoymak33jl3bsm@vireshk-mac-ubuntu> (raw)
In-Reply-To: <20200722093732.14297-8-ionela.voinescu@arm.com>

On 22-07-20, 10:37, Ionela Voinescu wrote:
> From: Valentin Schneider <valentin.schneider@arm.com>
> 
> schedutil is already a hard-requirement for EAS, which has lead to making
> it default on arm (when CONFIG_BIG_LITTLE), see:
> 
>   commit 8fdcca8e254a ("cpufreq: Select schedutil when using big.LITTLE")
> 
> One thing worth pointing out is that schedutil isn't only relevant for
> asymmetric CPU capacity systems; for instance, schedutil is the only
> governor that honours util-clamp performance requests. Another good example
> of this is x86 switching to using it by default in:
> 
>   commit a00ec3874e7d ("cpufreq: intel_pstate: Select schedutil as the default governor")
> 
> Arguably it should be made the default for all architectures, but it seems
> better to wait for them to also gain frequency invariance powers. Make it
> the default for arm && arm64 for now.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index e91750132552..2c7171e0b001 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -37,7 +37,7 @@ config CPU_FREQ_STAT
>  choice
>  	prompt "Default CPUFreq governor"
>  	default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1100_CPUFREQ || ARM_SA1110_CPUFREQ
> -	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if BIG_LITTLE
> +	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
>  	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
>  	default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>  	help

Applied. Thanks.

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: linux-pm@vger.kernel.org, peterz@infradead.org,
	catalin.marinas@arm.com,
	Valentin Schneider <valentin.schneider@arm.com>,
	rjw@rjwysocki.net, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] cpufreq: make schedutil the default for arm and arm64
Date: Thu, 30 Jul 2020 10:24:08 +0530	[thread overview]
Message-ID: <20200730045408.cpsoymak33jl3bsm@vireshk-mac-ubuntu> (raw)
In-Reply-To: <20200722093732.14297-8-ionela.voinescu@arm.com>

On 22-07-20, 10:37, Ionela Voinescu wrote:
> From: Valentin Schneider <valentin.schneider@arm.com>
> 
> schedutil is already a hard-requirement for EAS, which has lead to making
> it default on arm (when CONFIG_BIG_LITTLE), see:
> 
>   commit 8fdcca8e254a ("cpufreq: Select schedutil when using big.LITTLE")
> 
> One thing worth pointing out is that schedutil isn't only relevant for
> asymmetric CPU capacity systems; for instance, schedutil is the only
> governor that honours util-clamp performance requests. Another good example
> of this is x86 switching to using it by default in:
> 
>   commit a00ec3874e7d ("cpufreq: intel_pstate: Select schedutil as the default governor")
> 
> Arguably it should be made the default for all architectures, but it seems
> better to wait for them to also gain frequency invariance powers. Make it
> the default for arm && arm64 for now.
> 
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index e91750132552..2c7171e0b001 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -37,7 +37,7 @@ config CPU_FREQ_STAT
>  choice
>  	prompt "Default CPUFreq governor"
>  	default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1100_CPUFREQ || ARM_SA1110_CPUFREQ
> -	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if BIG_LITTLE
> +	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
>  	default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
>  	default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>  	help

Applied. Thanks.

-- 
viresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-30  4:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  9:37 [PATCH v2 0/7] cpufreq: improve frequency invariance support Ionela Voinescu
2020-07-22  9:37 ` Ionela Voinescu
2020-07-22  9:37 ` [PATCH v2 1/7] cpufreq: move invariance setter calls in cpufreq core Ionela Voinescu
2020-07-22  9:37   ` Ionela Voinescu
2020-07-27 13:48   ` Rafael J. Wysocki
2020-07-27 13:48     ` Rafael J. Wysocki
2020-07-29  9:03     ` Ionela Voinescu
2020-07-29  9:03       ` Ionela Voinescu
2020-07-30  3:41     ` Viresh Kumar
2020-07-30  3:41       ` Viresh Kumar
2020-08-03 13:26       ` Ionela Voinescu
2020-08-03 13:26         ` Ionela Voinescu
2020-08-03 13:46         ` Rafael J. Wysocki
2020-08-03 13:46           ` Rafael J. Wysocki
2020-08-03 14:16           ` Ionela Voinescu
2020-08-03 14:16             ` Ionela Voinescu
2020-07-22  9:37 ` [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Ionela Voinescu
2020-07-22  9:37   ` Ionela Voinescu
2020-07-27 13:52   ` Rafael J. Wysocki
2020-07-27 13:52     ` Rafael J. Wysocki
2020-07-29  9:14     ` Ionela Voinescu
2020-07-29  9:14       ` Ionela Voinescu
2020-07-30  4:13   ` Viresh Kumar
2020-07-30  4:13     ` Viresh Kumar
2020-08-03 13:58     ` Ionela Voinescu
2020-08-03 13:58       ` Ionela Voinescu
2020-08-04  6:26       ` Viresh Kumar
2020-08-04  6:26         ` Viresh Kumar
2020-08-05 10:35         ` Ionela Voinescu
2020-08-05 10:35           ` Ionela Voinescu
2020-07-22  9:37 ` [PATCH v2 3/7] arch_topology: disable frequency invariance for CONFIG_BL_SWITCHER Ionela Voinescu
2020-07-22  9:37   ` Ionela Voinescu
2020-07-30  4:24   ` Viresh Kumar
2020-07-30  4:24     ` Viresh Kumar
2020-07-30 10:29     ` Dietmar Eggemann
2020-07-30 10:29       ` Dietmar Eggemann
2020-07-31 15:48       ` Sudeep Holla
2020-07-31 15:48         ` Sudeep Holla
2020-08-03 14:39         ` Ionela Voinescu
2020-08-03 14:39           ` Ionela Voinescu
2020-08-04  6:30       ` Viresh Kumar
2020-08-04  6:30         ` Viresh Kumar
2020-08-10  9:01         ` Ionela Voinescu
2020-08-10  9:01           ` Ionela Voinescu
2020-07-22  9:37 ` [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Ionela Voinescu
2020-07-22  9:37   ` Ionela Voinescu
2020-07-27 14:02   ` Rafael J. Wysocki
2020-07-27 14:02     ` Rafael J. Wysocki
2020-07-29 14:39     ` Ionela Voinescu
2020-07-29 14:39       ` Ionela Voinescu
2020-07-30  4:43   ` Viresh Kumar
2020-07-30  4:43     ` Viresh Kumar
2020-08-03 15:24     ` Ionela Voinescu
2020-08-03 15:24       ` Ionela Voinescu
2020-08-04  6:46       ` Viresh Kumar
2020-08-04  6:46         ` Viresh Kumar
2020-08-05 10:35         ` Ionela Voinescu
2020-08-05 10:35           ` Ionela Voinescu
2020-07-22  9:37 ` [PATCH v2 5/7] arch_topology,cpufreq,sched/core: constify arch_* cpumasks Ionela Voinescu
2020-07-22  9:37   ` [PATCH v2 5/7] arch_topology, cpufreq, sched/core: " Ionela Voinescu
2020-07-30 11:43   ` [PATCH v2 5/7] arch_topology,cpufreq,sched/core: " Catalin Marinas
2020-07-30 11:43     ` [PATCH v2 5/7] arch_topology, cpufreq, sched/core: " Catalin Marinas
2020-07-22  9:37 ` [PATCH v2 6/7] arch_topology,arm,arm64: define arch_scale_freq_invariant() Ionela Voinescu
2020-07-22  9:37   ` [PATCH v2 6/7] arch_topology, arm, arm64: " Ionela Voinescu
2020-07-30 11:44   ` [PATCH v2 6/7] arch_topology,arm,arm64: " Catalin Marinas
2020-07-30 11:44     ` Catalin Marinas
2020-07-22  9:37 ` [PATCH v2 7/7] cpufreq: make schedutil the default for arm and arm64 Ionela Voinescu
2020-07-22  9:37   ` Ionela Voinescu
2020-07-30  4:54   ` Viresh Kumar [this message]
2020-07-30  4:54     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730045408.cpsoymak33jl3bsm@vireshk-mac-ubuntu \
    --to=viresh.kumar@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=valentin.schneider@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.