From: Ionela Voinescu <ionela.voinescu@arm.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: rjw@rjwysocki.net, dietmar.eggemann@arm.com, catalin.marinas@arm.com, sudeep.holla@arm.com, will@kernel.org, linux@armlinux.org.uk, mingo@redhat.com, peterz@infradead.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Date: Wed, 5 Aug 2020 11:35:05 +0100 [thread overview] Message-ID: <20200805103452.GA4817@arm.com> (raw) In-Reply-To: <20200804062611.6jpra73hmhybdw3i@vireshk-mac-ubuntu> On Tuesday 04 Aug 2020 at 11:56:11 (+0530), Viresh Kumar wrote: [..] > > > > - In __target_index(), cpufreq_freq_transition_end() is called only for > > > > drivers that have synchronous notifications enabled. There is only one > > > > driver that disables them, > > > > > > > > drivers/cpufreq/powernow-k8.c:1142: .flags = CPUFREQ_ASYNC_NOTIFICATION, > > > > > > > > which is deprecated. > > > > > > I don't think this is deprecated. > > Heh, maybe I misunderstood. I thought you are talking about the flag, > while you were talking about the driver. > > > Sorry, possibly 'deprecated' is a strong word. > > > > As far as I knew acpi_cpufreq was recommended more recently for K8/K10 > > CPUs so that's why I decided not to create a special case for it, also > > considering that it was not supporting cpufreq-based frequency > > invariance to begin with. > > > > We could support this as well by having a call to arch_set_freq_scale() > > on the else path in __target_index(). But given that there was only this > > one user of CPUFREQ_ASYNC_NOTIFICATION, I thought I'd propose this simpler > > version first. > > > > Let me know if my reasoning is wrong. > > Nevertheless, I don't think you need to mention this detail in > changelog for powernow-k8 as cpufreq_freq_transition_end() does get > called for it as well, by the driver instead of the core. > Agreed! Many thanks, Ionela. > -- > viresh
WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Date: Wed, 5 Aug 2020 11:35:05 +0100 [thread overview] Message-ID: <20200805103452.GA4817@arm.com> (raw) In-Reply-To: <20200804062611.6jpra73hmhybdw3i@vireshk-mac-ubuntu> On Tuesday 04 Aug 2020 at 11:56:11 (+0530), Viresh Kumar wrote: [..] > > > > - In __target_index(), cpufreq_freq_transition_end() is called only for > > > > drivers that have synchronous notifications enabled. There is only one > > > > driver that disables them, > > > > > > > > drivers/cpufreq/powernow-k8.c:1142: .flags = CPUFREQ_ASYNC_NOTIFICATION, > > > > > > > > which is deprecated. > > > > > > I don't think this is deprecated. > > Heh, maybe I misunderstood. I thought you are talking about the flag, > while you were talking about the driver. > > > Sorry, possibly 'deprecated' is a strong word. > > > > As far as I knew acpi_cpufreq was recommended more recently for K8/K10 > > CPUs so that's why I decided not to create a special case for it, also > > considering that it was not supporting cpufreq-based frequency > > invariance to begin with. > > > > We could support this as well by having a call to arch_set_freq_scale() > > on the else path in __target_index(). But given that there was only this > > one user of CPUFREQ_ASYNC_NOTIFICATION, I thought I'd propose this simpler > > version first. > > > > Let me know if my reasoning is wrong. > > Nevertheless, I don't think you need to mention this detail in > changelog for powernow-k8 as cpufreq_freq_transition_end() does get > called for it as well, by the driver instead of the core. > Agreed! Many thanks, Ionela. > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-05 17:21 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 9:37 [PATCH v2 0/7] cpufreq: improve frequency invariance support Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 1/7] cpufreq: move invariance setter calls in cpufreq core Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-27 13:48 ` Rafael J. Wysocki 2020-07-27 13:48 ` Rafael J. Wysocki 2020-07-29 9:03 ` Ionela Voinescu 2020-07-29 9:03 ` Ionela Voinescu 2020-07-30 3:41 ` Viresh Kumar 2020-07-30 3:41 ` Viresh Kumar 2020-08-03 13:26 ` Ionela Voinescu 2020-08-03 13:26 ` Ionela Voinescu 2020-08-03 13:46 ` Rafael J. Wysocki 2020-08-03 13:46 ` Rafael J. Wysocki 2020-08-03 14:16 ` Ionela Voinescu 2020-08-03 14:16 ` Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-27 13:52 ` Rafael J. Wysocki 2020-07-27 13:52 ` Rafael J. Wysocki 2020-07-29 9:14 ` Ionela Voinescu 2020-07-29 9:14 ` Ionela Voinescu 2020-07-30 4:13 ` Viresh Kumar 2020-07-30 4:13 ` Viresh Kumar 2020-08-03 13:58 ` Ionela Voinescu 2020-08-03 13:58 ` Ionela Voinescu 2020-08-04 6:26 ` Viresh Kumar 2020-08-04 6:26 ` Viresh Kumar 2020-08-05 10:35 ` Ionela Voinescu [this message] 2020-08-05 10:35 ` Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 3/7] arch_topology: disable frequency invariance for CONFIG_BL_SWITCHER Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-30 4:24 ` Viresh Kumar 2020-07-30 4:24 ` Viresh Kumar 2020-07-30 10:29 ` Dietmar Eggemann 2020-07-30 10:29 ` Dietmar Eggemann 2020-07-31 15:48 ` Sudeep Holla 2020-07-31 15:48 ` Sudeep Holla 2020-08-03 14:39 ` Ionela Voinescu 2020-08-03 14:39 ` Ionela Voinescu 2020-08-04 6:30 ` Viresh Kumar 2020-08-04 6:30 ` Viresh Kumar 2020-08-10 9:01 ` Ionela Voinescu 2020-08-10 9:01 ` Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-27 14:02 ` Rafael J. Wysocki 2020-07-27 14:02 ` Rafael J. Wysocki 2020-07-29 14:39 ` Ionela Voinescu 2020-07-29 14:39 ` Ionela Voinescu 2020-07-30 4:43 ` Viresh Kumar 2020-07-30 4:43 ` Viresh Kumar 2020-08-03 15:24 ` Ionela Voinescu 2020-08-03 15:24 ` Ionela Voinescu 2020-08-04 6:46 ` Viresh Kumar 2020-08-04 6:46 ` Viresh Kumar 2020-08-05 10:35 ` Ionela Voinescu 2020-08-05 10:35 ` Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 5/7] arch_topology,cpufreq,sched/core: constify arch_* cpumasks Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 5/7] arch_topology, cpufreq, sched/core: " Ionela Voinescu 2020-07-30 11:43 ` [PATCH v2 5/7] arch_topology,cpufreq,sched/core: " Catalin Marinas 2020-07-30 11:43 ` [PATCH v2 5/7] arch_topology, cpufreq, sched/core: " Catalin Marinas 2020-07-22 9:37 ` [PATCH v2 6/7] arch_topology,arm,arm64: define arch_scale_freq_invariant() Ionela Voinescu 2020-07-22 9:37 ` [PATCH v2 6/7] arch_topology, arm, arm64: " Ionela Voinescu 2020-07-30 11:44 ` [PATCH v2 6/7] arch_topology,arm,arm64: " Catalin Marinas 2020-07-30 11:44 ` Catalin Marinas 2020-07-22 9:37 ` [PATCH v2 7/7] cpufreq: make schedutil the default for arm and arm64 Ionela Voinescu 2020-07-22 9:37 ` Ionela Voinescu 2020-07-30 4:54 ` Viresh Kumar 2020-07-30 4:54 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200805103452.GA4817@arm.com \ --to=ionela.voinescu@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dietmar.eggemann@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=viresh.kumar@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.