All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	open list <linux-kernel@vger.kernel.org>,
	lkft-triage@lists.linaro.org, Emese Revfy <re.emese@gmail.com>,
	hsinyi@chromium.org, Will Deacon <will@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'?
Date: Fri, 31 Jul 2020 04:16:31 +0200	[thread overview]
Message-ID: <20200731021631.GA8247@1wt.eu> (raw)
In-Reply-To: <CAHk-=whX7gPBn+jthX8bbfz9kU+0CbYwTxbASwPRCZ1bhVqrOw@mail.gmail.com>

On Thu, Jul 30, 2020 at 12:40:01PM -0700, Linus Torvalds wrote:
> On Thu, Jul 30, 2020 at 12:05 PM Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
> >
> > FYI. Below diff seems fixes build:
> 
> Thanks, I'll do that instead, it looks like the right thing to do regardless.
> 
> Mind sending me a sign-off for it (and commit message would be lovely
> too, but I can make something up)? Yeah, it's just a one-liner, but
> let's do this right.

Don't you want to take Mark's patch anyway in addition to all this ? In
case anyone meets yet another build issue, they'd have more luck trying
to revert any other patch. Right now if they revert one, it breaks the
build in a different way and doesn't help much.

Willy

WARNING: multiple messages have this Message-ID (diff)
From: Willy Tarreau <w@1wt.eu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	open list <linux-kernel@vger.kernel.org>,
	lkft-triage@lists.linaro.org, Mark Brown <broonie@kernel.org>,
	hsinyi@chromium.org, Emese Revfy <re.emese@gmail.com>,
	Will Deacon <will@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'?
Date: Fri, 31 Jul 2020 04:16:31 +0200	[thread overview]
Message-ID: <20200731021631.GA8247@1wt.eu> (raw)
In-Reply-To: <CAHk-=whX7gPBn+jthX8bbfz9kU+0CbYwTxbASwPRCZ1bhVqrOw@mail.gmail.com>

On Thu, Jul 30, 2020 at 12:40:01PM -0700, Linus Torvalds wrote:
> On Thu, Jul 30, 2020 at 12:05 PM Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
> >
> > FYI. Below diff seems fixes build:
> 
> Thanks, I'll do that instead, it looks like the right thing to do regardless.
> 
> Mind sending me a sign-off for it (and commit message would be lovely
> too, but I can make something up)? Yeah, it's just a one-liner, but
> let's do this right.

Don't you want to take Mark's patch anyway in addition to all this ? In
case anyone meets yet another build issue, they'd have more luck trying
to revert any other patch. Right now if they revert one, it breaks the
build in a different way and doesn't help much.

Willy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-31  2:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 10:55 arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’? Naresh Kamboju
2020-07-30 10:55 ` Naresh Kamboju
2020-07-30 11:15 ` Stephen Rothwell
2020-07-30 11:15   ` Stephen Rothwell
2020-07-30 18:46   ` Grygorii Strashko
2020-07-30 18:46     ` Grygorii Strashko
2020-07-30 18:56     ` Linus Torvalds
2020-07-30 19:04       ` Grygorii Strashko
2020-07-30 19:04         ` Grygorii Strashko
2020-07-30 19:40         ` Linus Torvalds
2020-07-30 19:43           ` Grygorii Strashko
2020-07-30 19:43             ` Grygorii Strashko
2020-07-31  2:16           ` Willy Tarreau [this message]
2020-07-31  2:16             ` arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'? Willy Tarreau
2020-07-31  5:25             ` Linus Torvalds
2020-07-31  5:25               ` Linus Torvalds
2020-07-31  5:46               ` Willy Tarreau
2020-07-31  5:46                 ` Willy Tarreau
2020-07-31  7:52               ` Will Deacon
2020-07-31  7:52                 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731021631.GA8247@1wt.eu \
    --to=w@1wt.eu \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hsinyi@chromium.org \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=mark.rutland@arm.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=re.emese@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.