From: Grygorii Strashko <grygorii.strashko@ti.com> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Naresh Kamboju <naresh.kamboju@linaro.org>, Mark Rutland <mark.rutland@arm.com>, "Theodore Ts'o" <tytso@mit.edu>, Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Mark Brown <broonie@kernel.org>, Richard Henderson <richard.henderson@linaro.org>, open list <linux-kernel@vger.kernel.org>, <lkft-triage@lists.linaro.org>, Emese Revfy <re.emese@gmail.com>, <hsinyi@chromium.org>, Will Deacon <will@kernel.org>, Willy Tarreau <w@1wt.eu>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’? Date: Thu, 30 Jul 2020 22:43:39 +0300 [thread overview] Message-ID: <f6cd5c6a-8779-e17d-2827-cbf531c969e2@ti.com> (raw) In-Reply-To: <CAHk-=whX7gPBn+jthX8bbfz9kU+0CbYwTxbASwPRCZ1bhVqrOw@mail.gmail.com> On 30/07/2020 22:40, Linus Torvalds wrote: > On Thu, Jul 30, 2020 at 12:05 PM Grygorii Strashko > <grygorii.strashko@ti.com> wrote: >> >> FYI. Below diff seems fixes build: > > Thanks, I'll do that instead, it looks like the right thing to do regardless. > > Mind sending me a sign-off for it (and commit message would be lovely > too, but I can make something up)? Yeah, it's just a one-liner, but > let's do this right. I've also boot-tested it on Keystone 2 platforms. Best regards, grygorii --- From fa1238a8e4b7c603fcc0fb5f6169c212035aef4f Mon Sep 17 00:00:00 2001 From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Thu, 30 Jul 2020 22:05:01 +0300 Subject: [PATCH] ARM: percpu.h: fix build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix build error for the case: defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6) config: keystone_defconfig CC arch/arm/kernel/signal.o In file included from ../include/linux/random.h:14, from ../arch/arm/kernel/signal.c:8: ../arch/arm/include/asm/percpu.h: In function ‘__my_cpu_offset’: ../arch/arm/include/asm/percpu.h:29:34: error: ‘current_stack_pointer’ undeclared (first use in this function); did you mean ‘user_stack_pointer’? : "Q" (*(const unsigned long *)current_stack_pointer)); ^~~~~~~~~~~~~~~~~~~~~ user_stack_pointer Fixes: f227e3ec3b5c ("random32: update the net random state on interrupt and activity") Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm/include/asm/percpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h index f44f448537f2..1a3eedbac4a2 100644 --- a/arch/arm/include/asm/percpu.h +++ b/arch/arm/include/asm/percpu.h @@ -5,6 +5,8 @@ #ifndef _ASM_ARM_PERCPU_H_ #define _ASM_ARM_PERCPU_H_ +#include <asm/thread_info.h> + /* * Same as asm-generic/percpu.h, except that we store the per cpu offset * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7 -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mark Rutland <mark.rutland@arm.com>, Stephen Rothwell <sfr@canb.auug.org.au>, Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>, Catalin Marinas <catalin.marinas@arm.com>, Naresh Kamboju <naresh.kamboju@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, open list <linux-kernel@vger.kernel.org>, lkft-triage@lists.linaro.org, Mark Brown <broonie@kernel.org>, hsinyi@chromium.org, Emese Revfy <re.emese@gmail.com>, Will Deacon <will@kernel.org>, Willy Tarreau <w@1wt.eu>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’? Date: Thu, 30 Jul 2020 22:43:39 +0300 [thread overview] Message-ID: <f6cd5c6a-8779-e17d-2827-cbf531c969e2@ti.com> (raw) In-Reply-To: <CAHk-=whX7gPBn+jthX8bbfz9kU+0CbYwTxbASwPRCZ1bhVqrOw@mail.gmail.com> On 30/07/2020 22:40, Linus Torvalds wrote: > On Thu, Jul 30, 2020 at 12:05 PM Grygorii Strashko > <grygorii.strashko@ti.com> wrote: >> >> FYI. Below diff seems fixes build: > > Thanks, I'll do that instead, it looks like the right thing to do regardless. > > Mind sending me a sign-off for it (and commit message would be lovely > too, but I can make something up)? Yeah, it's just a one-liner, but > let's do this right. I've also boot-tested it on Keystone 2 platforms. Best regards, grygorii --- From fa1238a8e4b7c603fcc0fb5f6169c212035aef4f Mon Sep 17 00:00:00 2001 From: Grygorii Strashko <grygorii.strashko@ti.com> Date: Thu, 30 Jul 2020 22:05:01 +0300 Subject: [PATCH] ARM: percpu.h: fix build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix build error for the case: defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6) config: keystone_defconfig CC arch/arm/kernel/signal.o In file included from ../include/linux/random.h:14, from ../arch/arm/kernel/signal.c:8: ../arch/arm/include/asm/percpu.h: In function ‘__my_cpu_offset’: ../arch/arm/include/asm/percpu.h:29:34: error: ‘current_stack_pointer’ undeclared (first use in this function); did you mean ‘user_stack_pointer’? : "Q" (*(const unsigned long *)current_stack_pointer)); ^~~~~~~~~~~~~~~~~~~~~ user_stack_pointer Fixes: f227e3ec3b5c ("random32: update the net random state on interrupt and activity") Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm/include/asm/percpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h index f44f448537f2..1a3eedbac4a2 100644 --- a/arch/arm/include/asm/percpu.h +++ b/arch/arm/include/asm/percpu.h @@ -5,6 +5,8 @@ #ifndef _ASM_ARM_PERCPU_H_ #define _ASM_ARM_PERCPU_H_ +#include <asm/thread_info.h> + /* * Same as asm-generic/percpu.h, except that we store the per cpu offset * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7 -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-30 19:44 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-30 10:55 arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’? Naresh Kamboju 2020-07-30 10:55 ` Naresh Kamboju 2020-07-30 11:15 ` Stephen Rothwell 2020-07-30 11:15 ` Stephen Rothwell 2020-07-30 18:46 ` Grygorii Strashko 2020-07-30 18:46 ` Grygorii Strashko 2020-07-30 18:56 ` Linus Torvalds 2020-07-30 19:04 ` Grygorii Strashko 2020-07-30 19:04 ` Grygorii Strashko 2020-07-30 19:40 ` Linus Torvalds 2020-07-30 19:43 ` Grygorii Strashko [this message] 2020-07-30 19:43 ` Grygorii Strashko 2020-07-31 2:16 ` arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'? Willy Tarreau 2020-07-31 2:16 ` Willy Tarreau 2020-07-31 5:25 ` Linus Torvalds 2020-07-31 5:25 ` Linus Torvalds 2020-07-31 5:46 ` Willy Tarreau 2020-07-31 5:46 ` Willy Tarreau 2020-07-31 7:52 ` Will Deacon 2020-07-31 7:52 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f6cd5c6a-8779-e17d-2827-cbf531c969e2@ti.com \ --to=grygorii.strashko@ti.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=hsinyi@chromium.org \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkft-triage@lists.linaro.org \ --cc=mark.rutland@arm.com \ --cc=naresh.kamboju@linaro.org \ --cc=re.emese@gmail.com \ --cc=richard.henderson@linaro.org \ --cc=sfr@canb.auug.org.au \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=w@1wt.eu \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.