From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> To: netdev@vger.kernel.org Cc: bridge@lists.linux-foundation.org, roopa@cumulusnetworks.com, davem@davemloft.net, Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Subject: [PATCH net] net: bridge: clear bridge's private skb space on xmit Date: Fri, 31 Jul 2020 19:26:16 +0300 [thread overview] Message-ID: <20200731162616.345380-1-nikolay@cumulusnetworks.com> (raw) We need to clear all of the bridge private skb variables as they can be stale due to the packet being recirculated through the stack and then transmitted through the bridge device. Similar memset is already done on bridge's input. We've seen cases where proxyarp_replied was 1 on routed multicast packets transmitted through the bridge to ports with neigh suppress which were getting dropped. Same thing can in theory happen with the port isolation bit as well. Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> --- net/bridge/br_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 8c7b78f8bc23..9a2fb4aa1a10 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -36,6 +36,8 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) const unsigned char *dest; u16 vid = 0; + memset(skb->cb, 0, sizeof(struct br_input_skb_cb)); + rcu_read_lock(); nf_ops = rcu_dereference(nf_br_ops); if (nf_ops && nf_ops->br_dev_xmit_hook(skb)) { -- 2.25.4
WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> To: netdev@vger.kernel.org Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, davem@davemloft.net Subject: [Bridge] [PATCH net] net: bridge: clear bridge's private skb space on xmit Date: Fri, 31 Jul 2020 19:26:16 +0300 [thread overview] Message-ID: <20200731162616.345380-1-nikolay@cumulusnetworks.com> (raw) We need to clear all of the bridge private skb variables as they can be stale due to the packet being recirculated through the stack and then transmitted through the bridge device. Similar memset is already done on bridge's input. We've seen cases where proxyarp_replied was 1 on routed multicast packets transmitted through the bridge to ports with neigh suppress which were getting dropped. Same thing can in theory happen with the port isolation bit as well. Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> --- net/bridge/br_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 8c7b78f8bc23..9a2fb4aa1a10 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -36,6 +36,8 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) const unsigned char *dest; u16 vid = 0; + memset(skb->cb, 0, sizeof(struct br_input_skb_cb)); + rcu_read_lock(); nf_ops = rcu_dereference(nf_br_ops); if (nf_ops && nf_ops->br_dev_xmit_hook(skb)) { -- 2.25.4
next reply other threads:[~2020-07-31 16:26 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-31 16:26 Nikolay Aleksandrov [this message] 2020-07-31 16:26 ` [Bridge] [PATCH net] net: bridge: clear bridge's private skb space on xmit Nikolay Aleksandrov 2020-07-31 17:27 ` David Ahern 2020-07-31 17:27 ` [Bridge] " David Ahern 2020-07-31 17:37 ` Nikolay Aleksandrov 2020-07-31 17:37 ` [Bridge] " Nikolay Aleksandrov 2020-07-31 17:38 ` Nikolay Aleksandrov 2020-07-31 17:38 ` [Bridge] " Nikolay Aleksandrov 2020-07-31 17:51 ` Nikolay Aleksandrov 2020-07-31 17:51 ` [Bridge] " Nikolay Aleksandrov 2020-07-31 18:10 ` Nikolay Aleksandrov 2020-07-31 18:10 ` [Bridge] " Nikolay Aleksandrov 2020-08-02 12:50 ` [PATCH net v2] net: bridge: clear skb private space on bridge dev xmit Nikolay Aleksandrov 2020-08-02 12:50 ` [Bridge] " Nikolay Aleksandrov 2020-08-03 22:58 ` David Miller 2020-08-03 22:58 ` [Bridge] " David Miller 2020-08-03 22:27 ` [PATCH net] net: bridge: clear bridge's private skb space on xmit David Miller 2020-08-03 22:27 ` [Bridge] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200731162616.345380-1-nikolay@cumulusnetworks.com \ --to=nikolay@cumulusnetworks.com \ --cc=bridge@lists.linux-foundation.org \ --cc=davem@davemloft.net \ --cc=netdev@vger.kernel.org \ --cc=roopa@cumulusnetworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.