All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	roopa@cumulusnetworks.com
Subject: Re: [PATCH net] net: bridge: clear bridge's private skb space on xmit
Date: Mon, 03 Aug 2020 15:27:33 -0700 (PDT)	[thread overview]
Message-ID: <20200803.152733.2227709746454273509.davem@davemloft.net> (raw)
In-Reply-To: <20200731162616.345380-1-nikolay@cumulusnetworks.com>

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Fri, 31 Jul 2020 19:26:16 +0300

> We need to clear all of the bridge private skb variables as they can be
> stale due to the packet being recirculated through the stack and then
> transmitted through the bridge device. Similar memset is already done on
> bridge's input. We've seen cases where proxyarp_replied was 1 on routed
> multicast packets transmitted through the bridge to ports with neigh
> suppress which were getting dropped. Same thing can in theory happen with
> the port isolation bit as well.
> 
> Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied and queued up for -stable, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH net] net: bridge: clear bridge's private skb space on xmit
Date: Mon, 03 Aug 2020 15:27:33 -0700 (PDT)	[thread overview]
Message-ID: <20200803.152733.2227709746454273509.davem@davemloft.net> (raw)
In-Reply-To: <20200731162616.345380-1-nikolay@cumulusnetworks.com>

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Fri, 31 Jul 2020 19:26:16 +0300

> We need to clear all of the bridge private skb variables as they can be
> stale due to the packet being recirculated through the stack and then
> transmitted through the bridge device. Similar memset is already done on
> bridge's input. We've seen cases where proxyarp_replied was 1 on routed
> multicast packets transmitted through the bridge to ports with neigh
> suppress which were getting dropped. Same thing can in theory happen with
> the port isolation bit as well.
> 
> Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied and queued up for -stable, thanks.

  parent reply	other threads:[~2020-08-03 22:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 16:26 [PATCH net] net: bridge: clear bridge's private skb space on xmit Nikolay Aleksandrov
2020-07-31 16:26 ` [Bridge] " Nikolay Aleksandrov
2020-07-31 17:27 ` David Ahern
2020-07-31 17:27   ` [Bridge] " David Ahern
2020-07-31 17:37   ` Nikolay Aleksandrov
2020-07-31 17:37     ` [Bridge] " Nikolay Aleksandrov
2020-07-31 17:38     ` Nikolay Aleksandrov
2020-07-31 17:38       ` [Bridge] " Nikolay Aleksandrov
2020-07-31 17:51     ` Nikolay Aleksandrov
2020-07-31 17:51       ` [Bridge] " Nikolay Aleksandrov
2020-07-31 18:10       ` Nikolay Aleksandrov
2020-07-31 18:10         ` [Bridge] " Nikolay Aleksandrov
2020-08-02 12:50         ` [PATCH net v2] net: bridge: clear skb private space on bridge dev xmit Nikolay Aleksandrov
2020-08-02 12:50           ` [Bridge] " Nikolay Aleksandrov
2020-08-03 22:58           ` David Miller
2020-08-03 22:58             ` [Bridge] " David Miller
2020-08-03 22:27 ` David Miller [this message]
2020-08-03 22:27   ` [Bridge] [PATCH net] net: bridge: clear bridge's private skb space on xmit David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803.152733.2227709746454273509.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.