All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: berrange@redhat.com, vromanso@redhat.com, dwalsh@redhat.com,
	qemu-devel@nongnu.org, dgilbert@redhat.com, virtio-fs@redhat.com
Subject: Re: [PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode
Date: Mon, 3 Aug 2020 10:45:36 +0100	[thread overview]
Message-ID: <20200803094536.GC244853@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200730194736.173994-1-vgoyal@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Thu, Jul 30, 2020 at 03:47:31PM -0400, Vivek Goyal wrote:
> Hi,
> 
> This is V2 of patches. Only change since last version is handling of
> lock/pid file creation as per the comments from Daniel Berrange.
> 
> I can't think of any more changes needed. As a unpriviliged user
> inside VM I can do simple operations like create/remove/read/write
> files.
> 
> For more testing, I probably need a testsuite which runs as unpriviliged
> user. pjdfstests needs to run as root and this does not work in this
> setup as creation of files as root fails. (On host, daemon tries to
> switch to root uid and that fails).
> 
> So as of now, I think these are the minimum changes needed to support
> unprivileged passthrough mode of virtiofsd.

Ideas for testing user file I/O:

  $ git clone https://git.qemu.org/git/qemu.git
  $ find qemu -name \*.c
  $ grep -r vhost_user_fs qemu
  $ rm -rf qemu

  $ pip install --user Django
  $ .local/bin/django-admin

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: berrange@redhat.com, vromanso@redhat.com, qemu-devel@nongnu.org,
	virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode
Date: Mon, 3 Aug 2020 10:45:36 +0100	[thread overview]
Message-ID: <20200803094536.GC244853@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200730194736.173994-1-vgoyal@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Thu, Jul 30, 2020 at 03:47:31PM -0400, Vivek Goyal wrote:
> Hi,
> 
> This is V2 of patches. Only change since last version is handling of
> lock/pid file creation as per the comments from Daniel Berrange.
> 
> I can't think of any more changes needed. As a unpriviliged user
> inside VM I can do simple operations like create/remove/read/write
> files.
> 
> For more testing, I probably need a testsuite which runs as unpriviliged
> user. pjdfstests needs to run as root and this does not work in this
> setup as creation of files as root fails. (On host, daemon tries to
> switch to root uid and that fails).
> 
> So as of now, I think these are the minimum changes needed to support
> unprivileged passthrough mode of virtiofsd.

Ideas for testing user file I/O:

  $ git clone https://git.qemu.org/git/qemu.git
  $ find qemu -name \*.c
  $ grep -r vhost_user_fs qemu
  $ rm -rf qemu

  $ pip install --user Django
  $ .local/bin/django-admin

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-08-03  9:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 19:47 [PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode Vivek Goyal
2020-07-30 19:47 ` [Virtio-fs] " Vivek Goyal
2020-07-30 19:47 ` [PATCH v2 1/5] virtiofsd: Add notion of unprivileged mode Vivek Goyal
2020-07-30 19:47   ` [Virtio-fs] " Vivek Goyal
2020-08-07 16:33   ` Dr. David Alan Gilbert
2020-08-07 16:33     ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-30 19:47 ` [PATCH v2 2/5] virtiofsd: create lock/pid file in per user cache dir Vivek Goyal
2020-07-30 19:47   ` [Virtio-fs] " Vivek Goyal
2020-08-07 17:34   ` Dr. David Alan Gilbert
2020-08-07 17:34     ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-30 19:47 ` [PATCH v2 3/5] virtiofsd: open /proc/self/fd/ in sandbox=NONE mode Vivek Goyal
2020-07-30 19:47   ` [Virtio-fs] " Vivek Goyal
2020-08-07 17:42   ` Dr. David Alan Gilbert
2020-08-07 17:42     ` [Virtio-fs] " Dr. David Alan Gilbert
2020-07-30 19:47 ` [PATCH v2 4/5] virtiofsd: Open lo->source while setting up root " Vivek Goyal
2020-07-30 19:47   ` [Virtio-fs] " Vivek Goyal
2020-08-03  9:54   ` Stefan Hajnoczi
2020-08-03  9:54     ` [Virtio-fs] " Stefan Hajnoczi
2020-08-03 13:57     ` Vivek Goyal
2020-08-03 13:57       ` [Virtio-fs] " Vivek Goyal
2020-08-04 10:36       ` Stefan Hajnoczi
2020-08-04 10:36         ` [Virtio-fs] " Stefan Hajnoczi
2020-07-30 19:47 ` [PATCH v2 5/5] virtiofsd: Skip setup_capabilities() " Vivek Goyal
2020-07-30 19:47   ` [Virtio-fs] " Vivek Goyal
2020-08-07 17:58   ` Dr. David Alan Gilbert
2020-08-07 17:58     ` [Virtio-fs] " Dr. David Alan Gilbert
2020-08-03  9:45 ` Stefan Hajnoczi [this message]
2020-08-03  9:45   ` [Virtio-fs] [PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803094536.GC244853@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dwalsh@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    --cc=vromanso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.