All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org,
	Jason Wang <jasowang@redhat.com>,
	Gonglei <arei.gonglei@huawei.com>,
	linux-crypto@vger.kernel.org
Subject: [PATCH v2 08/24] virtio_crypto: correct tags for config space fields
Date: Mon, 3 Aug 2020 16:59:09 -0400	[thread overview]
Message-ID: <20200803205814.540410-9-mst@redhat.com> (raw)
In-Reply-To: <20200803205814.540410-1-mst@redhat.com>

Since crypto is a modern-only device,
tag config space fields as having little endian-ness.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/virtio_crypto.h | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/include/uapi/linux/virtio_crypto.h b/include/uapi/linux/virtio_crypto.h
index 50cdc8aebfcf..a03932f10565 100644
--- a/include/uapi/linux/virtio_crypto.h
+++ b/include/uapi/linux/virtio_crypto.h
@@ -414,33 +414,33 @@ struct virtio_crypto_op_data_req {
 
 struct virtio_crypto_config {
 	/* See VIRTIO_CRYPTO_OP_* above */
-	__u32  status;
+	__le32  status;
 
 	/*
 	 * Maximum number of data queue
 	 */
-	__u32  max_dataqueues;
+	__le32  max_dataqueues;
 
 	/*
 	 * Specifies the services mask which the device support,
 	 * see VIRTIO_CRYPTO_SERVICE_* above
 	 */
-	__u32 crypto_services;
+	__le32 crypto_services;
 
 	/* Detailed algorithms mask */
-	__u32 cipher_algo_l;
-	__u32 cipher_algo_h;
-	__u32 hash_algo;
-	__u32 mac_algo_l;
-	__u32 mac_algo_h;
-	__u32 aead_algo;
+	__le32 cipher_algo_l;
+	__le32 cipher_algo_h;
+	__le32 hash_algo;
+	__le32 mac_algo_l;
+	__le32 mac_algo_h;
+	__le32 aead_algo;
 	/* Maximum length of cipher key */
-	__u32 max_cipher_key_len;
+	__le32 max_cipher_key_len;
 	/* Maximum length of authenticated key */
-	__u32 max_auth_key_len;
-	__u32 reserve;
+	__le32 max_auth_key_len;
+	__le32 reserve;
 	/* Maximum size of each crypto request's content */
-	__u64 max_size;
+	__le64 max_size;
 };
 
 struct virtio_crypto_inhdr {
-- 
MST


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH v2 08/24] virtio_crypto: correct tags for config space fields
Date: Mon, 3 Aug 2020 16:59:09 -0400	[thread overview]
Message-ID: <20200803205814.540410-9-mst@redhat.com> (raw)
In-Reply-To: <20200803205814.540410-1-mst@redhat.com>

Since crypto is a modern-only device,
tag config space fields as having little endian-ness.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/virtio_crypto.h | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/include/uapi/linux/virtio_crypto.h b/include/uapi/linux/virtio_crypto.h
index 50cdc8aebfcf..a03932f10565 100644
--- a/include/uapi/linux/virtio_crypto.h
+++ b/include/uapi/linux/virtio_crypto.h
@@ -414,33 +414,33 @@ struct virtio_crypto_op_data_req {
 
 struct virtio_crypto_config {
 	/* See VIRTIO_CRYPTO_OP_* above */
-	__u32  status;
+	__le32  status;
 
 	/*
 	 * Maximum number of data queue
 	 */
-	__u32  max_dataqueues;
+	__le32  max_dataqueues;
 
 	/*
 	 * Specifies the services mask which the device support,
 	 * see VIRTIO_CRYPTO_SERVICE_* above
 	 */
-	__u32 crypto_services;
+	__le32 crypto_services;
 
 	/* Detailed algorithms mask */
-	__u32 cipher_algo_l;
-	__u32 cipher_algo_h;
-	__u32 hash_algo;
-	__u32 mac_algo_l;
-	__u32 mac_algo_h;
-	__u32 aead_algo;
+	__le32 cipher_algo_l;
+	__le32 cipher_algo_h;
+	__le32 hash_algo;
+	__le32 mac_algo_l;
+	__le32 mac_algo_h;
+	__le32 aead_algo;
 	/* Maximum length of cipher key */
-	__u32 max_cipher_key_len;
+	__le32 max_cipher_key_len;
 	/* Maximum length of authenticated key */
-	__u32 max_auth_key_len;
-	__u32 reserve;
+	__le32 max_auth_key_len;
+	__le32 reserve;
 	/* Maximum size of each crypto request's content */
-	__u64 max_size;
+	__le64 max_size;
 };
 
 struct virtio_crypto_inhdr {
-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2020-08-03 20:59 UTC|newest]

Thread overview: 143+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 20:58 [PATCH v2 00/24] virtio: config space endian-ness cleanup Michael S. Tsirkin
2020-08-03 20:58 ` Michael S. Tsirkin
2020-08-03 20:58 ` [PATCH v2 01/24] virtio_balloon: fix sparse warning Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-03 21:25   ` David Hildenbrand
2020-08-03 21:25     ` David Hildenbrand
2020-08-04 14:16   ` Cornelia Huck
2020-08-04 14:16     ` Cornelia Huck
2020-08-03 20:58 ` [PATCH v2 02/24] virtio_ring: sparse warning fixup Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-04 14:18   ` Cornelia Huck
2020-08-04 14:18     ` Cornelia Huck
2020-08-03 20:58 ` [PATCH v2 03/24] virtio: allow __virtioXX, __leXX in config space Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-04 14:23   ` Cornelia Huck
2020-08-04 14:23     ` Cornelia Huck
2020-08-04 14:28     ` Michael S. Tsirkin
2020-08-04 14:28       ` Michael S. Tsirkin
2020-08-05  6:28   ` Jason Wang
2020-08-05  6:28     ` Jason Wang
2020-08-05 11:45     ` Michael S. Tsirkin
2020-08-05 11:45       ` Michael S. Tsirkin
2020-08-06  3:37       ` Jason Wang
2020-08-06  3:37         ` Jason Wang
2020-08-06  5:58         ` Michael S. Tsirkin
2020-08-06  5:58           ` Michael S. Tsirkin
2020-08-07  3:26           ` Jason Wang
2020-08-07  3:26             ` Jason Wang
2020-08-03 20:58 ` [PATCH v2 04/24] virtio_9p: correct tags for config space fields Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-04 14:25   ` Cornelia Huck
2020-08-04 14:25     ` Cornelia Huck
2020-08-03 20:58 ` [PATCH v2 05/24] virtio_balloon: " Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-03 21:26   ` David Hildenbrand
2020-08-03 21:26     ` David Hildenbrand
2020-08-04 14:26   ` Cornelia Huck
2020-08-04 14:26     ` Cornelia Huck
2020-08-03 20:58 ` [PATCH v2 06/24] virtio_blk: " Michael S. Tsirkin
2020-08-03 20:58   ` Michael S. Tsirkin
2020-08-04 14:29   ` Cornelia Huck
2020-08-04 14:29     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 07/24] virtio_console: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:31   ` Cornelia Huck
2020-08-04 14:31     ` Cornelia Huck
2020-08-03 20:59 ` Michael S. Tsirkin [this message]
2020-08-03 20:59   ` [PATCH v2 08/24] virtio_crypto: " Michael S. Tsirkin
2020-08-04 14:32   ` Cornelia Huck
2020-08-04 14:32     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 09/24] virtio_fs: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 13:36   ` Vivek Goyal
2020-08-04 13:36     ` Vivek Goyal
2020-08-04 14:33   ` Cornelia Huck
2020-08-04 14:33     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 10/24] virtio_gpu: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:34   ` Cornelia Huck
2020-08-04 14:34     ` Cornelia Huck
2020-08-04 14:34     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 11/24] virtio_input: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04  6:01   ` Gerd Hoffmann
2020-08-04  6:01     ` Gerd Hoffmann
2020-08-04 14:35   ` Cornelia Huck
2020-08-04 14:35     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 12/24] virtio_iommu: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04  8:00   ` Jean-Philippe Brucker
2020-08-04  8:00     ` Jean-Philippe Brucker
2020-08-04 14:36   ` Cornelia Huck
2020-08-04 14:36     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 13/24] virtio_mem: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-03 21:23   ` David Hildenbrand
2020-08-03 21:23     ` David Hildenbrand
2020-08-04 14:37   ` Cornelia Huck
2020-08-04 14:37     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 14/24] virtio_net: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:44   ` Cornelia Huck
2020-08-04 14:44     ` Cornelia Huck
2020-08-05 13:26     ` Michael S. Tsirkin
2020-08-05 13:26       ` Michael S. Tsirkin
2020-08-03 20:59 ` [PATCH v2 15/24] virtio_pmem: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:46   ` Cornelia Huck
2020-08-04 14:46     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 16/24] virtio_scsi: " Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:48   ` Cornelia Huck
2020-08-04 14:48     ` Cornelia Huck
2020-08-03 20:59 ` [PATCH v2 17/24] virtio_config: disallow native type fields Michael S. Tsirkin
2020-08-03 20:59   ` Michael S. Tsirkin
2020-08-04 14:50   ` Cornelia Huck
2020-08-04 14:50     ` Cornelia Huck
2020-08-05 13:29     ` Michael S. Tsirkin
2020-08-05 13:29       ` Michael S. Tsirkin
2020-08-03 21:00 ` [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-04 14:56   ` Cornelia Huck
2020-08-04 14:56     ` Cornelia Huck
2020-08-04 14:56     ` Cornelia Huck
2020-08-05 13:29     ` Michael S. Tsirkin
2020-08-05 13:29       ` Michael S. Tsirkin
2020-08-05 13:29       ` Michael S. Tsirkin
2020-08-03 21:00 ` [PATCH v2 19/24] vdpa: make sure set_features in invoked for legacy Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-05  6:14   ` Jason Wang
2020-08-05  6:14     ` Jason Wang
2020-08-05 11:40     ` Michael S. Tsirkin
2020-08-05 11:40       ` Michael S. Tsirkin
2020-08-06  3:23       ` Jason Wang
2020-08-06  3:23         ` Jason Wang
2020-08-06  5:53         ` Michael S. Tsirkin
2020-08-06  5:53           ` Michael S. Tsirkin
2020-08-06  7:27           ` Jason Wang
2020-08-06  7:27             ` Jason Wang
2020-08-06 10:00             ` Michael S. Tsirkin
2020-08-06 10:00               ` Michael S. Tsirkin
2020-08-07  3:00               ` Jason Wang
2020-08-07  3:00                 ` Jason Wang
2020-08-03 21:00 ` [PATCH v2 20/24] vhost/vdpa: switch to new helpers Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-03 21:00 ` [PATCH v2 21/24] virtio_vdpa: legacy features handling Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-03 21:00 ` [PATCH v2 22/24] vdpa_sim: fix endian-ness of config space Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-05  6:21   ` Jason Wang
2020-08-05  6:21     ` Jason Wang
2020-08-05 11:44     ` Michael S. Tsirkin
2020-08-05 11:44       ` Michael S. Tsirkin
2020-08-05 12:06     ` Michael S. Tsirkin
2020-08-05 12:06       ` Michael S. Tsirkin
2020-08-06  3:23       ` Jason Wang
2020-08-06  3:23         ` Jason Wang
2020-08-03 21:00 ` [PATCH v2 23/24] virtio_config: cread/write cleanup Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin
2020-08-03 21:00 ` [PATCH v2 24/24] virtio_config: rewrite using _Generic Michael S. Tsirkin
2020-08-03 21:00   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803205814.540410-9-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=jasowang@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.