From: David Hildenbrand <david@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Jason Wang <jasowang@redhat.com>, David Hildenbrand <david@redhat.com> Subject: Re: [PATCH v2 01/24] virtio_balloon: fix sparse warning Date: Mon, 3 Aug 2020 23:25:44 +0200 [thread overview] Message-ID: <D9D808BB-4A2F-459D-8E2C-CC0C6E0D5C99@redhat.com> (raw) In-Reply-To: <20200803205814.540410-2-mst@redhat.com> > Am 03.08.2020 um 22:58 schrieb Michael S. Tsirkin <mst@redhat.com>: > > balloon uses virtio32_to_cpu instead of cpu_to_virtio32 > to convert a native endian number to virtio. > No practical difference but makes sparse warn. > Fix it up. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> I think I acked this one already. Acked-by: David Hildenbrand <david@redhat.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 54fd989f9353..8bc1704ffdf3 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -600,7 +600,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb) > while (virtqueue_get_buf(vq, &unused)) > ; > > - vb->cmd_id_active = virtio32_to_cpu(vb->vdev, > + vb->cmd_id_active = cpu_to_virtio32(vb->vdev, > virtio_balloon_cmd_id_received(vb)); > sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); > err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); > -- > MST >
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 01/24] virtio_balloon: fix sparse warning Date: Mon, 3 Aug 2020 23:25:44 +0200 [thread overview] Message-ID: <D9D808BB-4A2F-459D-8E2C-CC0C6E0D5C99@redhat.com> (raw) In-Reply-To: <20200803205814.540410-2-mst@redhat.com> > Am 03.08.2020 um 22:58 schrieb Michael S. Tsirkin <mst@redhat.com>: > > balloon uses virtio32_to_cpu instead of cpu_to_virtio32 > to convert a native endian number to virtio. > No practical difference but makes sparse warn. > Fix it up. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> I think I acked this one already. Acked-by: David Hildenbrand <david@redhat.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 54fd989f9353..8bc1704ffdf3 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -600,7 +600,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb) > while (virtqueue_get_buf(vq, &unused)) > ; > > - vb->cmd_id_active = virtio32_to_cpu(vb->vdev, > + vb->cmd_id_active = cpu_to_virtio32(vb->vdev, > virtio_balloon_cmd_id_received(vb)); > sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active)); > err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL); > -- > MST > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-08-03 21:25 UTC|newest] Thread overview: 143+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-03 20:58 [PATCH v2 00/24] virtio: config space endian-ness cleanup Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-03 20:58 ` [PATCH v2 01/24] virtio_balloon: fix sparse warning Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-03 21:25 ` David Hildenbrand [this message] 2020-08-03 21:25 ` David Hildenbrand 2020-08-04 14:16 ` Cornelia Huck 2020-08-04 14:16 ` Cornelia Huck 2020-08-03 20:58 ` [PATCH v2 02/24] virtio_ring: sparse warning fixup Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-04 14:18 ` Cornelia Huck 2020-08-04 14:18 ` Cornelia Huck 2020-08-03 20:58 ` [PATCH v2 03/24] virtio: allow __virtioXX, __leXX in config space Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-04 14:23 ` Cornelia Huck 2020-08-04 14:23 ` Cornelia Huck 2020-08-04 14:28 ` Michael S. Tsirkin 2020-08-04 14:28 ` Michael S. Tsirkin 2020-08-05 6:28 ` Jason Wang 2020-08-05 6:28 ` Jason Wang 2020-08-05 11:45 ` Michael S. Tsirkin 2020-08-05 11:45 ` Michael S. Tsirkin 2020-08-06 3:37 ` Jason Wang 2020-08-06 3:37 ` Jason Wang 2020-08-06 5:58 ` Michael S. Tsirkin 2020-08-06 5:58 ` Michael S. Tsirkin 2020-08-07 3:26 ` Jason Wang 2020-08-07 3:26 ` Jason Wang 2020-08-03 20:58 ` [PATCH v2 04/24] virtio_9p: correct tags for config space fields Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-04 14:25 ` Cornelia Huck 2020-08-04 14:25 ` Cornelia Huck 2020-08-03 20:58 ` [PATCH v2 05/24] virtio_balloon: " Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-03 21:26 ` David Hildenbrand 2020-08-03 21:26 ` David Hildenbrand 2020-08-04 14:26 ` Cornelia Huck 2020-08-04 14:26 ` Cornelia Huck 2020-08-03 20:58 ` [PATCH v2 06/24] virtio_blk: " Michael S. Tsirkin 2020-08-03 20:58 ` Michael S. Tsirkin 2020-08-04 14:29 ` Cornelia Huck 2020-08-04 14:29 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 07/24] virtio_console: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:31 ` Cornelia Huck 2020-08-04 14:31 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 08/24] virtio_crypto: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:32 ` Cornelia Huck 2020-08-04 14:32 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 09/24] virtio_fs: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 13:36 ` Vivek Goyal 2020-08-04 13:36 ` Vivek Goyal 2020-08-04 14:33 ` Cornelia Huck 2020-08-04 14:33 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 10/24] virtio_gpu: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:34 ` Cornelia Huck 2020-08-04 14:34 ` Cornelia Huck 2020-08-04 14:34 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 11/24] virtio_input: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 6:01 ` Gerd Hoffmann 2020-08-04 6:01 ` Gerd Hoffmann 2020-08-04 14:35 ` Cornelia Huck 2020-08-04 14:35 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 12/24] virtio_iommu: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 8:00 ` Jean-Philippe Brucker 2020-08-04 8:00 ` Jean-Philippe Brucker 2020-08-04 14:36 ` Cornelia Huck 2020-08-04 14:36 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 13/24] virtio_mem: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-03 21:23 ` David Hildenbrand 2020-08-03 21:23 ` David Hildenbrand 2020-08-04 14:37 ` Cornelia Huck 2020-08-04 14:37 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 14/24] virtio_net: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:44 ` Cornelia Huck 2020-08-04 14:44 ` Cornelia Huck 2020-08-05 13:26 ` Michael S. Tsirkin 2020-08-05 13:26 ` Michael S. Tsirkin 2020-08-03 20:59 ` [PATCH v2 15/24] virtio_pmem: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:46 ` Cornelia Huck 2020-08-04 14:46 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 16/24] virtio_scsi: " Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:48 ` Cornelia Huck 2020-08-04 14:48 ` Cornelia Huck 2020-08-03 20:59 ` [PATCH v2 17/24] virtio_config: disallow native type fields Michael S. Tsirkin 2020-08-03 20:59 ` Michael S. Tsirkin 2020-08-04 14:50 ` Cornelia Huck 2020-08-04 14:50 ` Cornelia Huck 2020-08-05 13:29 ` Michael S. Tsirkin 2020-08-05 13:29 ` Michael S. Tsirkin 2020-08-03 21:00 ` [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-04 14:56 ` Cornelia Huck 2020-08-04 14:56 ` Cornelia Huck 2020-08-04 14:56 ` Cornelia Huck 2020-08-05 13:29 ` Michael S. Tsirkin 2020-08-05 13:29 ` Michael S. Tsirkin 2020-08-05 13:29 ` Michael S. Tsirkin 2020-08-03 21:00 ` [PATCH v2 19/24] vdpa: make sure set_features in invoked for legacy Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-05 6:14 ` Jason Wang 2020-08-05 6:14 ` Jason Wang 2020-08-05 11:40 ` Michael S. Tsirkin 2020-08-05 11:40 ` Michael S. Tsirkin 2020-08-06 3:23 ` Jason Wang 2020-08-06 3:23 ` Jason Wang 2020-08-06 5:53 ` Michael S. Tsirkin 2020-08-06 5:53 ` Michael S. Tsirkin 2020-08-06 7:27 ` Jason Wang 2020-08-06 7:27 ` Jason Wang 2020-08-06 10:00 ` Michael S. Tsirkin 2020-08-06 10:00 ` Michael S. Tsirkin 2020-08-07 3:00 ` Jason Wang 2020-08-07 3:00 ` Jason Wang 2020-08-03 21:00 ` [PATCH v2 20/24] vhost/vdpa: switch to new helpers Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-03 21:00 ` [PATCH v2 21/24] virtio_vdpa: legacy features handling Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-03 21:00 ` [PATCH v2 22/24] vdpa_sim: fix endian-ness of config space Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-05 6:21 ` Jason Wang 2020-08-05 6:21 ` Jason Wang 2020-08-05 11:44 ` Michael S. Tsirkin 2020-08-05 11:44 ` Michael S. Tsirkin 2020-08-05 12:06 ` Michael S. Tsirkin 2020-08-05 12:06 ` Michael S. Tsirkin 2020-08-06 3:23 ` Jason Wang 2020-08-06 3:23 ` Jason Wang 2020-08-03 21:00 ` [PATCH v2 23/24] virtio_config: cread/write cleanup Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin 2020-08-03 21:00 ` [PATCH v2 24/24] virtio_config: rewrite using _Generic Michael S. Tsirkin 2020-08-03 21:00 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=D9D808BB-4A2F-459D-8E2C-CC0C6E0D5C99@redhat.com \ --to=david@redhat.com \ --cc=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.