From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das.jz@bp.renesas.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Magnus Damm <magnus.damm@gmail.com>, DRI Development <dri-devel@lists.freedesktop.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings Date: Thu, 13 Aug 2020 13:59:10 +0300 [thread overview] Message-ID: <20200813105910.GB6057@pendragon.ideasonboard.com> (raw) In-Reply-To: <CA+V-a8svAuDx51vuTCH4w5g0oF9qf8sWAEjMDMm+0+9u-UQhQw@mail.gmail.com> Hello, On Thu, Aug 13, 2020 at 11:38:03AM +0100, Lad, Prabhakar wrote: > On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > > On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar wrote: > > > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings. > > > > > > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > > index 51cd4d162770..67cded5ad827 100644 > > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > > @@ -10,6 +10,7 @@ Required Properties: > > > - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU > > > - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU > > > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU > > > + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU > > > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU > > > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU > > > - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU > > > @@ -75,6 +76,7 @@ corresponding to each DU output. > > > R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 - > > > R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 - > > > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 - > > > + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 - > > > > As LVDS 0 is the fourth channel (DU3), should it be listed under port 3 > > instead of port 2? > > > > I know we did it the same for R-Car M3-N and RZ/G2N. > > But my main worry is adding support for R-Car H3-N later. Why should we do so ? The port number here isn't tied to the DU channel number. It only identifies the output port. Many DUs can route DU channel outputs to different output ports. > I do agree too, with the below diff I tested the LVDS output on RZ/G2N > Rev2 board and things work fine. But only thing it doesn't explain is > why does LVDS work on DU2 for G2[H/N] boards :D > > Geert, Laurent, Kieran If you agree with the below changes I shall > post a proper patch fixing it for RZ/G2[HN] > > diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > index d661724fc28a..0b087d287202 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > @@ -2540,8 +2540,8 @@ > remote-endpoint = > <&dw_hdmi0_in>; > }; > }; > - port@2 { > - reg = <2>; > + port@3 { > + reg = <3>; > du_out_lvds0: endpoint { > remote-endpoint = <&lvds0_in>; > }; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 3e67cf70f040..419d81c7763e 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -153,7 +153,7 @@ static const struct rcar_du_device_info > rcar_du_r8a774b1_info = { > }, > [RCAR_DU_OUTPUT_LVDS0] = { > .possible_crtcs = BIT(0), > - .port = 2, > + .port = 3, > }, > }, > .num_lvds = 1, > > > > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - > > > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - > > > R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - > > > > Apart from that: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Magnus Damm <magnus.damm@gmail.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Geert Uytterhoeven <geert@linux-m68k.org>, DRI Development <dri-devel@lists.freedesktop.org>, Biju Das <biju.das.jz@bp.renesas.com> Subject: Re: [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings Date: Thu, 13 Aug 2020 13:59:10 +0300 [thread overview] Message-ID: <20200813105910.GB6057@pendragon.ideasonboard.com> (raw) In-Reply-To: <CA+V-a8svAuDx51vuTCH4w5g0oF9qf8sWAEjMDMm+0+9u-UQhQw@mail.gmail.com> Hello, On Thu, Aug 13, 2020 at 11:38:03AM +0100, Lad, Prabhakar wrote: > On Thu, Aug 13, 2020 at 10:05 AM Geert Uytterhoeven wrote: > > On Wed, Aug 12, 2020 at 4:02 PM Lad Prabhakar wrote: > > > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > > > Document the RZ/G2H (a.k.a. r8a774e1) SoC in the R-Car DU bindings. > > > > > > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > > > index 51cd4d162770..67cded5ad827 100644 > > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > > @@ -10,6 +10,7 @@ Required Properties: > > > - "renesas,du-r8a774a1" for R8A774A1 (RZ/G2M) compatible DU > > > - "renesas,du-r8a774b1" for R8A774B1 (RZ/G2N) compatible DU > > > - "renesas,du-r8a774c0" for R8A774C0 (RZ/G2E) compatible DU > > > + - "renesas,du-r8a774e1" for R8A774E1 (RZ/G2H) compatible DU > > > - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU > > > - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU > > > - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU > > > @@ -75,6 +76,7 @@ corresponding to each DU output. > > > R8A774A1 (RZ/G2M) DPAD 0 HDMI 0 LVDS 0 - > > > R8A774B1 (RZ/G2N) DPAD 0 HDMI 0 LVDS 0 - > > > R8A774C0 (RZ/G2E) DPAD 0 LVDS 0 LVDS 1 - > > > + R8A774E1 (RZ/G2H) DPAD 0 HDMI 0 LVDS 0 - > > > > As LVDS 0 is the fourth channel (DU3), should it be listed under port 3 > > instead of port 2? > > > > I know we did it the same for R-Car M3-N and RZ/G2N. > > But my main worry is adding support for R-Car H3-N later. Why should we do so ? The port number here isn't tied to the DU channel number. It only identifies the output port. Many DUs can route DU channel outputs to different output ports. > I do agree too, with the below diff I tested the LVDS output on RZ/G2N > Rev2 board and things work fine. But only thing it doesn't explain is > why does LVDS work on DU2 for G2[H/N] boards :D > > Geert, Laurent, Kieran If you agree with the below changes I shall > post a proper patch fixing it for RZ/G2[HN] > > diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > index d661724fc28a..0b087d287202 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi > @@ -2540,8 +2540,8 @@ > remote-endpoint = > <&dw_hdmi0_in>; > }; > }; > - port@2 { > - reg = <2>; > + port@3 { > + reg = <3>; > du_out_lvds0: endpoint { > remote-endpoint = <&lvds0_in>; > }; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 3e67cf70f040..419d81c7763e 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -153,7 +153,7 @@ static const struct rcar_du_device_info > rcar_du_r8a774b1_info = { > }, > [RCAR_DU_OUTPUT_LVDS0] = { > .possible_crtcs = BIT(0), > - .port = 2, > + .port = 3, > }, > }, > .num_lvds = 1, > > > > R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - > > > R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - > > > R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - > > > > Apart from that: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-13 10:59 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-12 14:02 [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 14:02 ` [PATCH 1/9] dt-bindings: display: renesas,du: Document r8a774e1 bindings Lad Prabhakar 2020-08-12 14:02 ` [PATCH 1/9] dt-bindings: display: renesas, du: " Lad Prabhakar 2020-08-12 16:09 ` [PATCH 1/9] dt-bindings: display: renesas,du: " Laurent Pinchart 2020-08-12 16:09 ` Laurent Pinchart 2020-08-13 9:05 ` Geert Uytterhoeven 2020-08-13 9:05 ` [PATCH 1/9] dt-bindings: display: renesas, du: " Geert Uytterhoeven 2020-08-13 10:38 ` [PATCH 1/9] dt-bindings: display: renesas,du: " Lad, Prabhakar 2020-08-13 10:38 ` [PATCH 1/9] dt-bindings: display: renesas, du: " Lad, Prabhakar 2020-08-13 10:59 ` Laurent Pinchart [this message] 2020-08-13 10:59 ` [PATCH 1/9] dt-bindings: display: renesas,du: " Laurent Pinchart 2020-08-13 11:08 ` Lad, Prabhakar 2020-08-13 11:08 ` [PATCH 1/9] dt-bindings: display: renesas, du: " Lad, Prabhakar 2020-08-13 11:11 ` [PATCH 1/9] dt-bindings: display: renesas,du: " Laurent Pinchart 2020-08-13 11:11 ` Laurent Pinchart 2020-08-13 11:20 ` Lad, Prabhakar 2020-08-13 11:20 ` [PATCH 1/9] dt-bindings: display: renesas, du: " Lad, Prabhakar 2020-08-12 14:02 ` [PATCH 2/9] drm: rcar-du: Add support for R8A774E1 SoC Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:13 ` Laurent Pinchart 2020-08-12 16:13 ` Laurent Pinchart 2020-08-12 14:02 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: Populate DU device node Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:16 ` Laurent Pinchart 2020-08-12 16:16 ` Laurent Pinchart 2020-08-13 9:08 ` Geert Uytterhoeven 2020-08-13 9:08 ` Geert Uytterhoeven 2020-08-12 14:02 ` [PATCH 4/9] dt-bindings: display: renesas,lvds: Document r8a774e1 bindings Lad Prabhakar 2020-08-12 14:02 ` [PATCH 4/9] dt-bindings: display: renesas, lvds: " Lad Prabhakar 2020-08-12 16:17 ` [PATCH 4/9] dt-bindings: display: renesas,lvds: " Laurent Pinchart 2020-08-12 16:17 ` Laurent Pinchart 2020-08-12 16:18 ` Laurent Pinchart 2020-08-12 16:18 ` Laurent Pinchart 2020-08-13 9:09 ` Geert Uytterhoeven 2020-08-13 9:09 ` [PATCH 4/9] dt-bindings: display: renesas, lvds: " Geert Uytterhoeven 2020-08-24 23:20 ` Rob Herring 2020-08-24 23:20 ` Rob Herring 2020-08-12 14:02 ` [PATCH 5/9] dt-bindings: display: renesas,dw-hdmi: Add r8a774e1 support Lad Prabhakar 2020-08-12 14:02 ` [PATCH 5/9] dt-bindings: display: renesas, dw-hdmi: " Lad Prabhakar 2020-08-12 16:20 ` [PATCH 5/9] dt-bindings: display: renesas,dw-hdmi: " Laurent Pinchart 2020-08-12 16:20 ` Laurent Pinchart 2020-08-13 9:10 ` Geert Uytterhoeven 2020-08-13 9:10 ` [PATCH 5/9] dt-bindings: display: renesas, dw-hdmi: " Geert Uytterhoeven 2020-08-24 23:20 ` Rob Herring 2020-08-24 23:20 ` Rob Herring 2020-08-12 14:02 ` [PATCH 6/9] arm64: dts: renesas: r8a774e1: Populate HDMI encoder node Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:28 ` Laurent Pinchart 2020-08-12 16:28 ` Laurent Pinchart 2020-08-13 9:14 ` Geert Uytterhoeven 2020-08-13 9:14 ` Geert Uytterhoeven 2020-08-12 14:02 ` [PATCH 7/9] drm: rcar-du: lvds: Add support for R8A774E1 SoC Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:29 ` Laurent Pinchart 2020-08-12 16:29 ` Laurent Pinchart 2020-08-12 14:02 ` [PATCH 8/9] arm64: dts: renesas: r8a774e1: Add LVDS device node Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:31 ` Laurent Pinchart 2020-08-12 16:31 ` Laurent Pinchart 2020-08-13 9:17 ` Geert Uytterhoeven 2020-08-13 9:17 ` Geert Uytterhoeven 2020-08-12 14:02 ` [PATCH 9/9] arm64: dts: renesas: r8a774e1-hihope-rzg2h: Setup DU clocks Lad Prabhakar 2020-08-12 14:02 ` Lad Prabhakar 2020-08-12 16:36 ` Laurent Pinchart 2020-08-12 16:36 ` Laurent Pinchart 2020-08-13 12:57 ` Laurent Pinchart 2020-08-13 12:57 ` Laurent Pinchart 2020-08-13 9:19 ` Geert Uytterhoeven 2020-08-13 9:19 ` Geert Uytterhoeven 2020-08-12 16:38 ` [PATCH 0/9] r8a774e1 add support for DU, HDMI and LVDS Laurent Pinchart 2020-08-12 16:38 ` Laurent Pinchart 2020-08-12 16:43 ` Lad, Prabhakar 2020-08-12 16:43 ` Lad, Prabhakar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200813105910.GB6057@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=Chris.Paterson2@renesas.com \ --cc=airlied@linux.ie \ --cc=biju.das.jz@bp.renesas.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.