From: Nishanth Menon <nm@ti.com> To: Suman Anna <s-anna@ti.com> Cc: Tero Kristo <t-kristo@ti.com>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C66x DSPs Date: Thu, 20 Aug 2020 06:42:38 -0500 [thread overview] Message-ID: <20200820114238.7ovvxq5n3fogzowi@akan> (raw) In-Reply-To: <20200820010331.2911-3-s-anna@ti.com> On 20:03-20200819, Suman Anna wrote: > Add the required 'mboxes' property to both the C66x DSP processors on the > TI J721E common processor board. The mailboxes and some shared memory I am not sure I understand the logic here. The carveout is added to p0 SOM - and the mbox is added to common_proc_board. I am not sure I get the difference. The C66x processors are on the SoC, stack is as follows: - SoC - SoM - Common Proc board I am just wondering if the carveouts and mbox linkage should be in the common processor board? if that makes sense at all? I know we already have other definitions.. Trying to see if we are making it harder to understand the definition than that is necessary.. > are required for running the Remote Processor Messaging (RPMsg) stack > between the host processor and each of the R5Fs. The chosen sub-mailboxes > match the values used in the current firmware images. This can be changed, > if needed, as per the system integration needs after making appropriate > changes on the firmware side as well. > > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index e8fc01d97ada..ff541dc09eca 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -379,6 +379,14 @@ &mailbox0_cluster11 { > status = "disabled"; > }; > > +&c66_0 { > + mboxes = <&mailbox0_cluster3 &mbox_c66_0>; > +}; > + > +&c66_1 { > + mboxes = <&mailbox0_cluster3 &mbox_c66_1>; > +}; > + > &main_sdhci0 { > /* eMMC */ > non-removable; > -- > 2.28.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com> To: Suman Anna <s-anna@ti.com> Cc: Tero Kristo <t-kristo@ti.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C66x DSPs Date: Thu, 20 Aug 2020 06:42:38 -0500 [thread overview] Message-ID: <20200820114238.7ovvxq5n3fogzowi@akan> (raw) In-Reply-To: <20200820010331.2911-3-s-anna@ti.com> On 20:03-20200819, Suman Anna wrote: > Add the required 'mboxes' property to both the C66x DSP processors on the > TI J721E common processor board. The mailboxes and some shared memory I am not sure I understand the logic here. The carveout is added to p0 SOM - and the mbox is added to common_proc_board. I am not sure I get the difference. The C66x processors are on the SoC, stack is as follows: - SoC - SoM - Common Proc board I am just wondering if the carveouts and mbox linkage should be in the common processor board? if that makes sense at all? I know we already have other definitions.. Trying to see if we are making it harder to understand the definition than that is necessary.. > are required for running the Remote Processor Messaging (RPMsg) stack > between the host processor and each of the R5Fs. The chosen sub-mailboxes > match the values used in the current firmware images. This can be changed, > if needed, as per the system integration needs after making appropriate > changes on the firmware side as well. > > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > index e8fc01d97ada..ff541dc09eca 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > @@ -379,6 +379,14 @@ &mailbox0_cluster11 { > status = "disabled"; > }; > > +&c66_0 { > + mboxes = <&mailbox0_cluster3 &mbox_c66_0>; > +}; > + > +&c66_1 { > + mboxes = <&mailbox0_cluster3 &mbox_c66_1>; > +}; > + > &main_sdhci0 { > /* eMMC */ > non-removable; > -- > 2.28.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-20 11:42 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-20 1:03 [PATCH 0/7] Add C66x & C71x DSP nodes on J721E SoCs Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 1/7] arm64: dts: ti: k3-j721e-main: Add C66x DSP nodes Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 2/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C66x DSPs Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 11:42 ` Nishanth Menon [this message] 2020-08-20 11:42 ` Nishanth Menon 2020-08-20 13:25 ` Suman Anna 2020-08-20 13:25 ` Suman Anna 2020-08-20 19:03 ` Nishanth Menon 2020-08-20 19:03 ` Nishanth Menon 2020-08-24 22:00 ` Suman Anna 2020-08-24 22:00 ` Suman Anna 2020-08-25 10:42 ` Nishanth Menon 2020-08-25 10:42 ` Nishanth Menon 2020-08-25 17:25 ` Suman Anna 2020-08-25 17:25 ` Suman Anna 2020-08-20 1:03 ` [PATCH 3/7] arm64: dts: ti: k3-j721e-som-p0: Add DDR carveout memory nodes for C66 DSPs Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 4/7] arm64: dts: ti: k3-j721e-main: Add C71x DSP node Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 5/7] arm64: dts: ti: k3-j721e-common-proc-board: Add mailboxes to C71x DSP Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 6/7] arm64: dts: ti: k3-j721e-som-p0: Add DDR carveout memory nodes for " Suman Anna 2020-08-20 1:03 ` Suman Anna 2020-08-20 1:03 ` [PATCH 7/7] arm64: dts: ti: k3-j721e-som-p0: Reserve memory for IPC between RTOS cores Suman Anna 2020-08-20 1:03 ` Suman Anna
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200820114238.7ovvxq5n3fogzowi@akan \ --to=nm@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=s-anna@ti.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.