From: Dave Chinner <david@fromorbit.com> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" <darrick.wong@oracle.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] iomap: Change calling convention for zeroing Date: Tue, 25 Aug 2020 10:27:35 +1000 [thread overview] Message-ID: <20200825002735.GI12131@dread.disaster.area> (raw) In-Reply-To: <20200824145511.10500-10-willy@infradead.org> On Mon, Aug 24, 2020 at 03:55:10PM +0100, Matthew Wilcox (Oracle) wrote: > Pass the full length to iomap_zero() and dax_iomap_zero(), and have > them return how many bytes they actually handled. This is preparatory > work for handling THP, although it looks like DAX could actually take > advantage of it if there's a larger contiguous area. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > fs/dax.c | 13 ++++++------- > fs/iomap/buffered-io.c | 33 +++++++++++++++------------------ > include/linux/dax.h | 3 +-- > 3 files changed, 22 insertions(+), 27 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 95341af1a966..f2b912cb034e 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -1037,18 +1037,18 @@ static vm_fault_t dax_load_hole(struct xa_state *xas, > return ret; > } > > -int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > - struct iomap *iomap) > +loff_t dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap) > { > sector_t sector = iomap_sector(iomap, pos & PAGE_MASK); > pgoff_t pgoff; > long rc, id; > void *kaddr; > bool page_aligned = false; > - > + unsigned offset = offset_in_page(pos); > + unsigned size = min_t(u64, PAGE_SIZE - offset, length); > > if (IS_ALIGNED(sector << SECTOR_SHIFT, PAGE_SIZE) && > - IS_ALIGNED(size, PAGE_SIZE)) > + (size == PAGE_SIZE)) > page_aligned = true; > > rc = bdev_dax_pgoff(iomap->bdev, sector, PAGE_SIZE, &pgoff); > @@ -1058,8 +1058,7 @@ int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > id = dax_read_lock(); > > if (page_aligned) > - rc = dax_zero_page_range(iomap->dax_dev, pgoff, > - size >> PAGE_SHIFT); > + rc = dax_zero_page_range(iomap->dax_dev, pgoff, 1); > else > rc = dax_direct_access(iomap->dax_dev, pgoff, 1, &kaddr, NULL); > if (rc < 0) { > @@ -1072,7 +1071,7 @@ int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > dax_flush(iomap->dax_dev, kaddr + offset, size); > } > dax_read_unlock(id); > - return 0; > + return size; > } > > static loff_t > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 7f618ab4b11e..2dba054095e8 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -901,11 +901,13 @@ iomap_file_unshare(struct inode *inode, loff_t pos, loff_t len, > } > EXPORT_SYMBOL_GPL(iomap_file_unshare); > > -static int iomap_zero(struct inode *inode, loff_t pos, unsigned offset, > - unsigned bytes, struct iomap *iomap, struct iomap *srcmap) > +static loff_t iomap_zero(struct inode *inode, loff_t pos, u64 length, > + struct iomap *iomap, struct iomap *srcmap) While you are touching this, please convert it back to: static loff_t iomap_zero(struct inode *inode, loff_t pos, u64 length, struct iomap *iomap, struct iomap *srcmap) > { > struct page *page; > int status; > + unsigned offset = offset_in_page(pos); > + unsigned bytes = min_t(u64, PAGE_SIZE - offset, length); > > status = iomap_write_begin(inode, pos, bytes, 0, &page, iomap, srcmap); > if (status) > @@ -917,38 +919,33 @@ static int iomap_zero(struct inode *inode, loff_t pos, unsigned offset, > return iomap_write_end(inode, pos, bytes, bytes, page, iomap, srcmap); > } > > -static loff_t > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count, > - void *data, struct iomap *iomap, struct iomap *srcmap) > +static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos, > + loff_t length, void *data, struct iomap *iomap, > + struct iomap *srcmap) And leave this as it was formatted. /me missed this when iomap_readahead() was introduced, too. > { > bool *did_zero = data; > loff_t written = 0; > - int status; > > /* already zeroed? we're done. */ > if (srcmap->type == IOMAP_HOLE || srcmap->type == IOMAP_UNWRITTEN) > - return count; > + return length; > > do { > - unsigned offset, bytes; > - > - offset = offset_in_page(pos); > - bytes = min_t(loff_t, PAGE_SIZE - offset, count); > + loff_t bytes; > > if (IS_DAX(inode)) > - status = dax_iomap_zero(pos, offset, bytes, iomap); > + bytes = dax_iomap_zero(pos, length, iomap); Hmmm. everything is loff_t here, but the callers are defining length as u64, not loff_t. Is there a potential sign conversion problem here? (sure 64 bit is way beyond anything we'll pass here, but...) Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" <darrick.wong@oracle.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] iomap: Change calling convention for zeroing Date: Tue, 25 Aug 2020 10:27:35 +1000 [thread overview] Message-ID: <20200825002735.GI12131@dread.disaster.area> (raw) In-Reply-To: <20200824145511.10500-10-willy@infradead.org> On Mon, Aug 24, 2020 at 03:55:10PM +0100, Matthew Wilcox (Oracle) wrote: > Pass the full length to iomap_zero() and dax_iomap_zero(), and have > them return how many bytes they actually handled. This is preparatory > work for handling THP, although it looks like DAX could actually take > advantage of it if there's a larger contiguous area. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > fs/dax.c | 13 ++++++------- > fs/iomap/buffered-io.c | 33 +++++++++++++++------------------ > include/linux/dax.h | 3 +-- > 3 files changed, 22 insertions(+), 27 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 95341af1a966..f2b912cb034e 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -1037,18 +1037,18 @@ static vm_fault_t dax_load_hole(struct xa_state *xas, > return ret; > } > > -int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > - struct iomap *iomap) > +loff_t dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap) > { > sector_t sector = iomap_sector(iomap, pos & PAGE_MASK); > pgoff_t pgoff; > long rc, id; > void *kaddr; > bool page_aligned = false; > - > + unsigned offset = offset_in_page(pos); > + unsigned size = min_t(u64, PAGE_SIZE - offset, length); > > if (IS_ALIGNED(sector << SECTOR_SHIFT, PAGE_SIZE) && > - IS_ALIGNED(size, PAGE_SIZE)) > + (size == PAGE_SIZE)) > page_aligned = true; > > rc = bdev_dax_pgoff(iomap->bdev, sector, PAGE_SIZE, &pgoff); > @@ -1058,8 +1058,7 @@ int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > id = dax_read_lock(); > > if (page_aligned) > - rc = dax_zero_page_range(iomap->dax_dev, pgoff, > - size >> PAGE_SHIFT); > + rc = dax_zero_page_range(iomap->dax_dev, pgoff, 1); > else > rc = dax_direct_access(iomap->dax_dev, pgoff, 1, &kaddr, NULL); > if (rc < 0) { > @@ -1072,7 +1071,7 @@ int dax_iomap_zero(loff_t pos, unsigned offset, unsigned size, > dax_flush(iomap->dax_dev, kaddr + offset, size); > } > dax_read_unlock(id); > - return 0; > + return size; > } > > static loff_t > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 7f618ab4b11e..2dba054095e8 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -901,11 +901,13 @@ iomap_file_unshare(struct inode *inode, loff_t pos, loff_t len, > } > EXPORT_SYMBOL_GPL(iomap_file_unshare); > > -static int iomap_zero(struct inode *inode, loff_t pos, unsigned offset, > - unsigned bytes, struct iomap *iomap, struct iomap *srcmap) > +static loff_t iomap_zero(struct inode *inode, loff_t pos, u64 length, > + struct iomap *iomap, struct iomap *srcmap) While you are touching this, please convert it back to: static loff_t iomap_zero(struct inode *inode, loff_t pos, u64 length, struct iomap *iomap, struct iomap *srcmap) > { > struct page *page; > int status; > + unsigned offset = offset_in_page(pos); > + unsigned bytes = min_t(u64, PAGE_SIZE - offset, length); > > status = iomap_write_begin(inode, pos, bytes, 0, &page, iomap, srcmap); > if (status) > @@ -917,38 +919,33 @@ static int iomap_zero(struct inode *inode, loff_t pos, unsigned offset, > return iomap_write_end(inode, pos, bytes, bytes, page, iomap, srcmap); > } > > -static loff_t > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count, > - void *data, struct iomap *iomap, struct iomap *srcmap) > +static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos, > + loff_t length, void *data, struct iomap *iomap, > + struct iomap *srcmap) And leave this as it was formatted. /me missed this when iomap_readahead() was introduced, too. > { > bool *did_zero = data; > loff_t written = 0; > - int status; > > /* already zeroed? we're done. */ > if (srcmap->type == IOMAP_HOLE || srcmap->type == IOMAP_UNWRITTEN) > - return count; > + return length; > > do { > - unsigned offset, bytes; > - > - offset = offset_in_page(pos); > - bytes = min_t(loff_t, PAGE_SIZE - offset, count); > + loff_t bytes; > > if (IS_DAX(inode)) > - status = dax_iomap_zero(pos, offset, bytes, iomap); > + bytes = dax_iomap_zero(pos, length, iomap); Hmmm. everything is loff_t here, but the callers are defining length as u64, not loff_t. Is there a potential sign conversion problem here? (sure 64 bit is way beyond anything we'll pass here, but...) Cheers, Dave. -- Dave Chinner david@fromorbit.com
next prev parent reply other threads:[~2020-08-25 0:27 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-24 14:55 [PATCH 0/9] THP iomap patches for 5.10 Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 14:55 ` [PATCH 1/9] iomap: Fix misplaced page flushing Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:51 ` Dave Chinner 2020-08-24 23:51 ` Dave Chinner 2020-08-25 20:47 ` Darrick J. Wong 2020-08-25 20:47 ` Darrick J. Wong 2020-08-27 8:24 ` Christoph Hellwig 2020-08-27 8:24 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 2/9] fs: Introduce i_blocks_per_page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:55 ` Dave Chinner 2020-08-24 23:55 ` Dave Chinner 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 22:21 ` Dave Chinner 2020-08-25 22:21 ` Dave Chinner 2020-08-24 14:55 ` [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:56 ` Dave Chinner 2020-08-24 23:56 ` Dave Chinner 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 20:49 ` Darrick J. Wong 2020-08-24 14:55 ` [PATCH 4/9] iomap: Use bitmap ops to set uptodate bits Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:56 ` Dave Chinner 2020-08-24 23:56 ` Dave Chinner 2020-08-25 20:50 ` Darrick J. Wong 2020-08-25 20:50 ` Darrick J. Wong 2020-08-24 14:55 ` [PATCH 5/9] iomap: Support arbitrarily many blocks per page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:59 ` Dave Chinner 2020-08-24 23:59 ` Dave Chinner 2020-08-25 0:22 ` Matthew Wilcox 2020-08-25 0:22 ` Matthew Wilcox 2020-08-25 21:02 ` Darrick J. Wong 2020-08-25 21:02 ` Darrick J. Wong 2020-08-26 2:26 ` Matthew Wilcox 2020-08-26 2:26 ` Matthew Wilcox 2020-08-26 3:32 ` Darrick J. Wong 2020-08-26 3:32 ` Darrick J. Wong 2020-08-27 8:26 ` Christoph Hellwig 2020-08-27 8:26 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 6/9] iomap: Convert read_count to byte count Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:09 ` Dave Chinner 2020-08-25 0:09 ` Dave Chinner 2020-08-25 22:14 ` Darrick J. Wong 2020-08-25 22:14 ` Darrick J. Wong 2020-08-27 8:35 ` Christoph Hellwig 2020-08-27 8:35 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 7/9] iomap: Convert write_count " Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-27 8:36 ` Christoph Hellwig 2020-08-27 8:36 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 8/9] iomap: Convert iomap_write_end types Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:12 ` Dave Chinner 2020-08-25 0:12 ` Dave Chinner 2020-08-25 1:06 ` Matthew Wilcox 2020-08-25 1:06 ` Matthew Wilcox 2020-08-25 1:33 ` Dave Chinner 2020-08-25 1:33 ` Dave Chinner 2020-08-27 8:41 ` Christoph Hellwig 2020-08-27 8:41 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 9/9] iomap: Change calling convention for zeroing Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:27 ` Dave Chinner [this message] 2020-08-25 0:27 ` Dave Chinner 2020-08-25 3:26 ` Matthew Wilcox 2020-08-25 3:26 ` Matthew Wilcox 2020-08-25 3:35 ` Andreas Dilger 2020-08-25 4:27 ` Dave Chinner 2020-08-25 4:27 ` Dave Chinner 2020-08-25 12:40 ` Matthew Wilcox 2020-08-25 12:40 ` Matthew Wilcox 2020-08-25 22:05 ` Dave Chinner 2020-08-25 22:05 ` Dave Chinner 2020-08-25 22:23 ` Darrick J. Wong 2020-08-25 22:23 ` Darrick J. Wong 2020-08-27 8:39 ` Christoph Hellwig 2020-08-27 8:39 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200825002735.GI12131@dread.disaster.area \ --to=david@fromorbit.com \ --cc=darrick.wong@oracle.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.