From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Dave Chinner <david@fromorbit.com> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] iomap: Convert read_count to byte count Date: Tue, 25 Aug 2020 15:14:16 -0700 [thread overview] Message-ID: <20200825221416.GK6096@magnolia> (raw) In-Reply-To: <20200825000902.GG12131@dread.disaster.area> On Tue, Aug 25, 2020 at 10:09:02AM +1000, Dave Chinner wrote: > On Mon, Aug 24, 2020 at 03:55:07PM +0100, Matthew Wilcox (Oracle) wrote: > > Instead of counting bio segments, count the number of bytes submitted. > > This insulates us from the block layer's definition of what a 'same page' > > is, which is not necessarily clear once THPs are involved. > > I'd like to see a comment on the definition of struct iomap_page to > indicate that read_count (and write count) reflect the byte count of > IO currently in flight on the page, not an IO count, because THP > makes tracking this via bio state hard. Otherwise it is not at all > obvious why it is done and why it is intentional... Agreed. :) --D > Otherwise the code looks OK. > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Dave Chinner <david@fromorbit.com> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] iomap: Convert read_count to byte count Date: Tue, 25 Aug 2020 15:14:16 -0700 [thread overview] Message-ID: <20200825221416.GK6096@magnolia> (raw) In-Reply-To: <20200825000902.GG12131@dread.disaster.area> On Tue, Aug 25, 2020 at 10:09:02AM +1000, Dave Chinner wrote: > On Mon, Aug 24, 2020 at 03:55:07PM +0100, Matthew Wilcox (Oracle) wrote: > > Instead of counting bio segments, count the number of bytes submitted. > > This insulates us from the block layer's definition of what a 'same page' > > is, which is not necessarily clear once THPs are involved. > > I'd like to see a comment on the definition of struct iomap_page to > indicate that read_count (and write count) reflect the byte count of > IO currently in flight on the page, not an IO count, because THP > makes tracking this via bio state hard. Otherwise it is not at all > obvious why it is done and why it is intentional... Agreed. :) --D > Otherwise the code looks OK. > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com
next prev parent reply other threads:[~2020-08-25 22:14 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-24 14:55 [PATCH 0/9] THP iomap patches for 5.10 Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 14:55 ` [PATCH 1/9] iomap: Fix misplaced page flushing Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:51 ` Dave Chinner 2020-08-24 23:51 ` Dave Chinner 2020-08-25 20:47 ` Darrick J. Wong 2020-08-25 20:47 ` Darrick J. Wong 2020-08-27 8:24 ` Christoph Hellwig 2020-08-27 8:24 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 2/9] fs: Introduce i_blocks_per_page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:55 ` Dave Chinner 2020-08-24 23:55 ` Dave Chinner 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 22:21 ` Dave Chinner 2020-08-25 22:21 ` Dave Chinner 2020-08-24 14:55 ` [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:56 ` Dave Chinner 2020-08-24 23:56 ` Dave Chinner 2020-08-25 20:49 ` Darrick J. Wong 2020-08-25 20:49 ` Darrick J. Wong 2020-08-24 14:55 ` [PATCH 4/9] iomap: Use bitmap ops to set uptodate bits Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:56 ` Dave Chinner 2020-08-24 23:56 ` Dave Chinner 2020-08-25 20:50 ` Darrick J. Wong 2020-08-25 20:50 ` Darrick J. Wong 2020-08-24 14:55 ` [PATCH 5/9] iomap: Support arbitrarily many blocks per page Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-24 23:59 ` Dave Chinner 2020-08-24 23:59 ` Dave Chinner 2020-08-25 0:22 ` Matthew Wilcox 2020-08-25 0:22 ` Matthew Wilcox 2020-08-25 21:02 ` Darrick J. Wong 2020-08-25 21:02 ` Darrick J. Wong 2020-08-26 2:26 ` Matthew Wilcox 2020-08-26 2:26 ` Matthew Wilcox 2020-08-26 3:32 ` Darrick J. Wong 2020-08-26 3:32 ` Darrick J. Wong 2020-08-27 8:26 ` Christoph Hellwig 2020-08-27 8:26 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 6/9] iomap: Convert read_count to byte count Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:09 ` Dave Chinner 2020-08-25 0:09 ` Dave Chinner 2020-08-25 22:14 ` Darrick J. Wong [this message] 2020-08-25 22:14 ` Darrick J. Wong 2020-08-27 8:35 ` Christoph Hellwig 2020-08-27 8:35 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 7/9] iomap: Convert write_count " Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-27 8:36 ` Christoph Hellwig 2020-08-27 8:36 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 8/9] iomap: Convert iomap_write_end types Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:12 ` Dave Chinner 2020-08-25 0:12 ` Dave Chinner 2020-08-25 1:06 ` Matthew Wilcox 2020-08-25 1:06 ` Matthew Wilcox 2020-08-25 1:33 ` Dave Chinner 2020-08-25 1:33 ` Dave Chinner 2020-08-27 8:41 ` Christoph Hellwig 2020-08-27 8:41 ` Christoph Hellwig 2020-08-24 14:55 ` [PATCH 9/9] iomap: Change calling convention for zeroing Matthew Wilcox (Oracle) 2020-08-24 14:55 ` Matthew Wilcox (Oracle) 2020-08-25 0:27 ` Dave Chinner 2020-08-25 0:27 ` Dave Chinner 2020-08-25 3:26 ` Matthew Wilcox 2020-08-25 3:26 ` Matthew Wilcox 2020-08-25 3:35 ` Andreas Dilger 2020-08-25 4:27 ` Dave Chinner 2020-08-25 4:27 ` Dave Chinner 2020-08-25 12:40 ` Matthew Wilcox 2020-08-25 12:40 ` Matthew Wilcox 2020-08-25 22:05 ` Dave Chinner 2020-08-25 22:05 ` Dave Chinner 2020-08-25 22:23 ` Darrick J. Wong 2020-08-25 22:23 ` Darrick J. Wong 2020-08-27 8:39 ` Christoph Hellwig 2020-08-27 8:39 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200825221416.GK6096@magnolia \ --to=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-xfs@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.