Re: [net-next v5 08/15] iecm: Implement vector allocation

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 27 Aug 2020 17:28:29 +0000 Brady, Alan wrote:
> > On Mon, 24 Aug 2020 10:32:59 -0700 Tony Nguyen wrote:  
> > >  static void iecm_mb_intr_rel_irq(struct iecm_adapter *adapter)  {
> > > -	/* stub */
> > > +	int irq_num;
> > > +
> > > +	irq_num = adapter->msix_entries[0].vector;
> > > +	synchronize_irq(irq_num);  
> > 
> > I don't think you need to sync irq before freeing it.
> 
> I see other non-Intel drivers syncing before disable/free and Intel
> drivers have historically done it, not that that's necessarily
> correct, but are you certain?

/**
 *	free_irq - free an interrupt allocated with request_irq
 *	@irq: Interrupt line to free
 *	@dev_id: Device identity to free
 *
 *	Remove an interrupt handler. The handler is removed and if the
 *	interrupt line is no longer in use by any driver it is disabled.
 *	On a shared IRQ the caller must ensure the interrupt is disabled
 *	on the card it drives before calling this function. The function
 *	does not return until any executing interrupts for this IRQ
 *	have completed.
 *
 *	This function must not be called from interrupt context.
 *
 *	Returns the devname argument passed to request_irq.
 */