RE: [net-next v5 01/15] virtchnl: Extend AVF ops

["Brady, Alan" <alan.brady@intel.com>]

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Monday, August 24, 2020 12:43 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; Michael, Alice <alice.michael@intel.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brady, Alan
> <alan.brady@intel.com>; Burra, Phani R <phani.r.burra@intel.com>; Hay,
> Joshua A <joshua.a.hay@intel.com>; Chittim, Madhu
> <madhu.chittim@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Samudrala, Sridhar
> <sridhar.samudrala@intel.com>
> Subject: Re: [net-next v5 01/15] virtchnl: Extend AVF ops
> 
> On Mon, 24 Aug 2020 10:32:52 -0700 Tony Nguyen wrote:
> > +struct virtchnl_rss_hash {
> > +	u64 hash;
> > +	u16 vport_id;
> > +};
> > +
> > +VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_rss_hash);
> 
> I've added 32bit builds to my local setup since v4 was posted - looks like there's
> a number of errors here. You can't assume u64 forces a 64bit alignment. Best to
> specify the padding explicitly.
> 
> FWIW these are the errors I got but there may be more:
> 

It seems like these are triggering on old messages too, curious why this wasn't caught sooner.  Will fix, thanks.

-Alan