RE: [net-next v5 04/15] iecm: Common module introduction and function stubs

["Brady, Alan" <alan.brady@intel.com>]

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Monday, August 24, 2020 1:41 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; Michael, Alice <alice.michael@intel.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brady, Alan
> <alan.brady@intel.com>; Burra, Phani R <phani.r.burra@intel.com>; Hay,
> Joshua A <joshua.a.hay@intel.com>; Chittim, Madhu
> <madhu.chittim@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Samudrala, Sridhar
> <sridhar.samudrala@intel.com>
> Subject: Re: [net-next v5 04/15] iecm: Common module introduction and
> function stubs
> 
> On Mon, 24 Aug 2020 10:32:55 -0700 Tony Nguyen wrote:
> > +static inline bool
> > +iecm_tx_singleq_clean_all(struct iecm_q_vector *q_vec, int budget) {
> > +	/* stub */
> > +}
> 
> Still a lot of static inlines throughout. Are they making any difference? The
> compiler will inline static functions, anyway.

We haven't profiled the inlines to verify they're doing anything, perhaps just some misguided preemptive performance attempt.  We can remove them.  Will fix.

-alan