From: Dan Carpenter <dan.carpenter@oracle.com> To: Cengiz Can <cengiz@kernel.wtf> Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning Date: Mon, 31 Aug 2020 16:40:21 +0300 [thread overview] Message-ID: <20200831134021.GV8299@kadam> (raw) In-Reply-To: <20200831133011.91258-1-cengiz@kernel.wtf> On Mon, Aug 31, 2020 at 04:30:12PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements, Coverity Static Analyzer > throws a warning that 'fallthrough' is unreachable due to the adjacent > 'return false' statement. > > Since 'fallthrough' is actually an empty "do {} while(0)" this might be > due to compiler optimizations. But that needs further investigation. > > In order to fix the unreachable code warning, make adjacent 'return > false' a part of the previous if statement's else clause. > > Reported-by: Coverity Static Analyzer CID 1466511 > Signed-off-by: Cengiz Can <cengiz@kernel.wtf> > --- > drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > index 1b2b2c68025b..aaa2d0e0851b 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > @@ -709,8 +709,8 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd, > if (pipe_id == IA_CSS_PIPE_ID_CAPTURE || > pipe_id == IA_CSS_PIPE_ID_PREVIEW) > return true; > - > - return false; > + else > + return false; > fallthrough; Heh... Still unreachable, but now it has a checkpatch.pl warning as well. Just get rid of the bogus fallthrough annotation. > case ATOMISP_RUN_MODE_VIDEO: > if (!asd->continuous_mode->val) { regards, dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Cengiz Can <cengiz@kernel.wtf> Cc: devel@driverdev.osuosl.org, Mauro Carvalho Chehab <mchehab@kernel.org>, "Gustavo A . R . Silva" <gustavoars@kernel.org>, linux-kernel@vger.kernel.org, Sakari Ailus <sakari.ailus@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-media@vger.kernel.org Subject: Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning Date: Mon, 31 Aug 2020 16:40:21 +0300 [thread overview] Message-ID: <20200831134021.GV8299@kadam> (raw) In-Reply-To: <20200831133011.91258-1-cengiz@kernel.wtf> On Mon, Aug 31, 2020 at 04:30:12PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements, Coverity Static Analyzer > throws a warning that 'fallthrough' is unreachable due to the adjacent > 'return false' statement. > > Since 'fallthrough' is actually an empty "do {} while(0)" this might be > due to compiler optimizations. But that needs further investigation. > > In order to fix the unreachable code warning, make adjacent 'return > false' a part of the previous if statement's else clause. > > Reported-by: Coverity Static Analyzer CID 1466511 > Signed-off-by: Cengiz Can <cengiz@kernel.wtf> > --- > drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > index 1b2b2c68025b..aaa2d0e0851b 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c > @@ -709,8 +709,8 @@ static bool is_pipe_valid_to_current_run_mode(struct atomisp_sub_device *asd, > if (pipe_id == IA_CSS_PIPE_ID_CAPTURE || > pipe_id == IA_CSS_PIPE_ID_PREVIEW) > return true; > - > - return false; > + else > + return false; > fallthrough; Heh... Still unreachable, but now it has a checkpatch.pl warning as well. Just get rid of the bogus fallthrough annotation. > case ATOMISP_RUN_MODE_VIDEO: > if (!asd->continuous_mode->val) { regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-08-31 13:40 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-31 13:30 [PATCH] staging: atomisp: Fix fallthrough keyword warning Cengiz Can 2020-08-31 13:30 ` Cengiz Can 2020-08-31 13:40 ` Dan Carpenter [this message] 2020-08-31 13:40 ` Dan Carpenter 2020-08-31 13:45 ` Dan Carpenter 2020-08-31 13:45 ` Dan Carpenter 2020-08-31 13:51 ` [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough' Cengiz Can 2020-08-31 13:51 ` Cengiz Can 2020-08-31 14:28 ` Gustavo A. R. Silva 2020-08-31 14:28 ` Gustavo A. R. Silva 2020-08-31 14:35 ` [PATCH] staging: atomisp: Fix fallthrough keyword warning Mauro Carvalho Chehab 2020-08-31 14:35 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200831134021.GV8299@kadam \ --to=dan.carpenter@oracle.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=cengiz@kernel.wtf \ --cc=devel@driverdev.osuosl.org \ --cc=gustavoars@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.