All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cengiz Can <cengiz@kernel.wtf>
Cc: devel@driverdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	linux-kernel@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning
Date: Mon, 31 Aug 2020 16:45:57 +0300	[thread overview]
Message-ID: <20200831134557.GW8299@kadam> (raw)
In-Reply-To: <20200831134021.GV8299@kadam>

Really I think this function is pretty buggy.  It shouldn't be falling
through at all...  I reported it a couple days back so it's possible
that someone is working on a fix already.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cengiz Can <cengiz@kernel.wtf>
Cc: devel@driverdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	linux-kernel@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning
Date: Mon, 31 Aug 2020 16:45:57 +0300	[thread overview]
Message-ID: <20200831134557.GW8299@kadam> (raw)
In-Reply-To: <20200831134021.GV8299@kadam>

Really I think this function is pretty buggy.  It shouldn't be falling
through at all...  I reported it a couple days back so it's possible
that someone is working on a fix already.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-08-31 13:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 13:30 [PATCH] staging: atomisp: Fix fallthrough keyword warning Cengiz Can
2020-08-31 13:30 ` Cengiz Can
2020-08-31 13:40 ` Dan Carpenter
2020-08-31 13:40   ` Dan Carpenter
2020-08-31 13:45   ` Dan Carpenter [this message]
2020-08-31 13:45     ` Dan Carpenter
2020-08-31 13:51   ` [PATCH v2] staging: atomisp: Remove unnecessary 'fallthrough' Cengiz Can
2020-08-31 13:51     ` Cengiz Can
2020-08-31 14:28     ` Gustavo A. R. Silva
2020-08-31 14:28       ` Gustavo A. R. Silva
2020-08-31 14:35 ` [PATCH] staging: atomisp: Fix fallthrough keyword warning Mauro Carvalho Chehab
2020-08-31 14:35   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831134557.GW8299@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=cengiz@kernel.wtf \
    --cc=devel@driverdev.osuosl.org \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.