From: "Björn Töpel" <bjorn.topel@gmail.com> To: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, bpf@vger.kernel.org Cc: "Björn Töpel" <bjorn.topel@intel.com>, magnus.karlsson@intel.com, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH bpf-next 2/6] xdp: introduce xdp_do_redirect_ext() function Date: Fri, 4 Sep 2020 15:53:27 +0200 [thread overview] Message-ID: <20200904135332.60259-3-bjorn.topel@gmail.com> (raw) In-Reply-To: <20200904135332.60259-1-bjorn.topel@gmail.com> From: Björn Töpel <bjorn.topel@intel.com> Introduce the xdp_do_redirect_ext() which returns additional information to the caller. For now, it is the type of map that the packet was redirected to. This enables the driver to have more fine-grained control, e.g. is the redirect fails due to full AF_XDP Rx queue (error code ENOBUFS and map is XSKMAP), a zero-copy enabled driver should yield to userland as soon as possible. Signed-off-by: Björn Töpel <bjorn.topel@intel.com> --- include/linux/filter.h | 2 ++ net/core/filter.c | 16 ++++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/linux/filter.h b/include/linux/filter.h index 995625950cc1..0060c2c8abc3 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -942,6 +942,8 @@ static inline int xdp_ok_fwd_dev(const struct net_device *fwd, */ int xdp_do_generic_redirect(struct net_device *dev, struct sk_buff *skb, struct xdp_buff *xdp, struct bpf_prog *prog); +int xdp_do_redirect_ext(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog, enum bpf_map_type *map_type); int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, struct bpf_prog *prog); diff --git a/net/core/filter.c b/net/core/filter.c index 47eef9a0be6a..ce6098210a23 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -3596,8 +3596,8 @@ void bpf_clear_redirect_map(struct bpf_map *map) } } -int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, - struct bpf_prog *xdp_prog) +int xdp_do_redirect_ext(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog, enum bpf_map_type *map_type) { struct bpf_redirect_info *ri = this_cpu_ptr(&bpf_redirect_info); struct bpf_map *map = READ_ONCE(ri->map); @@ -3609,6 +3609,8 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, ri->tgt_value = NULL; WRITE_ONCE(ri->map, NULL); + *map_type = BPF_MAP_TYPE_UNSPEC; + if (unlikely(!map)) { fwd = dev_get_by_index_rcu(dev_net(dev), index); if (unlikely(!fwd)) { @@ -3618,6 +3620,7 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, err = dev_xdp_enqueue(fwd, xdp, dev); } else { + *map_type = map->map_type; err = __bpf_tx_xdp_map(dev, fwd, map, xdp); } @@ -3630,6 +3633,15 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, _trace_xdp_redirect_map_err(dev, xdp_prog, fwd, map, index, err); return err; } +EXPORT_SYMBOL_GPL(xdp_do_redirect_ext); + +int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog) +{ + enum bpf_map_type dummy; + + return xdp_do_redirect_ext(dev, xdp, xdp_prog, &dummy); +} EXPORT_SYMBOL_GPL(xdp_do_redirect); static int xdp_do_generic_redirect_map(struct net_device *dev, -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= <bjorn.topel@gmail.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH bpf-next 2/6] xdp: introduce xdp_do_redirect_ext() function Date: Fri, 4 Sep 2020 15:53:27 +0200 [thread overview] Message-ID: <20200904135332.60259-3-bjorn.topel@gmail.com> (raw) In-Reply-To: <20200904135332.60259-1-bjorn.topel@gmail.com> From: Bj?rn T?pel <bjorn.topel@intel.com> Introduce the xdp_do_redirect_ext() which returns additional information to the caller. For now, it is the type of map that the packet was redirected to. This enables the driver to have more fine-grained control, e.g. is the redirect fails due to full AF_XDP Rx queue (error code ENOBUFS and map is XSKMAP), a zero-copy enabled driver should yield to userland as soon as possible. Signed-off-by: Bj?rn T?pel <bjorn.topel@intel.com> --- include/linux/filter.h | 2 ++ net/core/filter.c | 16 ++++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/linux/filter.h b/include/linux/filter.h index 995625950cc1..0060c2c8abc3 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -942,6 +942,8 @@ static inline int xdp_ok_fwd_dev(const struct net_device *fwd, */ int xdp_do_generic_redirect(struct net_device *dev, struct sk_buff *skb, struct xdp_buff *xdp, struct bpf_prog *prog); +int xdp_do_redirect_ext(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog, enum bpf_map_type *map_type); int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, struct bpf_prog *prog); diff --git a/net/core/filter.c b/net/core/filter.c index 47eef9a0be6a..ce6098210a23 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -3596,8 +3596,8 @@ void bpf_clear_redirect_map(struct bpf_map *map) } } -int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, - struct bpf_prog *xdp_prog) +int xdp_do_redirect_ext(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog, enum bpf_map_type *map_type) { struct bpf_redirect_info *ri = this_cpu_ptr(&bpf_redirect_info); struct bpf_map *map = READ_ONCE(ri->map); @@ -3609,6 +3609,8 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, ri->tgt_value = NULL; WRITE_ONCE(ri->map, NULL); + *map_type = BPF_MAP_TYPE_UNSPEC; + if (unlikely(!map)) { fwd = dev_get_by_index_rcu(dev_net(dev), index); if (unlikely(!fwd)) { @@ -3618,6 +3620,7 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, err = dev_xdp_enqueue(fwd, xdp, dev); } else { + *map_type = map->map_type; err = __bpf_tx_xdp_map(dev, fwd, map, xdp); } @@ -3630,6 +3633,15 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, _trace_xdp_redirect_map_err(dev, xdp_prog, fwd, map, index, err); return err; } +EXPORT_SYMBOL_GPL(xdp_do_redirect_ext); + +int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, + struct bpf_prog *xdp_prog) +{ + enum bpf_map_type dummy; + + return xdp_do_redirect_ext(dev, xdp, xdp_prog, &dummy); +} EXPORT_SYMBOL_GPL(xdp_do_redirect); static int xdp_do_generic_redirect_map(struct net_device *dev, -- 2.25.1
next prev parent reply other threads:[~2020-09-04 13:55 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-04 13:53 [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring is full Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:53 ` [PATCH bpf-next 1/6] xsk: improve xdp_do_redirect() error codes Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:53 ` Björn Töpel [this message] 2020-09-04 13:53 ` [Intel-wired-lan] [PATCH bpf-next 2/6] xdp: introduce xdp_do_redirect_ext() function =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:53 ` [PATCH bpf-next 3/6] xsk: introduce xsk_do_redirect_rx_full() helper Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 15:11 ` Jesper Dangaard Brouer 2020-09-04 15:11 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-09-04 15:39 ` Björn Töpel 2020-09-04 15:39 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-07 12:45 ` Jesper Dangaard Brouer 2020-09-07 12:45 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-09-04 13:53 ` [PATCH bpf-next 4/6] i40e, xsk: finish napi loop if AF_XDP Rx queue is full Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:53 ` [PATCH bpf-next 5/6] ice, " Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:53 ` [PATCH bpf-next 6/6] ixgbe, " Björn Töpel 2020-09-04 13:53 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 15:35 ` Jesper Dangaard Brouer 2020-09-04 15:35 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-09-04 15:54 ` Björn Töpel 2020-09-04 15:54 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 13:59 ` [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring " Björn Töpel 2020-09-04 13:59 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-08 10:32 ` Maxim Mikityanskiy 2020-09-08 10:32 ` [Intel-wired-lan] " Maxim Mikityanskiy 2020-09-08 11:37 ` Magnus Karlsson 2020-09-08 11:37 ` [Intel-wired-lan] " Magnus Karlsson 2020-09-08 12:21 ` Björn Töpel 2020-09-08 12:21 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-09 15:37 ` Jesper Dangaard Brouer 2020-09-09 15:37 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-09-04 14:27 ` Jesper Dangaard Brouer 2020-09-04 14:27 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-09-04 14:32 ` Björn Töpel 2020-09-04 14:32 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-04 23:58 ` Jakub Kicinski 2020-09-04 23:58 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-07 13:37 ` Björn Töpel 2020-09-07 13:37 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-07 18:40 ` Jakub Kicinski 2020-09-07 18:40 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-08 6:58 ` Björn Töpel 2020-09-08 6:58 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-08 17:24 ` Jakub Kicinski 2020-09-08 17:24 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-08 18:28 ` Björn Töpel 2020-09-08 18:28 ` [Intel-wired-lan] " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= 2020-09-08 18:34 ` Jakub Kicinski 2020-09-08 18:34 ` [Intel-wired-lan] " Jakub Kicinski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200904135332.60259-3-bjorn.topel@gmail.com \ --to=bjorn.topel@gmail.com \ --cc=ast@kernel.org \ --cc=bjorn.topel@intel.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=hawk@kernel.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=john.fastabend@gmail.com \ --cc=kuba@kernel.org \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.