[PATCH v3 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing

[PATCH v3 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing

[Bryan O'Donoghue]

This series is two in a set of seven to add support for wcn3680 at 802.11ac
data-rates.

V3:
- Enables MU-MIMO bits in wcn36xx_smd_set_sta_vht_params()
- Adds a set of helper functions. In the previous set these unused
  declarations would cause a warning during compile because they were
  declared static with the intention to add code later on to use them.

  To resolve that, I do not declare the functions static. Static
  declaration is done in a later patch after the functions have been used.

- There are two good reasons for this:
  1. Granularity. I think its important and useful to have a patch per
     function that clearly sets out what it does and why.
  2. Patch size. Declaring seven functions at the time of their first
     use is not good practice.

I think maintaining patch granularity is a good enough reason to not squash
these commits down. It is pretty trivial to declare the functions static
later on without generating compile warnings in the interregnum.

V2:
This set makes a series of modifications to enable passing of an extended
V1 data-structure to the firmware.

A series of of helper functions are added to facilitate the setup.

The final step in the process is enabling the extended data-structure
parameter passing for the wcn3680 only.

Only a firmware that is capable of 80211.ac will accept the larger V1
messages and only after explicitly enabling the DOT11AC firmware feature
bit.

- No functional difference from V1 for these patches
  Breaking into smaller chunks to enable easier review/merging

V1:

https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t

Bryan O'Donoghue (7):
  wcn36xx: Add wcn36xx_set_default_rates_v1
  wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()
  wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()
  wcn36xx: Add wcn36xx_smd_set_sta_vht_params()
  wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()
  wcn36xx: Add wcn36xx_smd_set_bss_vht_params()
  wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1()

 drivers/net/wireless/ath/wcn36xx/main.c    |  8 ++
 drivers/net/wireless/ath/wcn36xx/smd.c     | 88 ++++++++++++++++++++++
 drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  1 +
 3 files changed, 97 insertions(+)

-- 
2.27.0

[PATCH v3 1/7] wcn36xx: Add wcn36xx_set_default_rates_v1

[Bryan O'Donoghue]

Add a routine to set some additional default parameters associated with the
V1 data structure.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/main.c    | 8 ++++++++
 drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 +
 2 files changed, 9 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index eb518bd88870..ba37439352a7 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -793,6 +793,14 @@ void wcn36xx_set_default_rates(struct wcn36xx_hal_supported_rates *rates)
 		sizeof(*ofdm_rates) * WCN36XX_HAL_NUM_OFDM_RATES);
 	rates->supported_mcs_set[0] = 0xFF;
 }
+
+void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates)
+{
+	rates->op_rate_mode = STA_11ac;
+	rates->vht_rx_mcs_map = IEEE80211_VHT_MCS_SUPPORT_0_9;
+	rates->vht_tx_mcs_map = IEEE80211_VHT_MCS_SUPPORT_0_9;
+}
+
 static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
 				     struct ieee80211_vif *vif,
 				     struct ieee80211_bss_conf *bss_conf,
diff --git a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
index d7d349de20e6..2da81d9926c4 100644
--- a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
+++ b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
@@ -271,6 +271,7 @@ static inline bool wcn36xx_is_fw_version(struct wcn36xx *wcn,
 		wcn->fw_revision == revision);
 }
 void wcn36xx_set_default_rates(struct wcn36xx_hal_supported_rates *rates);
+void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
 
 static inline
 struct ieee80211_sta *wcn36xx_priv_to_sta(struct wcn36xx_sta *sta_priv)
-- 
2.27.0

[PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()

[Bryan O'Donoghue]

This commit adds support for setting default VHT parameters, which are
exposed by the extended version 1 STA parameter type.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index d5ca9907af86..bb31c4d4d9a8 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -190,6 +190,22 @@ static void wcn36xx_smd_set_sta_default_ht_params(
 	sta_params->dsss_cck_mode_40mhz = 1;
 }
 
+void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
+		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
+{
+	if (wcn->rf_id == RF_IRIS_WCN3680) {
+		sta_params->vht_capable = 1;
+		sta_params->vht_tx_mu_beamformee_capable = 1;
+	} else {
+		sta_params->vht_capable = 0;
+		sta_params->vht_tx_mu_beamformee_capable = 0;
+	}
+
+	sta_params->vht_ldpc_enabled = 0;
+	sta_params->vht_tx_channel_width_set = 0;
+	sta_params->vht_tx_bf_enabled = 0;
+}
+
 static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
 		struct ieee80211_vif *vif,
 		struct ieee80211_sta *sta,
-- 
2.27.0

[PATCH v3 3/7] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()

[Bryan O'Donoghue]

Toggling the LDPC enabled bit is possible only via the extended V1
data-structure. This function provides a means of setting the default
depending on chip-type.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index bb31c4d4d9a8..3f57acfe11bb 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -206,6 +206,15 @@ void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
 	sta_params->vht_tx_bf_enabled = 0;
 }
 
+void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
+		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
+{
+	if (wcn->rf_id == RF_IRIS_WCN3680)
+		sta_params->ht_ldpc_enabled = 1;
+	else
+		sta_params->ht_ldpc_enabled = 0;
+}
+
 static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
 		struct ieee80211_vif *vif,
 		struct ieee80211_sta *sta,
-- 
2.27.0

[PATCH v3 4/7] wcn36xx: Add wcn36xx_smd_set_sta_vht_params()

[Bryan O'Donoghue]

This commit adds support for setting VHT parameters based on the declared
VHT capability bits in the VHT capability structure.

We cannot do 160MHz so VHT Channel width set should be zero.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 3f57acfe11bb..a563a30c3a0c 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -174,6 +174,28 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
 	}
 }
 
+void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
+		struct ieee80211_sta *sta,
+		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
+{
+	if (sta->vht_cap.vht_supported) {
+		unsigned long caps = sta->vht_cap.cap;
+
+		sta_params->vht_capable = sta->vht_cap.vht_supported;
+		sta_params->vht_ldpc_enabled =
+			is_cap_supported(caps, IEEE80211_VHT_CAP_RXLDPC);
+		if (get_feat_caps(wcn->fw_feat_caps, MU_MIMO)) {
+			sta_params->vht_tx_mu_beamformee_capable =
+				is_cap_supported(caps, IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
+			if (sta_params->vht_tx_mu_beamformee_capable)
+			       sta_params->vht_tx_bf_enabled = 1;
+		} else {
+			sta_params->vht_tx_mu_beamformee_capable = 0;
+		}
+		sta_params->vht_tx_channel_width_set = 0;
+	}
+}
+
 static void wcn36xx_smd_set_sta_default_ht_params(
 		struct wcn36xx_hal_config_sta_params *sta_params)
 {
-- 
2.27.0

[PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()

[Bryan O'Donoghue]

Adds a routine to allow setting the LDPC bit for HT parameter passing
inside the version 1 STA parameters data structure.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index a563a30c3a0c..14af98af42f3 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -196,6 +196,15 @@ void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
 	}
 }
 
+void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
+		struct wcn36xx_hal_config_sta_params_v1 *sta_params)
+{
+	if (sta->ht_cap.ht_supported) {
+		sta_params->ht_ldpc_enabled =
+			is_cap_supported(sta->ht_cap.cap, IEEE80211_HT_CAP_LDPC_CODING);
+	}
+}
+
 static void wcn36xx_smd_set_sta_default_ht_params(
 		struct wcn36xx_hal_config_sta_params *sta_params)
 {
-- 
2.27.0

[PATCH v3 6/7] wcn36xx: Add wcn36xx_smd_set_bss_vht_params()

[Bryan O'Donoghue]

This commit adds wcn36xx_smd_set_bss_vht_params(). The job of this function
is to decide if the BSS is VHT capable and if so set the appropriate bit
in the BSS parameter structure for passing to the firmware.

VHT Channel width set is not set since we don't support 160MHz.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 14af98af42f3..fa6f5943a43d 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -146,6 +146,15 @@ static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif,
 	}
 }
 
+void
+wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
+			       struct ieee80211_sta *sta,
+			       struct wcn36xx_hal_config_bss_params_v1 *bss)
+{
+	if (sta && sta->vht_cap.vht_supported)
+		bss->vht_capable = 1;
+}
+
 static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
 		struct wcn36xx_hal_config_sta_params *sta_params)
 {
-- 
2.27.0

[PATCH v3 7/7] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1()

[Bryan O'Donoghue]

This commit adds a wrapper function wcn36xx_smd_set_sta_params_v1() which
calls into wcn36xx_smd_set_sta_params() and then subsequently sets
version-1 specific parameters.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index fa6f5943a43d..f434c355d32d 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -1249,6 +1249,31 @@ static void wcn36xx_smd_convert_sta_to_v1(struct wcn36xx *wcn,
 	v1->p2p = orig->p2p;
 }
 
+void
+wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
+			      struct ieee80211_vif *vif,
+			      struct ieee80211_sta *sta,
+			      struct wcn36xx_hal_config_sta_params_v1 *sta_par)
+{
+	struct wcn36xx_sta *sta_priv = NULL;
+	struct wcn36xx_hal_config_sta_params sta_par_v0;
+
+	wcn36xx_smd_set_sta_params(wcn, vif, sta, &sta_par_v0);
+	wcn36xx_smd_convert_sta_to_v1(wcn, &sta_par_v0, sta_par);
+
+	if (sta) {
+		sta_priv = wcn36xx_sta_to_priv(sta);
+		wcn36xx_smd_set_sta_vht_params(wcn, sta, sta_par);
+		wcn36xx_smd_set_sta_ht_ldpc_params(sta, sta_par);
+		memcpy(&sta_par->supported_rates, &sta_priv->supported_rates,
+		       sizeof(sta_par->supported_rates));
+	} else {
+		wcn36xx_set_default_rates_v1(&sta_par->supported_rates);
+		wcn36xx_smd_set_sta_default_vht_params(wcn, sta_par);
+		wcn36xx_smd_set_sta_default_ht_ldpc_params(wcn, sta_par);
+	}
+}
+
 static int wcn36xx_smd_config_sta_rsp(struct wcn36xx *wcn,
 				      struct ieee80211_sta *sta,
 				      void *buf,
-- 
2.27.0

Re: [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5175 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/smd.c:192:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     192 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     195 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:196:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     196 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:197:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     197 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:199:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     199 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:200:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     200 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:203:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     203 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:204:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     204 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:205:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     205 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~

# https://github.com/0day-ci/linux/commit/0b840a269eba144bf378cdbd20160813582915a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout 0b840a269eba144bf378cdbd20160813582915a2
vim +/wcn36xx_smd_set_sta_default_vht_params +192 drivers/net/wireless/ath/wcn36xx/smd.c

   191	
 > 192	void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
   193			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   194	{
   195		if (wcn->rf_id == RF_IRIS_WCN3680) {
   196			sta_params->vht_capable = 1;
   197			sta_params->vht_tx_mu_beamformee_capable = 1;
   198		} else {
   199			sta_params->vht_capable = 0;
   200			sta_params->vht_tx_mu_beamformee_capable = 0;
   201		}
   202	
   203		sta_params->vht_ldpc_enabled = 0;
   204		sta_params->vht_tx_channel_width_set = 0;
   205		sta_params->vht_tx_bf_enabled = 0;
   206	}
   207	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]

Re: [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5266 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/smd.c:192:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     192 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     195 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:196:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     196 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:197:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     197 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:199:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     199 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:200:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     200 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:203:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     203 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:204:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     204 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:205:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     205 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~

# https://github.com/0day-ci/linux/commit/0b840a269eba144bf378cdbd20160813582915a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout 0b840a269eba144bf378cdbd20160813582915a2
vim +/wcn36xx_smd_set_sta_default_vht_params +192 drivers/net/wireless/ath/wcn36xx/smd.c

   191	
 > 192	void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
   193			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   194	{
   195		if (wcn->rf_id == RF_IRIS_WCN3680) {
   196			sta_params->vht_capable = 1;
   197			sta_params->vht_tx_mu_beamformee_capable = 1;
   198		} else {
   199			sta_params->vht_capable = 0;
   200			sta_params->vht_tx_mu_beamformee_capable = 0;
   201		}
   202	
   203		sta_params->vht_ldpc_enabled = 0;
   204		sta_params->vht_tx_channel_width_set = 0;
   205		sta_params->vht_tx_bf_enabled = 0;
   206	}
   207	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]

Re: [PATCH v3 3/7] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 6752 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:192:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     192 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     195 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:196:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     196 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:197:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     197 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:199:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     199 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:200:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     200 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:203:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     203 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:204:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     204 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:205:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     205 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
>> drivers/net/wireless/ath/wcn36xx/smd.c:208:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
     208 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_ht_ldpc_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:211:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     211 |  if (wcn->rf_id == RF_IRIS_WCN3680)
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:212:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     212 |   sta_params->ht_ldpc_enabled = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:214:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     214 |   sta_params->ht_ldpc_enabled = 0;
         |             ^~

# https://github.com/0day-ci/linux/commit/be351ca1dba76b7614d19b590f28f9977666e42f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout be351ca1dba76b7614d19b590f28f9977666e42f
vim +/wcn36xx_smd_set_sta_default_ht_ldpc_params +208 drivers/net/wireless/ath/wcn36xx/smd.c

   191	
   192	void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
   193			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   194	{
   195		if (wcn->rf_id == RF_IRIS_WCN3680) {
   196			sta_params->vht_capable = 1;
   197			sta_params->vht_tx_mu_beamformee_capable = 1;
   198		} else {
   199			sta_params->vht_capable = 0;
   200			sta_params->vht_tx_mu_beamformee_capable = 0;
   201		}
   202	
   203		sta_params->vht_ldpc_enabled = 0;
 > 204		sta_params->vht_tx_channel_width_set = 0;
   205		sta_params->vht_tx_bf_enabled = 0;
   206	}
   207	
 > 208	void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
   209			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   210	{
   211		if (wcn->rf_id == RF_IRIS_WCN3680)
   212			sta_params->ht_ldpc_enabled = 1;
   213		else
   214			sta_params->ht_ldpc_enabled = 0;
   215	}
   216	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]

Re: [PATCH v3 4/7] wcn36xx: Add wcn36xx_smd_set_sta_vht_params()

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 15439 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/smd.c:176:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_vht_params' [-Wmissing-prototypes]
     176 | void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:183:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     183 |   sta_params->vht_capable = sta->vht_cap.vht_supported;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:184:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     184 |   sta_params->vht_ldpc_enabled =
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:187:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     187 |    sta_params->vht_tx_mu_beamformee_capable =
         |              ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:189:18: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     189 |    if (sta_params->vht_tx_mu_beamformee_capable)
         |                  ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:190:21: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     190 |           sta_params->vht_tx_bf_enabled = 1;
         |                     ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:192:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     192 |    sta_params->vht_tx_mu_beamformee_capable = 0;
         |              ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:194:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     194 |   sta_params->vht_tx_channel_width_set = 0;
         |               ^~~~~~~~~~~~~~~~~~~~~~~~
         |               tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
   drivers/net/wireless/ath/wcn36xx/smd.c:214:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     214 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:217:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     217 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:217:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:218:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     218 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:219:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     219 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:221:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     221 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:222:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     222 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:225:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     225 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:226:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     226 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:227:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     227 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
   drivers/net/wireless/ath/wcn36xx/smd.c:230:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
     230 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_ht_ldpc_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:233:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     233 |  if (wcn->rf_id == RF_IRIS_WCN3680)
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:234:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     234 |   sta_params->ht_ldpc_enabled = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:236:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     236 |   sta_params->ht_ldpc_enabled = 0;
         |             ^~

# https://github.com/0day-ci/linux/commit/76f4208f3d22143a4a6135347aa41da15ebee26a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout 76f4208f3d22143a4a6135347aa41da15ebee26a
vim +/wcn36xx_smd_set_sta_vht_params +176 drivers/net/wireless/ath/wcn36xx/smd.c

    18	
    19	#include <linux/etherdevice.h>
    20	#include <linux/firmware.h>
    21	#include <linux/bitops.h>
    22	#include <linux/rpmsg.h>
  > 23	#include "smd.h"
    24	
    25	struct wcn36xx_cfg_val {
    26		u32 cfg_id;
    27		u32 value;
    28	};
    29	
    30	#define WCN36XX_CFG_VAL(id, val) \
    31	{ \
    32		.cfg_id = WCN36XX_HAL_CFG_ ## id, \
    33		.value = val \
    34	}
    35	
    36	static struct wcn36xx_cfg_val wcn36xx_cfg_vals[] = {
    37		WCN36XX_CFG_VAL(CURRENT_TX_ANTENNA, 1),
    38		WCN36XX_CFG_VAL(CURRENT_RX_ANTENNA, 1),
    39		WCN36XX_CFG_VAL(LOW_GAIN_OVERRIDE, 0),
    40		WCN36XX_CFG_VAL(POWER_STATE_PER_CHAIN, 785),
    41		WCN36XX_CFG_VAL(CAL_PERIOD, 5),
    42		WCN36XX_CFG_VAL(CAL_CONTROL, 1),
    43		WCN36XX_CFG_VAL(PROXIMITY, 0),
    44		WCN36XX_CFG_VAL(NETWORK_DENSITY, 3),
    45		WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
    46		WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
    47		WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
    48		WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
    49		WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
    50		WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
    51		WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
    52		WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
    53		WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_TWO, 15),
    54		WCN36XX_CFG_VAL(FIXED_RATE, 0),
    55		WCN36XX_CFG_VAL(RETRYRATE_POLICY, 4),
    56		WCN36XX_CFG_VAL(RETRYRATE_SECONDARY, 0),
    57		WCN36XX_CFG_VAL(RETRYRATE_TERTIARY, 0),
    58		WCN36XX_CFG_VAL(FORCE_POLICY_PROTECTION, 5),
    59		WCN36XX_CFG_VAL(FIXED_RATE_MULTICAST_24GHZ, 1),
    60		WCN36XX_CFG_VAL(FIXED_RATE_MULTICAST_5GHZ, 5),
    61		WCN36XX_CFG_VAL(DEFAULT_RATE_INDEX_5GHZ, 5),
    62		WCN36XX_CFG_VAL(MAX_BA_SESSIONS, 40),
    63		WCN36XX_CFG_VAL(PS_DATA_INACTIVITY_TIMEOUT, 200),
    64		WCN36XX_CFG_VAL(PS_ENABLE_BCN_FILTER, 1),
    65		WCN36XX_CFG_VAL(PS_ENABLE_RSSI_MONITOR, 1),
    66		WCN36XX_CFG_VAL(NUM_BEACON_PER_RSSI_AVERAGE, 20),
    67		WCN36XX_CFG_VAL(STATS_PERIOD, 10),
    68		WCN36XX_CFG_VAL(CFP_MAX_DURATION, 30000),
    69		WCN36XX_CFG_VAL(FRAME_TRANS_ENABLED, 0),
    70		WCN36XX_CFG_VAL(BA_THRESHOLD_HIGH, 128),
    71		WCN36XX_CFG_VAL(MAX_BA_BUFFERS, 2560),
    72		WCN36XX_CFG_VAL(DYNAMIC_PS_POLL_VALUE, 0),
    73		WCN36XX_CFG_VAL(TX_PWR_CTRL_ENABLE, 1),
    74		WCN36XX_CFG_VAL(ENABLE_CLOSE_LOOP, 1),
    75		WCN36XX_CFG_VAL(ENABLE_LPWR_IMG_TRANSITION, 0),
    76		WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_BT, 120000),
    77		WCN36XX_CFG_VAL(BTC_STATIC_LEN_LE_WLAN, 30000),
    78		WCN36XX_CFG_VAL(MAX_ASSOC_LIMIT, 10),
    79		WCN36XX_CFG_VAL(ENABLE_MCC_ADAPTIVE_SCHEDULER, 0),
    80	};
    81	
    82	static int put_cfg_tlv_u32(struct wcn36xx *wcn, size_t *len, u32 id, u32 value)
    83	{
    84		struct wcn36xx_hal_cfg *entry;
    85		u32 *val;
    86	
    87		if (*len + sizeof(*entry) + sizeof(u32) >= WCN36XX_HAL_BUF_SIZE) {
    88			wcn36xx_err("Not enough room for TLV entry\n");
    89			return -ENOMEM;
    90		}
    91	
    92		entry = (struct wcn36xx_hal_cfg *) (wcn->hal_buf + *len);
    93		entry->id = id;
    94		entry->len = sizeof(u32);
    95		entry->pad_bytes = 0;
    96		entry->reserve = 0;
    97	
    98		val = (u32 *) (entry + 1);
    99		*val = value;
   100	
   101		*len += sizeof(*entry) + sizeof(u32);
   102	
   103		return 0;
   104	}
   105	
   106	static void wcn36xx_smd_set_bss_nw_type(struct wcn36xx *wcn,
   107			struct ieee80211_sta *sta,
   108			struct wcn36xx_hal_config_bss_params *bss_params)
   109	{
   110		if (NL80211_BAND_5GHZ == WCN36XX_BAND(wcn))
   111			bss_params->nw_type = WCN36XX_HAL_11A_NW_TYPE;
   112		else if (sta && sta->ht_cap.ht_supported)
   113			bss_params->nw_type = WCN36XX_HAL_11N_NW_TYPE;
   114		else if (sta && (sta->supp_rates[NL80211_BAND_2GHZ] & 0x7f))
   115			bss_params->nw_type = WCN36XX_HAL_11G_NW_TYPE;
   116		else
   117			bss_params->nw_type = WCN36XX_HAL_11B_NW_TYPE;
   118	}
   119	
   120	static inline u8 is_cap_supported(unsigned long caps, unsigned long flag)
   121	{
   122		return caps & flag ? 1 : 0;
   123	}
   124	static void wcn36xx_smd_set_bss_ht_params(struct ieee80211_vif *vif,
   125			struct ieee80211_sta *sta,
   126			struct wcn36xx_hal_config_bss_params *bss_params)
   127	{
   128		if (sta && sta->ht_cap.ht_supported) {
   129			unsigned long caps = sta->ht_cap.cap;
   130			bss_params->ht = sta->ht_cap.ht_supported;
   131			bss_params->tx_channel_width_set = is_cap_supported(caps,
   132				IEEE80211_HT_CAP_SUP_WIDTH_20_40);
   133			bss_params->lsig_tx_op_protection_full_support =
   134				is_cap_supported(caps,
   135						 IEEE80211_HT_CAP_LSIG_TXOP_PROT);
   136	
   137			bss_params->ht_oper_mode = vif->bss_conf.ht_operation_mode;
   138			bss_params->lln_non_gf_coexist =
   139				!!(vif->bss_conf.ht_operation_mode &
   140				   IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT);
   141			/* IEEE80211_HT_STBC_PARAM_DUAL_CTS_PROT */
   142			bss_params->dual_cts_protection = 0;
   143			/* IEEE80211_HT_OP_MODE_PROTECTION_20MHZ */
   144			bss_params->ht20_coexist = 0;
   145		}
   146	}
   147	
   148	static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
   149			struct wcn36xx_hal_config_sta_params *sta_params)
   150	{
   151		if (sta->ht_cap.ht_supported) {
   152			unsigned long caps = sta->ht_cap.cap;
   153			sta_params->ht_capable = sta->ht_cap.ht_supported;
   154			sta_params->tx_channel_width_set = is_cap_supported(caps,
   155				IEEE80211_HT_CAP_SUP_WIDTH_20_40);
   156			sta_params->lsig_txop_protection = is_cap_supported(caps,
   157				IEEE80211_HT_CAP_LSIG_TXOP_PROT);
   158	
   159			sta_params->max_ampdu_size = sta->ht_cap.ampdu_factor;
   160			sta_params->max_ampdu_density = sta->ht_cap.ampdu_density;
   161			sta_params->max_amsdu_size = is_cap_supported(caps,
   162				IEEE80211_HT_CAP_MAX_AMSDU);
   163			sta_params->sgi_20Mhz = is_cap_supported(caps,
   164				IEEE80211_HT_CAP_SGI_20);
   165			sta_params->sgi_40mhz =	is_cap_supported(caps,
   166				IEEE80211_HT_CAP_SGI_40);
   167			sta_params->green_field_capable = is_cap_supported(caps,
   168				IEEE80211_HT_CAP_GRN_FLD);
   169			sta_params->delayed_ba_support = is_cap_supported(caps,
   170				IEEE80211_HT_CAP_DELAY_BA);
   171			sta_params->dsss_cck_mode_40mhz = is_cap_supported(caps,
   172				IEEE80211_HT_CAP_DSSSCCK40);
   173		}
   174	}
   175	
 > 176	void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
   177			struct ieee80211_sta *sta,
   178			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   179	{
   180		if (sta->vht_cap.vht_supported) {
   181			unsigned long caps = sta->vht_cap.cap;
   182	
   183			sta_params->vht_capable = sta->vht_cap.vht_supported;
   184			sta_params->vht_ldpc_enabled =
   185				is_cap_supported(caps, IEEE80211_VHT_CAP_RXLDPC);
   186			if (get_feat_caps(wcn->fw_feat_caps, MU_MIMO)) {
   187				sta_params->vht_tx_mu_beamformee_capable =
   188					is_cap_supported(caps, IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
   189				if (sta_params->vht_tx_mu_beamformee_capable)
   190				       sta_params->vht_tx_bf_enabled = 1;
   191			} else {
   192				sta_params->vht_tx_mu_beamformee_capable = 0;
   193			}
   194			sta_params->vht_tx_channel_width_set = 0;
   195		}
   196	}
   197	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]

Re: [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()

[Bryan O'Donoghue]

On 09/09/2020 08:23, kernel test robot wrote:
> Hi Bryan,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on wireless-drivers-next/master]
> [also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]

Applies against

ath.git	git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
160b351d75cb - (tag: ath-202009090652, ath.git/master)

but, I don't mind resending after figuring out how to include --base

Re: [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params()

[Bryan O'Donoghue]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On 09/09/2020 08:23, kernel test robot wrote:
> Hi Bryan,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on wireless-drivers-next/master]
> [also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]

Applies against

ath.git	git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
160b351d75cb - (tag: ath-202009090652, ath.git/master)

but, I don't mind resending after figuring out how to include --base

Re: [PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params()

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 9952 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:176:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_vht_params' [-Wmissing-prototypes]
     176 | void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:183:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     183 |   sta_params->vht_capable = sta->vht_cap.vht_supported;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:184:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     184 |   sta_params->vht_ldpc_enabled =
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:187:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     187 |    sta_params->vht_tx_mu_beamformee_capable =
         |              ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:189:18: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     189 |    if (sta_params->vht_tx_mu_beamformee_capable)
         |                  ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:190:21: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     190 |           sta_params->vht_tx_bf_enabled = 1;
         |                     ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:192:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     192 |    sta_params->vht_tx_mu_beamformee_capable = 0;
         |              ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:194:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     194 |   sta_params->vht_tx_channel_width_set = 0;
         |               ^~~~~~~~~~~~~~~~~~~~~~~~
         |               tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
>> drivers/net/wireless/ath/wcn36xx/smd.c:198:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_ht_ldpc_params' [-Wmissing-prototypes]
     198 | void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_ht_ldpc_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:202:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     202 |   sta_params->ht_ldpc_enabled =
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
   drivers/net/wireless/ath/wcn36xx/smd.c:223:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     223 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:226:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     226 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:226:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:227:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     227 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:228:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     228 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:230:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     230 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:231:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     231 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:234:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     234 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:235:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     235 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:236:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     236 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
   drivers/net/wireless/ath/wcn36xx/smd.c:239:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
     239 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_ht_ldpc_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:242:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     242 |  if (wcn->rf_id == RF_IRIS_WCN3680)
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:243:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     243 |   sta_params->ht_ldpc_enabled = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:245:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     245 |   sta_params->ht_ldpc_enabled = 0;
         |             ^~

# https://github.com/0day-ci/linux/commit/87028248512b3c9d58fd5ebe519068336a8cab67
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout 87028248512b3c9d58fd5ebe519068336a8cab67
vim +/wcn36xx_smd_set_sta_ht_ldpc_params +198 drivers/net/wireless/ath/wcn36xx/smd.c

   175	
   176	void wcn36xx_smd_set_sta_vht_params(struct wcn36xx *wcn,
   177			struct ieee80211_sta *sta,
   178			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   179	{
   180		if (sta->vht_cap.vht_supported) {
   181			unsigned long caps = sta->vht_cap.cap;
   182	
   183			sta_params->vht_capable = sta->vht_cap.vht_supported;
   184			sta_params->vht_ldpc_enabled =
   185				is_cap_supported(caps, IEEE80211_VHT_CAP_RXLDPC);
   186			if (get_feat_caps(wcn->fw_feat_caps, MU_MIMO)) {
   187				sta_params->vht_tx_mu_beamformee_capable =
   188					is_cap_supported(caps, IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE);
   189				if (sta_params->vht_tx_mu_beamformee_capable)
   190				       sta_params->vht_tx_bf_enabled = 1;
   191			} else {
 > 192				sta_params->vht_tx_mu_beamformee_capable = 0;
   193			}
   194			sta_params->vht_tx_channel_width_set = 0;
   195		}
   196	}
   197	
 > 198	void wcn36xx_smd_set_sta_ht_ldpc_params(struct ieee80211_sta *sta,
   199			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   200	{
   201		if (sta->ht_cap.ht_supported) {
   202			sta_params->ht_ldpc_enabled =
   203				is_cap_supported(sta->ht_cap.cap, IEEE80211_HT_CAP_LDPC_CODING);
   204		}
   205	}
   206	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]